[$250] Hold IOU - Click 'Mark as paid' on Reports pays the full amount without asking paying option

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.60-20
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-19602/folder/13176872/41237342/1336301741
Email or phone of affected tester (no customers): lekima20+67004@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

1. Open https://staging.new.expensify.com
2. User A navigate to the chat with user B
3. User A create 2 expenses
4. User B navigate to the chat with user A
5. User B hold one expense
6. User B click on Mark as paid

Expected Result:

Verify a prompt is displayed to pay the full report amount or just the amount that is pending

Actual Result:

The full report amount is paid without asking to pay the full report amount or just the amount pending

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @paulnjs

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022046472922929787500
• Upwork Job ID: 2046472922929787500
• Last Price Increase: 2026-04-21

[MelvinBot]

Proposal

What is the root cause of that problem?

In PayPrimaryAction.tsx:76, hasHeldExpenses is called with only the reportID and no transactions array:

const isAnyTransactionOnHold = hasHeldExpensesReportUtils(moneyRequestReport?.reportID);

This causes it to fall back to the deprecated module-level global deprecatedReportsTransactions (populated via a non-reactive Onyx.connect with waitForCollectionCallback: true). When this stale global doesn't reflect the latest hold state (transaction.comment.hold), hasHeldExpenses returns false and the payment proceeds directly without showing the hold prompt.

The same stale-data problem affects MoneyReportHeaderModals.tsx:47, where hasOnlyHeldExpenses also reads from the deprecated global.

Both components already have fresh, reactive transactions from the useTransactionsAndViolationsForReport hook but don't pass them to the hold-detection functions.

What changes do you think we should make in order to solve the problem?

1. PayPrimaryAction.tsx — pass the already-available transactions array (from useTransactionsAndViolationsForReport at line 63-64) to hasHeldExpensesReportUtils:

   hasHeldExpensesReportUtils(moneyRequestReport?.reportID, transactions)
   

2. MoneyReportHeaderModals.tsx — similarly pass the reactive transactions (from line 39-40) to both hasOnlyHeldExpensesReportUtils and getNonHeldAndFullAmount's downstream calls, so the hold menu amounts are also computed from fresh data.

This ensures hold detection uses the reactive hook data instead of the stale deprecated global, and the hold prompt will correctly appear when any transaction is on hold.

What alternative solutions did you explore? (Optional)

An alternative would be to fix deprecatedReportsTransactions itself — either by replacing the module-level Onyx.connect with a reactive mechanism or by ensuring it always reflects the latest state. However, that global is already marked as deprecated and is being migrated away. Passing the already-available reactive transactions is the simpler, more targeted fix that aligns with the ongoing migration.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022046472922929787500

[alexanderxfgl-bit]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user clicks "Mark as paid" on a held IOU, the full amount is paid immediately without a confirmation prompt, even though the user should be asked whether to pay the full report amount or just the pending amount.

What is the root cause of that problem?

The submitAndNavigateToNextPage function in src/pages/iou/MoneyRequestAmountForm.tsx (line 188) directly calls onSubmitButtonPress without checking if a confirmation prompt is required. The skipConfirmation prop, which controls whether the confirmation prompt is shown, is not considered before submitting the amount.

What changes do you think we should make in order to solve the problem?

Add a conditional check before calling onSubmitButtonPress to determine if the confirmation prompt should be displayed. If skipConfirmation is false, proceed with submitting the amount; otherwise, display the confirmation prompt. This ensures the user is prompted to confirm the payment amount before it's processed.

What alternative solutions did you explore? (Optional)

N/A

[alexanderxfgl-bit]

Contributor details
Your Expensify account email: alexanderxfgl@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~2021935202864784599

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[alexanderxfgl-bit]

Compare branch with the fix: https://github.com/Expensify/App/compare/main...alexanderxfgl-bit/App:fix/88375-ai?expand=1

[topstar-ai]

Hi Sir,

I hope you are doing well.

As a senior developer, I’m very interested in joining this task and working toward a high-quality solution. However, since my account is new, I’m currently unable to fully identify or verify the issue, and I don’t see any other users in the chat.

Could you please provide more details on how to access or reproduce the problem? That would help me better understand the situation and contribute effectively.

I would greatly appreciate the opportunity to collaborate and demonstrate my skills and experience.

Best regards,
Emmanuel Cortes