[Due for payment 2026-05-11] Expense - Unable to add existing expense from workspace chat to p2p expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.65-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85225
Email or phone of affected tester (no customers): sdsodijnosdjoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open 1:1 DM with any user.
5. Create an expense.
6. Open the IOU report.
7. Click More > Add expense > Add existing expense.
8. Select the workspace expense from Step 3.
9. Click Add to report.

Expected Result:

Workspace expense should be hidden if it cannot be added to IOU report.

Actual Result:

Workspace expense is shown when it cannot be added to IOU report.
The workspace expense cannot be added to IOU report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7142385_1777591795068.4.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85225

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85225 - "Feat: Change Add unreported expense to Add existing expense in a report" by @nyomanjyotisa (High confidence)
Related Issues: N/A

Recommendation: REVERT

PR #85225 introduced a logic change that expanded the set of expenses shown in the "Add existing expense" flow beyond unreported expenses. The new code includes expenses from any open expense report—including workspace (policy) expense reports—which cannot be added to a 1:1 IOU/p2p report, causing the broken UX described in the issue.

Assigned: @nyomanjyotisa (PR author), @puneetlath, @sobitneupane (approving reviewers)
Labels: DeployBlockerCash kept (Frontend/App PR is the cause). No label changes made.

Detailed Analysis

Evidence

• The melvin-bot comment on the issue directly links PR Feat: Change Add unreported expense to Add existing expense in a report #85225 as the cause, and the issue body links the same PR in the test step reference.
• PR Feat: Change Add unreported expense to Add existing expense in a report #85225 was merged on 2026-04-29 and is present in the 9.3.65-0 staging build where the bug reproduces. The issue is marked as not reproducible on production (new feature), confirming the regression is staging-only and introduced by this PR.
• The PR was explicitly designed to expand the "Add existing expense" flow to include Draft expenses (those already on open expense reports), in addition to unreported expenses.

Verification

• Affected file: src/pages/AddExistingExpense.tsx (renamed from AddUnreportedExpense.tsx)
• Affected selector: src/selectors/Report.ts — new openExpenseReportIDsSelector added
• PR Feat: Change Add unreported expense to Add existing expense in a report #85225 directly modifies both these files. The diff confirms the filtering logic change.

Root Cause

Before PR #85225, getEligibleTransactions (formerly getUnreportedTransactions) only included transactions where reportID === CONST.REPORT.UNREPORTED_REPORT_ID || reportID === '' — truly unreported expenses.

PR #85225 extended this to also include transactions where item.reportID is present in allOpenReports or openReportDrafts (any open expense report). The openExpenseReportIDsSelector uses isOpenExpenseReport, which matches any expense report with stateNum === OPEN and statusNum === OPEN — this includes workspace/policy expense reports.

When a user creates an expense in a workspace chat, it lands on a workspace expense report (which is an open expense report). Under the new logic, that workspace expense is included in the list when adding existing expenses to a 1:1 IOU report. However, the system does not allow moving a workspace expense to a p2p IOU report, so selecting it and pressing "Add to report" fails. The expense should be filtered out before being shown.

The fix should either exclude workspace policy expense reports from openExpenseReportIDsSelector, or add an additional check in getEligibleTransactions to verify the source report type is compatible with the target IOU report before including it in the list.