[Due for payment 2026-05-29] [$250] Total Footer Bar Should Not Be Displayed When “Select All Matching Items” Is Used

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.65-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @brianlee-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to Spend > Expenses (ensure more than 50 items exist)
2. Navigate to Spend > Reports (ensure more than 50 items exist)
3. Select all expenses using bulk select
4. Click “Select all matching items”
5. Observe the footer bar

Expected Result:

The total footer bar should not be displayed when:
“Select all matching items” is active

Actual Result:

The total footer bar is displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

2026-04-29_15-14-03.mp4

Recording.2793.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022050197348605715351
• Upwork Job ID: 2050197348605715351
• Last Price Increase: 2026-05-01

[MelvinBot]

Proposal

What is the root cause of that problem?

The shouldShowFooter condition in SearchPage.tsx:68 never checks areAllMatchingItemsSelected:

const shouldShowFooter = selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count);

When "Select all matching items" is active, the locally loaded items are still in selectedTransactions, so selectedTransactionsKeys.length > 0 is true and the footer always shows.

Additionally, the shouldUseClientTotal logic at SearchPage.tsx:112 has a short-circuit bug:

const shouldUseClientTotal = selectedTransactionsKeys.length > 0 || !metadata?.count || (selectedTransactionsKeys.length > 0 && !areAllMatchingItemsSelected);

The first branch (selectedTransactionsKeys.length > 0) always evaluates to true when items are selected, making the third branch (which checks areAllMatchingItemsSelected) dead code. So areAllMatchingItemsSelected is never consulted.

What changes do you think we should make in order to solve the problem?

Hide the footer when areAllMatchingItemsSelected is true by adding a check to the shouldShowFooter condition in SearchPage.tsx:68:

shouldShowFooter = !areAllMatchingItemsSelected && (selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count))

The dead-code branch in shouldUseClientTotal at line 112 should also be cleaned up to remove the unreachable areAllMatchingItemsSelected check, since the footer won't render in that state anyway.

What alternative solutions did you explore? (Optional)

An alternative would be to keep the footer visible when "Select all matching items" is active but switch to server-provided metadata totals (from metadata.count / metadata.total). This was considered but the issue explicitly states the footer should not be displayed in this state, since the server totals may not match the user's full selection intent and showing partial/estimated totals could be misleading.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the Spend > Expenses and Spend > Reports pages, when there are more than 50 results, the user can bulk-select the visible page and then click "Select all matching items" to extend the selection to every matching item across the full result set. The total footer bar at the bottom of the page is expected to be hidden in that mode (because the client only has the currently loaded slice of items, so any total it could compute would be misleading), but the footer remains visible after "Select all matching items" is clicked.

What is the root cause of that problem?

The footer visibility is decided in SearchPage by shouldShowFooter:

App/src/pages/Search/SearchPage.tsx

Line 68 in 84b6a5f

const shouldShowFooter = selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count);

The condition is selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count). When the user first checks the bulk-select header, the visible items are inserted into selectedTransactions so selectedTransactionsKeys.length becomes greater than 0. Clicking "Select all matching items" then only flips a separate flag, areAllMatchingItemsSelected, in the search context:

App/src/components/Search/SearchBulkActionsButton.tsx

Lines 221 to 228 in 84b6a5f

	{!areAllMatchingItemsSelected && shouldShowSelectAllMatchingItems && (
	<Button
	link
	small
	shouldUseDefaultHover={false}
	innerStyles={styles.p0}
	onPress={() => selectAllMatchingItems(true)}
	text={translate('search.exportAll.selectAllMatchingItems')}

It does not clear selectedTransactions. So selectedTransactionsKeys.length > 0 is still true, and the footer keeps rendering. The "all matching" mode is never represented in shouldShowFooter, even though footerData and the bulk-actions button already branch on areAllMatchingItemsSelected elsewhere in the same file:

App/src/pages/Search/SearchPage.tsx

Lines 107 to 127 in 84b6a5f

	const footerData = useMemo(() => {
	if (!shouldAllowFooterTotals && selectedTransactionsKeys.length === 0) {
	return {count: undefined, total: undefined, currency: undefined};
	}
	const shouldUseClientTotal = selectedTransactionsKeys.length > 0 || !metadata?.count || (selectedTransactionsKeys.length > 0 && !areAllMatchingItemsSelected);
	const selectedTransactionItems = Object.values(selectedTransactions);
	const currency = metadata?.currency ?? selectedTransactionItems.at(0)?.groupCurrency ?? selectedTransactionItems.at(0)?.currency;
	const numberOfExpense = shouldUseClientTotal
	? selectedTransactionsKeys.reduce((count, key) => {
	const item = selectedTransactions[key];
	if (item.action === CONST.SEARCH.ACTION_TYPES.VIEW && key === item.reportID) {
	return count;
	}
	return count + 1;
	}, 0)
	: metadata?.count;
	const total = shouldUseClientTotal ? selectedTransactionItems.reduce((acc, transaction) => acc - (transaction.groupAmount ?? -Math.abs(transaction.amount)), 0) : metadata?.total;
	return {count: numberOfExpense, total, currency};
	}, [areAllMatchingItemsSelected, metadata?.count, metadata?.currency, metadata?.total, selectedTransactions, selectedTransactionsKeys, shouldAllowFooterTotals]);

The same shouldShowFooter value is forwarded to both SearchPageWide and SearchPageNarrow, so the bug shows on both layouts.

What changes do you think we should make in order to solve the problem?

In src/pages/Search/SearchPage.tsx, gate shouldShowFooter on areAllMatchingItemsSelected being false in addition to the existing conditions. areAllMatchingItemsSelected is already destructured from useSearchStateContext() a few lines above, so no extra wiring is needed. Concretely, change shouldShowFooter so that it stays false whenever "Select all matching items" is active, regardless of whether items are still present in selectedTransactions or whether the server returned a result count. Once this flag flips to true, both SearchPageWide and SearchPageNarrow will skip rendering SearchPageFooter, which matches the expected behavior described in the issue.

This fix is intentionally narrow: it only affects the visibility of the totals footer in the "all matching items" mode and does not touch footerData, the bulk-actions button, the selection state, or any of the existing branches that already differentiate the two modes.

Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/89389-search-footer-hide-all-matching?expand=1

What alternative solutions did you explore? (Optional)

Hiding the footer from inside SearchPageFooter itself by reading areAllMatchingItemsSelected from the search context was considered, but shouldShowFooter is also used by SearchPageWide to decide style/layout (paddingBottom, sticky offset) — see:

App/src/pages/Search/SearchPageWide.tsx

Lines 77 to 82 in 84b6a5f

	if (shouldShowFooter) {
	return [styles.mtAuto, styles.pAbsolute, styles.h10, styles.b0];
	}
	return [styles.mtAuto];
	}, [shouldShowFooter, styles]);

Hiding only the inner component would leave a phantom gap. Gating shouldShowFooter at the source keeps the layout, the conditional render, and the data hook all consistent.

Clearing selectedTransactions when the user clicks "Select all matching items" was also considered, but that would change the semantics of the bulk-actions flow that already relies on a non-empty selectedTransactions plus the areAllMatchingItemsSelected flag together (for example when the user later toggles the "all matching" mode off and expects the original visible selection to remain).

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user selects all items on the current page and then clicks "Select all matching items" (which represents a virtual selection across all paginated results), the total footer bar remains visible. The totals shown in that footer only reflect the currently loaded transactions, not the full set of matching items, so the displayed values are misleading.

What is the root cause of that problem?

The shouldShowFooter flag in SearchPage.tsx is computed as:

const shouldShowFooter = selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count);

App/src/pages/Search/SearchPage.tsx

Line 68 in 84b6a5f

const shouldShowFooter = selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count);

This evaluates to true whenever any transactions are selected — including when areAllMatchingItemsSelected is true. The areAllMatchingItemsSelected state is already tracked in SearchContext (set when the user clicks "Select all matching items") and is already imported into SearchPage.tsx at line 32, but it is never used to gate the footer's visibility. Since all-matching-items mode selects items beyond the loaded page, the selectedTransactionsKeys array only covers the current page's loaded items, making the count and total values in the footer incorrect for the full selection.

What changes do you think we should make in order to solve the problem?

In src/pages/Search/SearchPage.tsx, update the shouldShowFooter computation to return false when areAllMatchingItemsSelected is true. The areAllMatchingItemsSelected value is already destructured from useSearchStateContext() at line 32 — it just needs to be wired into the condition:

const shouldShowFooter = !areAllMatchingItemsSelected && (selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count));

App/src/pages/Search/SearchPage.tsx

Line 68 in 84b6a5f

const shouldShowFooter = selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count);

This single-line change suppresses the footer exactly when the full cross-page virtual selection is active, while preserving existing footer behavior in all other cases (normal per-item selection and the unconditional totals footer when no items are selected).

What alternative solutions did you explore? (Optional)

An alternative would be to show the footer but display a different message (e.g. "All matching items selected — totals not available") instead of hiding it entirely. However, this adds UI complexity and the issue description explicitly states the footer should not be displayed at all in this mode, so hiding it is the cleaner and more aligned solution.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022050197348605715351

[wildan-m]

Proposal updated — added compare branch with implementation.

[neerajbachani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user selects all items and then clicks "Select all matching items" in the Search page (Expenses or Reports with 50+ items), the total footer bar remains visible. It should hide when "Select all matching items" is active since the total cannot be accurately computed client-side for the full matching set.

What is the root cause of that problem?

In src/pages/Search/SearchPage.tsx, the shouldShowFooter condition does not account for the areAllMatchingItemsSelected state:
selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count)

When "Select all matching items" is active, selectedTransactionsKeys.length > 0 is still true (the current page items are selected), so the condition remains true and the footer stays visible. There is no guard that hides the footer specifically when areAllMatchingItemsSelected is true.

Additionally, the footerData memo has a redundant shouldUseClientTotal clause — selectedTransactionsKeys.length > 0 && !areAllMatchingItemsSelected — that adds areAllMatchingItemsSelected as a dependency without meaningfully affecting the computed output, since the footer should not be shown at all in that state.

What changes do you think we should make in order to solve the problem?

Only src/pages/Search/SearchPage.tsx needs to change.

1. Fix shouldShowFooter — add an explicit areAllMatchingItemsSelected gate:

!areAllMatchingItemsSelected && (selectedTransactionsKeys.length > 0 || (shouldAllowFooterTotals && !!metadata?.count))

2. Simplify footerData memo — remove the redundant areAllMatchingItemsSelected clause from shouldUseClientTotal, keeping behavior equivalent by relying on selectedTransactionsKeys.length > 0 || !metadata?.count alone. Remove areAllMatchingItemsSelected from the footerData dependency array since it no longer affects the computed output.

shouldShowFooter is consumed in SearchPageWide.tsx (footer render + offline indicator style branch) and SearchPageNarrow/index.tsx (footer render gate) — both correctly respond to the boolean so no changes are needed there.

What alternative solutions did you explore? (Optional)

Hiding the footer inside SearchPageWide and SearchPageNarrow individually instead of at the shouldShowFooter source. Rejected — shouldShowFooter is the single source of truth consumed by both layouts, fixing it there keeps both layouts aligned and avoids duplicating the guard logic.