Prohibited expense violations missing from report preview

[MelvinBot]

Prohibited expense violations don't appear on report previews in workspace chat. This affects all prohibited expense types, not just the new handwrittenReceipt toggle.

Root cause: mergeProhibitedViolations creates a merged violation object without showInReview: true. The transaction preview calls hasViolation(..., true), which filters out violations missing showInReview: true, so shouldShowRBR is false and the red dot + message are suppressed.

Expected behavior: Prohibited expense violations should show the red brick road (RBR) indicator and violation message on the report preview, just like they do on the individual expense.

Recommended fix: Add showInReview: true to the merged violation object in mergeProhibitedViolations:

const mergedProhibitedViolations: TransactionViolation = {
    name: CONST.VIOLATIONS.PROHIBITED_EXPENSE,
    data: { prohibitedExpenseRule: prohibitedExpenses },
    type: CONST.VIOLATION_TYPES.VIOLATION,
    showInReview: true,  // <-- add this
};

Found in: #87533

[dangrous]

@MelvinBot confirm solution and draft a PR. Confirm this is a pattern used elsewhere in the app and it does not require any backend changes - or if it does, let me know.

[MelvinBot]

🤖 Solution confirmed — no backend changes needed.

showInReview is a client-side-only flag on TransactionViolation. It's set in 24+ places across the codebase (ViolationsUtils.ts, Hold.ts, RejectMoneyRequest.ts, AttendeeUtils.ts, DistanceRate.ts, etc.) — every other violation creator already sets showInReview: true. The mergeProhibitedViolations function was the only one missing it.

Draft PR created: #89634

Please mark it as "Ready for review" when it is ready for review.

[MelvinBot]

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details