[Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Expense - Inconsistent error message after duplicating manually edited distance expense.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.69-3
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89858
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create a map distance expense.
4. Open the just created expense.
5. Click on "Distance" > "Manual"
6. Edit the distance and save it.
7. After being redirected to report, note that a "Distance exceeds the calculated route of XX" error appears on distance field.
8. Click on "More" > "Duplicate Expense"
9. Note that after duplicating expense, a "Amount differs from calculated distance" error, appears on duplicate, different from the one displayed on original expense.

Expected Result:

Distance related error messages should be the same on original expense and on duplicate after duplicating manually edited distance expense.

Actual Result:

Inconsistent error messages displayed after duplicating a manually edited distance expense. "Distance exceeds from the calculated route of XX" error is shown on original expense, while a "Amount differs from calculated distance" error appears on duplicate.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7148930_1778294888609.Dis_Dup.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022053833556830974000
• Upwork Job ID: 2053833556830974000
• Last Price Increase: 2026-05-11

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

@youssef-lr recently merged #89858, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #89858 - "fixed manual distance tab blockers" by @mukhrr (High confidence)
Related Issues: #83781 (the issue this PR fixed)

Recommendation: REVERT

PR #89858 introduced a change to getTransactionDetails in src/libs/ReportUtils.ts that now always includes the distance field for any distance request (not just manual ones). This causes the duplicate of a manually-edited map expense to be created with both waypoints and a distance value in transactionParams, leading to a different server-side violation than the original expense shows.

Assigned: @mukhrr (PR author), @aimane-chnaif and @youssef-lr (approving reviewers) from causing PR
Labels: DeployBlockerCash kept — this is a frontend App bug. No label changes made.

📋 Detailed Analysis

Evidence

• The melvin-bot comment on this issue directly links PR fixed manual distance tab blockers #89858 as the recently merged PR in the affected area.
• PR fixed manual distance tab blockers #89858 is present in the current StagingDeployCash (version 9.3.69-3), and the issue is "Reproducible in staging? Yes / Reproducible in production? N/A - new feature."
• The bug did not exist before this PR landed (it is tagged as a new feature in the issue), which is consistent with it being introduced by this staging-only PR.

Verification

The affected files are in src/libs/ReportUtils.ts, src/libs/TransactionUtils/index.ts, and src/libs/actions/IOU/Duplicate.ts. PR #89858 modifies src/libs/ReportUtils.ts and src/libs/TransactionUtils/index.ts.

The key change in src/libs/ReportUtils.ts at line ~4618 (getTransactionDetails):

• Before PR fixed manual distance tab blockers #89858: ...(isManualDistanceRequest && {distance: transaction.comment?.customUnit?.quantity ?? undefined})
• After PR fixed manual distance tab blockers #89858: ...(isDistanceRequest(transaction) && {distance: transaction.comment?.customUnit?.quantity ?? undefined})

This means getTransactionDetails now always returns a distance field for any distance request — including map (waypoint-based) ones where the user has manually edited the distance field. Previously, distance was only populated for manual distance requests.

Root Cause

When duplicating a manually-edited map expense, buildDuplicateTransactionParams in src/libs/actions/IOU/Duplicate.ts calls getTransactionDetails to build the new transaction parameters. After PR #89858's change, transactionParams now carries both validWaypoints (from waypoints) and distance (from quantity, which holds the manually-edited value) for a map expense that was manually adjusted.

Inside createDistanceRequest (src/libs/actions/IOU/Split.ts), both distance and waypoints are forwarded to the API. The server receives a map expense with waypoints (computing a route-based violation — increasedDistance) but the duplicate receives the same waypoints and the manual quantity, which the server interprets differently, producing a modifiedAmount violation of type distance instead. This results in the two different error messages:

• Original: "Distance exceeds the calculated route of XX" (increasedDistance violation)
• Duplicate: "Amount differs from calculated distance" (modifiedAmount distance violation)

The violation type diverges because the duplicate's modifiedAmount is set to the original manually-edited amount while the route recalculation on the server yields a different base amount, triggering modifiedAmount instead of increasedDistance.