Bank Account - Click device back on success modal direct to Add BA flow and unable to continue

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.69-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-27459/folder/13176694/41236763/1401784972?sort=-identifier
Email or phone of affected tester (no customers): applausetester+dk30@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 Home/Chrome
App Component: Workspace Settings

Action Performed:

1. Open https://staging.new.expensify.com/
2. Create a USD workspace
3. Go to Workflow
4. Add bank account
5. Finish the Add BA flow and reach the success modal
6. Click device back button (swipe back on mobile)

Expected Result:

RHN modal should close

Actual Result:

User is navigated back to Add BA flow. Click on Continue/Confirm button, an error is shown

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7148989_1778305882895.swipe_back_navigate_to_add_ba_flow.mp4

Bug7148989_1778305882872.bandicam_2026-05-09_12-36-46-592.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #88193 - "feat: 79048 restore reverted usd flow" by @MrMuzyk (High confidence)
Related Issues: #79048, #87658

Recommendation: REVERT

PR #88193 introduced a new screen-based navigation architecture for the USD bank account flow that reintroduced this back-navigation bug. Reverting it will restore the previous single-screen state-machine approach that handled back navigation correctly.

Assigned: @MrMuzyk (PR author), @dukenv0307 (approving reviewer), @arosiclair (approving reviewer)
Labels: DeployBlockerCash kept (frontend bug in App repo). No label changes made.

Details

Evidence

• The bug report describes: after completing the Add Bank Account flow and reaching the "You're all set" success modal, pressing the device back button (hardware back or swipe gesture) navigates the user back into the Add BA flow instead of closing the modal.
• PR [CP Staging] Fix navigation problems in USD BA flow #87624 previously fixed this exact same symptom ("Success modal back button navigates to previous step instead of closing RHP") by changing onBackButtonPress={onBackButtonPress} to onBackButtonPress={() => Navigation.dismissModal()} in ConnectBankAccount.tsx.
• PR feat: 79048 restore reverted usd flow #88193 (merged May 7, 2026) "restores the previously reverted USD flow refactor" and replaced the old single-screen USDVerifiedBankAccountFlow component with a new USDVerifiedBankAccountFlowPage that uses separate navigation screens for each step.

Verification

• Affected files: src/pages/ReimbursementAccount/USD/ConnectBankAccount/ConnectBankAccount.tsx, src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx
• PR feat: 79048 restore reverted usd flow #88193 modifies both of these files. Confirmed.
• PR feat: 79048 restore reverted usd flow #88193 was merged on May 7, 2026. The issue version is 9.3.69-0, which is consistent with this being a staging-only regression introduced after v9.3.68.

Root Cause

The old USDVerifiedBankAccountFlow rendered all flow steps as different render states of a single screen using an in-memory step state variable (USDBankAccountStep). Because only one screen entry was ever pushed to the navigation stack, pressing the device hardware/swipe back button would pop the entire modal.

PR #88193 replaced this with USDVerifiedBankAccountFlowPage, where each step navigates to ROUTES.BANK_ACCOUNT_USD_SETUP with different page URL params. This pushes separate entries into the React Navigation stack for every step. When the user reaches the final "You're all set" success screen (ConnectBankAccount with bankAccountState === OPEN) and presses the device back button, the navigator pops to the previous stack entry — the ACH_CONTRACT / CompleteVerification step — instead of dismissing the modal.

The header back button correctly calls Navigation.dismissModal() because ConnectBankAccount.tsx overrides the onBackButtonPress prop for the OPEN state. However, the device/swipe back bypasses this override entirely and uses the navigator's native stack pop behavior.