Skip to content

Standardize Expense Report and Expense header with predictable button placement and carousel counter #90366

@shawnborton

Description

@shawnborton

We have mixed styles for showing the carousel counter on the expense report header as well as the expense header. Sometimes the carousel counter has a "X of X" label, though it doesn't on expenses. We also don't always show the expense carousel counter when you view expenses from the Spend page - we only show it when you view an expense from within an expense report.

We also show the carousel counter buttons on the same line as the next steps, which feels counter intuitive given that the carousel counter is more of a parent item not attached to next steps.

We'd like to standardize on the buttons here across the two types: expense reports and expenses:

Image

Notable changes:

  • Let's move the report buttons to be down near the report next steps, on the same vertical line
  • Let's always have the carousel buttons in the top right
  • Let's make sure we always show the carousel for expenses when you access expenses from the Spend page, the same way you see a carousel when accessing Reports from the Reports page

Once we have this framework in place, we'll be able to do things like launch a violation fixer from Home that will always have a consistent carousel button placement.

cc @JmillsExpensify @trjExpensify @dannymcclain @dubielzyk-expensify

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions