[Due for payment 2026-05-22] [Due for payment 2026-05-20] Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.73-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-28526/folder/13176676/41236544/1410970339?sort=%2Bidentifier
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Google Pixel 7a - Android 16
App Component: Workspace Settings

Action Performed:

Preconditions:

*Execute in Web:

• Create a new account
• Create 2 collect workspace
• Go to OD and make Individual Workspace as default

*Execute in Android

• Go back ND

1. Open https://staging.new.expensify.com/
2. Go to 1 of workspace
3. Enable Tags
4. Add 1 tag
5. Tap on 'More'
6. Tap on 'Import spreadsheet'
7. Tap on the "Multi-level of tags"
8. Tap on the "Upgrade" button
9. Tap on the "Got it Thanks" button
10. Tap on the "Switch Tag Levels" button

Expected Result:

the Import spreadsheet modal displayed with a "Choose file" button

Actual Result:

the Import spreadsheet modal is not displayed

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7152636_1778666537682.Android.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

After tapping "Switch Tag Levels", the confirm modal sets isVisible=false and waits for onModalHide to fire before resolving the promise and navigating to the import spreadsheet page. On Android, onModalHide is called exclusively from onCloseCallBack — which fires only after the Container's Reanimated exit animation completes via scheduleOnRN(onCloseCallBack).

PR #90358 (merged May 13) refactored ReanimatedModal and introduced two changes that affect this callback chain on Android:

1. onCloseCallBack lost its useCallback wrapper — it is now recreated every render. The Container's Exiting animation is memoized with onCloseCallBack as a dependency, so it also recreates every render. The worklet closure that calls scheduleOnRN(onCloseCallBack) now captures a potentially stale or unstable function reference on the UI thread.

2. The Container now unmounts one render earlier — the old code used an intermediate isVisibleState that lagged the isVisible prop by one render, giving Reanimated an extra render cycle to prepare the exit animation. The new code renders the Container directly with {isVisible && containerView}, so the Container is removed from the tree in the same render where isVisible flips to false. On Android (where LayoutAnimationConfig skipExiting is true), this can prevent the exit animation callback from firing entirely.

When onCloseCallBack doesn't fire on Android, onModalHide is never called → handleModalHide never runs → closeModal never resolves the promise → the startMultiLevelTagImportFlow code after await showConfirmModal(...) never executes → Navigation.navigate to the import spreadsheet page is never called.

What changes do you think we should make in order to solve the problem?

Revert the two behavioral changes from PR #90358 that affect the Android exit animation callback:

1. Restore useCallback on onCloseCallBack (and onOpenCallBack) in ReanimatedModal/index.tsx so the Container's Exiting animation has a stable function reference for the worklet.

2. Restore the one-render lag for Container unmount on Android — either bring back isVisibleState or add an equivalent mechanism so the Container isn't removed from the render tree in the same render where isVisible flips to false. This gives Reanimated time to register and play the exit animation before the component unmounts.

The rest of the React Compiler compliance changes from PR #90358 (derived isTransitioning, useEffectEvent for lifecycle callbacks, etc.) can remain.

What alternative solutions did you explore? (Optional)

• Add a fallback onModalHide call on Android when the exit animation doesn't fire: e.g., in a useEffect cleanup that detects when isTransitioning changes but onCloseCallBack was never invoked. This is more fragile and adds complexity.
• The react-native-screens upgrade (PR [No QA] chore: upgrade react-native-screens to 4.25.0 #89199, 4.15.4 → 4.25.0) was also investigated as a potential contributor, but the code trace points squarely at the modal callback chain rather than screen transition behavior.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.