Skip to content

[$250] Migrate NetSuiteCustomListSelectorModal to @react-navigation modal screen #90471

@mountiny

Description

@mountiny

Context

This is a sub-issue of #53493 (Replace modal screens with modals from @react-navigation).

For full background and migration approach, see the triage analysis comment and the sub-issue breakdown comment.

Problem

NetSuiteCustomListSelectorModal is currently implemented using react-native-modal, which causes animation inconsistencies on native platforms.

Migration approach (Group 3 — Write to known form draft)

Used via InputWrapper in only one place with a known formID/inputID. The new navigation page writes directly to the Onyx form draft, and FormProvider merges it reactively.

  • File: src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListSelectorModal.tsx
  • Used by: Only NetSuiteCustomListPickerChooseCustomListStep.tsx
  • On select: onCustomListSelected(item)onInputChange(item.value) + onInputChange(item.id, internalIDInputID)
  • State destination: Form NETSUITE_CUSTOM_LIST_ADD_FORM, fields listName and internalID

Steps

  1. Create a new @react-navigation modal route for NetSuite custom list selection.
  2. Extract the modal content into a standalone screen component.
  3. On selection, the screen writes directly to NETSUITE_CUSTOM_LIST_ADD_FORM form draft fields listName and internalID via Onyx, then navigates back.
  4. Replace the <NetSuiteCustomListSelectorModal /> usage with a navigation call.
  5. Test the NetSuite custom list import flow on iOS, Android, and web.

Reference

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022054512672280874036
  • Upwork Job ID: 2054512672280874036
  • Last Price Increase: 2026-05-20
Issue OwnerCurrent Issue Owner: @trasnake87

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions