[Due for payment 2026-05-22] Android - No option to add the 2nd company card

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.74-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90528
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Samsung s10/ Android 12
App Component: Workspace Settings

Action Performed:

1. Open the app
2. Log in to New Expensify with an account that can add company cards to a workspace.
3. Navigate to Settings > Workspaces > [workspace] > Company cards.
4. Click Issue new card, then choose Commercial feed.
5. Select Visa, Mastercard, or American Express (any non-Stripe commercial bank), then continue to the feed details step.
6. Fill in the required feed details (e.g. Distribution ID for Mastercard, or Processor/Bank/Company IDs for Visa, or Delivery file name for Amex).
7. Click Submit and verify the feed is created and you are returned to the workspace's Company cards page.
8. Try to repeat for at least one other bank type to confirm the label is consistent across providers.

Expected Result:

User can able to add another card after adding the first.

Actual Result:

No option to add the 2nd company card to validate step 8

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #90528

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #89924 - "Update table component to have default styling" by @JS00001 (High confidence)
Related Issues: N/A

Recommendation: REVERT

PR #89924 removed the shouldRenderHeaderAsChild logic that guaranteed the header buttons (including the FeedSelector) were always visible on narrow/mobile layouts when the feed was in a pending or loading state. Reverting this PR would restore the correct behavior where the FeedSelector is visible on Android after adding the first card feed.

Assigned: @JS00001 (PR author), @Krishna2323 and @luacmartins (approving reviewers) from highest-confidence causing PR only
Labels: DeployBlockerCash kept (App PR caused this). DeployBlocker not present, no change needed.

📋 Detailed Analysis

Evidence

The melvin-bot initially flagged PR #90528 because the QA test was run as part of that PR's review. However, PR #90528 only changes a button label from common.next to common.submit in DetailsStep.tsx — a purely cosmetic change that cannot affect navigation or the ability to add a second card feed. The real cause is PR #89924.

PR #89924 moved WorkspaceCompanyCardsTable from src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/ to src/components/Tables/WorkspaceCompanyCardsTable/ and refactored how the header buttons are rendered on narrow (mobile) layouts.

Before PR #89924, the header rendering used:

const shouldRenderHeaderAsChild =
  !shouldUseNarrowTableLayout ||
  ((isFeedPending || isLoadingPage) && !showCards);
// ...
{
  shouldRenderHeaderAsChild && headerButtonsComponent;
}

This meant: on narrow layout, if the feed was pending (isFeedPending) or loading (isLoadingPage) and cards were not showing, the header buttons were rendered as a direct child of the Table wrapper — always visible regardless of whether the FlashList (Table.Body) was rendered.

After PR #89924, the header rendering was changed to:

{
  !shouldUseNarrowTableLayout && ListHeader;
}

And for narrow layout, the header is only passed via:

ListHeaderComponent={shouldUseNarrowTableLayout ? ListHeader : undefined}

The ListHeaderComponent is consumed by Table.Body (FlashList). However, Table.Body is only rendered when showCards is true:

{
  showCards && (
    <Table.Body contentContainerStyle={tableBodyContentContainerStyle} />
  );
}

And showCards is false when isFeedPending:

const showCards =
  !isInitiallyLoadingFeeds &&
  !isFeedPending &&
  !isNoFeed &&
  !isLoading &&
  !hasFeedErrors;

Result: On Android (narrow layout), after adding the first company card feed, the feed enters a pending state. The WorkspaceCompanyCardsTableHeaderButtons component (which contains the FeedSelector that navigates to WorkspaceCompanyCardFeedSelectorPage for adding another card) is never rendered. The user has no visible way to add a second card feed.

Verification

• Affected files: src/components/Tables/WorkspaceCompanyCardsTable/index.tsx
• PR Update table component to have default styling #89924 directly modifies this file and removes the shouldRenderHeaderAsChild logic
• The FeedSelector in WorkspaceCompanyCardsTableHeaderButtons triggers navigation to WORKSPACE_COMPANY_CARDS_SELECT_FEED, which has the "Add cards" menu item (the route to AddNewCardPage)
• The bug is Android/narrow-layout-specific, consistent with the issue report which only marks Android App as affected

Root Cause

PR #89924 refactored the WorkspaceCompanyCardsTable component to use ListHeaderComponent for narrow layouts instead of rendering the header as a direct child. This refactor failed to account for the case where Table.Body (FlashList) is not rendered — specifically when isFeedPending || isLoading || isNoFeed. In those states, the ListHeaderComponent is never shown because the FlashList itself is not mounted, making the header buttons (including the FeedSelector that enables adding more card feeds) invisible on Android.