Manual tab shows scan confirm page after uploading receipt on Scan and returning to Manual

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.74-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87920
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Scan.
4. Upload a receipt.
5. Click RHP back button.
6. Go to Manual tab.

Expected Result:

Manual tab will not show scan confirm page.

Actual Result:

Manual tab shows scan confirm page after uploading receipt on Scan and returning to Manual.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #87920

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #87920 - "Feat: Manual expense flow UI refactor - r3" by @ChavdaSachin (High confidence)
Related Issues: #82586 (the issue this PR fixed)

Recommendation: REVERT

PR #87920 introduced a regression in the newManualExpenseFlow beta: after uploading a receipt on the Scan tab and navigating back, switching to the Manual tab still shows the scan confirm page instead of the manual input form.

Assigned: @ChavdaSachin (PR author), @ShridharGoel, @puneetlath (approving reviewers) from highest-confidence causing PR only
Labels: DeployBlockerCash kept (Frontend bug in App PR). No label changes made.

Details

Evidence

• PR Feat: Manual expense flow UI refactor - r3 #87920 changed the CONST.TAB_REQUEST.MANUAL tab in IOURequestStartPage.tsx to render IOURequestStepConfirmation instead of IOURequestStepAmountWithTransactionOnly when isNewManualExpenseFlowEnabled is true.
• Before this PR, the Manual tab showed the amount entry step, which is entirely independent from the scan flow state.
• After this PR, the Manual tab now shows the confirmation page (IOURequestStepConfirmation), which determines whether to render the scan confirm UI or the manual input form based on requestType.
• The requestType is derived from transaction.iouRequestType, which is persisted in the Onyx transaction draft.
• When a user uploads a receipt on the Scan tab, iouRequestType is set to SCAN in the draft. Clicking the RHP back button does not reset iouRequestType.
• When the user then switches to the Manual tab, IOURequestStepConfirmation is rendered with the same stale SCAN transaction draft, so requestType === CONST.IOU.REQUEST_TYPE.SCAN.
• The key logic in IOURequestStepConfirmation.tsx (line 667): const shouldShowSmartScanFields = ... || requestType !== CONST.IOU.REQUEST_TYPE.SCAN; evaluates to false, causing the scan confirmation UI to be shown instead of the manual fields.

Verification

• Affected file: src/pages/iou/request/IOURequestStartPage.tsx — PR Feat: Manual expense flow UI refactor - r3 #87920 directly modified this file to embed IOURequestStepConfirmation in the Manual tab.
• Affected file: src/pages/iou/request/step/IOURequestStepConfirmation.tsx — PR Feat: Manual expense flow UI refactor - r3 #87920 modified this file extensively (229 additions, 35 deletions) including the shouldShowSmartScanFields logic that controls what UI is displayed.
• The bug is staging-only; this feature (newManualExpenseFlow) does not exist in production, consistent with the report ("Reproducible in production?: N/A - new feature, doesn't exist in prod").

Root Cause

When isNewManualExpenseFlowEnabled is active, IOURequestStartPage renders IOURequestStepConfirmation directly in the Manual tab. This confirmation component reads transaction.iouRequestType to determine if it is a scan flow. If a user previously used the Scan tab and uploaded a receipt, the transaction draft retains iouRequestType = SCAN. Switching to the Manual tab renders the same draft through IOURequestStepConfirmation, which then renders the scan confirmation UI because requestType is still SCAN. The Manual tab's embedded confirmation page does not reset or override iouRequestType when the tab changes.