Expense - Nothing happens after selecing expired workspace in participant list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.74-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87920
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
• Account has expired workspace.

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual.
3. Select expired workspace.
4. Click RHP back button.

Expected Result:

In Step 3, after selecting expired workspace, RHP will open Add payment card page.

Actual Result:

In Step 3, after selecting expired workspace, nothing happens.
In Step 4, after clicking RHP back button, Add payment card page is shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7154029_1778762285000.24.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #87920

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #87920 - "Feat: Manual expense flow UI refactor - r3" by @ChavdaSachin (High confidence)
Related Issues: #82586 (original issue this PR fixed)

Recommendation: REVERT

The causing PR introduced a regression in the expired workspace billing restriction flow that is scoped only to the new newManualExpenseFlow beta. Reverting PR #87920 is the safest path since the fix would require careful handling of modal-vs-navigation ordering within the new flow architecture.

Assigned: @ChavdaSachin (PR author), @ShridharGoel and @puneetlath (approving reviewers) from PR #87920
Labels: DeployBlockerCash kept (Frontend bug — App PR is the cause). No label changes made.

Detailed Analysis

Evidence

• The issue report explicitly links to PR Feat: Manual expense flow UI refactor - r3 #87920 as the source (melvin-bot auto-assigned based on this PR)
• PR Feat: Manual expense flow UI refactor - r3 #87920 is in the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-05-13 #90562), still unchecked, confirming it is in the current staging deploy
• The bug requires the newManualExpenseFlow beta (Onyx.merge('betas', ['newManualExpenseFlow'])) — a feature introduced by PR Feat: Manual expense flow UI refactor - r3 #87920
• The issue is staging-only / new feature (not reproducible in production since the beta does not exist there)

Verification

• PR Feat: Manual expense flow UI refactor - r3 #87920 modifies src/pages/iou/request/step/IOURequestStepConfirmation.tsx (+229/-35 lines) and introduces src/components/ParticipantPicker.tsx (new file, +94 lines) — these are the exact files involved in the bug
• The ParticipantPicker component is rendered as a Right Docked Modal inside IOURequestStepConfirmation when isNewManualExpenseFlowEnabled is true
• ParticipantSearchResults.onSelectRow (at /home/runner/_work/App/App/src/pages/iou/request/ParticipantSearchResults.tsx lines 448–466) handles the expired workspace case by calling Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(option.policyID)) and returning early

Root Cause

In the old flow, IOURequestStepParticipants renders MoneyRequestParticipantsSelector as a plain screen. When a user selects an expired workspace, ParticipantSearchResults.onSelectRow navigates to ROUTES.RESTRICTED_ACTION (which shows WorkspaceRestrictedActionPage → "Add payment card" button) — this works correctly because the selector is not inside a modal.

In the new newManualExpenseFlow, the ParticipantPicker is rendered as a Right Docked Modal inside IOURequestStepConfirmation. When the user selects an expired workspace:

1. Navigation.navigate(ROUTES.RESTRICTED_ACTION...) fires inside the open modal
2. The code returns early without calling onFinish or onParticipantsAdded, so closeParticipantPicker is never called
3. The RESTRICTED_ACTION navigation succeeds (the billing restriction page is pushed to the stack), but the ParticipantPicker modal remains open on top of it — visually blocking the new screen
4. This manifests as "nothing happens" when clicking the expired workspace

The user then observes the "Add payment card" page only after pressing the RHP back button, because that back press dismisses the ParticipantPicker modal, revealing the WorkspaceRestrictedActionPage that was already navigated to underneath it.

The fix requires closing the ParticipantPicker modal before (or simultaneously with) navigating to RESTRICTED_ACTION, which requires non-trivial changes to ParticipantSearchResults.onSelectRow to accept an optional onBeforeNavigate callback (or similar pattern).