[Due for payment 2026-05-29] [$250] Spend - Member's report shows Submit instead of View on Spend > Reports

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.75-6
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89889
Email or phone of affected tester (no customers): sodjnosdjosjdoijso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Admin invites member to workspace.

1. Go to staging.new.expensify.com
2. [Member] Create an expense in workspace chat. Do not click Submit.
3. [Admin] Open member's workspace chat.
   → Report preview shows View button.
4. [Admin] Go to Spend > Reports.

Expected Result:

Report row will also shows View button.

Actual Result:

Report row shows Submit button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7157248_1779120182608.19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022057481436673436699
• Upwork Job ID: 2057481436673436699
• Last Price Increase: 2026-05-21
• Automatic offers:
• aimane-chnaif | Reviewer | 111497391

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

@luacmartins recently merged #89889, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89889 - "Always show green Submit badge/button when report is ready to submit" by @luacmartins (High confidence)
Related Issues: #89444 (fixed by the causing PR)

Recommendation: REVERT

PR #89889 partially fixed the submit/view button logic — it correctly updated ReportPreviewActionUtils.ts and SubmitActionButton.tsx to restrict the Submit button to submitters only, but it left canSubmitReport in src/libs/actions/IOU/ReportWorkflow.ts unchanged. That function (line 254) still includes report?.managerID === currentUserAccountID || isAdmin in its return condition, which is used by SearchUIUtils.ts (line 2399) to determine the action button shown in Spend > Reports. As a result, an admin viewing a member's open expense report sees a Submit button on the Spend > Reports page even though the report preview card now correctly shows View.

Assigned: @luacmartins (PR author), @aimane-chnaif (approving reviewer)
Labels: DeployBlockerCash kept (Frontend bug — fix requires App repo change). No label changes made.

Detailed Analysis

Evidence

• The issue body links directly to PR Always show green Submit badge/button when report is ready to submit #89889 as the reproduction reference
• melvin-bot auto-comment on the issue identifies @luacmartins as the author of Always show green Submit badge/button when report is ready to submit #89889
• The PR explicitly removes isManager and isAdmin from canSubmit in ReportPreviewActionUtils.ts to prevent admins/managers from seeing the Submit button — but only in the report preview card path
• The Spend > Reports page uses a different code path: SearchUIUtils.ts calls canSubmitReport from src/libs/actions/IOU/ReportWorkflow.ts, which was NOT modified by the PR
• canSubmitReport in ReportWorkflow.ts at line 252-262 still returns true when report?.managerID === currentUserAccountID || isAdmin, meaning admins still get a Submit action on the Spend > Reports page

Verification

• Affected files:
  • src/libs/actions/IOU/ReportWorkflow.ts — canSubmitReport function (line 234-263), which still allows admin/manager to submit
  • src/libs/SearchUIUtils.ts — calls canSubmitReport at line 2399 to determine the action button shown in Spend > Reports rows
• PR Always show green Submit badge/button when report is ready to submit #89889 only modifies: ReportPreviewActionButton.tsx, SubmitActionButton.tsx, ReportPreviewActionUtils.ts, reportAttributes.ts, and a test file — it does NOT touch ReportWorkflow.ts or SearchUIUtils.ts
• This confirms the fix was incomplete: the Spend > Reports path was missed

Root Cause

PR #89889 intentionally changed canSubmit in ReportPreviewActionUtils.ts to only allow the report submitter (owner) to see the Submit button on the report preview card. However, the Spend > Reports page uses a separate canSubmitReport function in ReportWorkflow.ts that still checks ownerAccountID || managerID || isAdmin. The two code paths were not kept in sync, producing an inconsistency where an admin sees View in the workspace chat preview but Submit in Spend > Reports for the same report.