[$250] Bank account - Can't complete bank account verification

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.77-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176890/test-cases/41237377
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Ventura / Chrome
App Component: Other

Action Performed:

Precondition: workspace with enabled Exopensify feature. Add BA via Expensify card tab.

1. After Bank Account added, go to Expensify card
2. Click on Issue new card
3. On Choose bank account tab, click on bank account

Expected Result:

"Verifying" page with animation displayed.
"Bank account verified" message displayed with animation after a moment

Actual Result:

"Verifying" page with animation displayed.
User returned to Choose bank account tab.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022056714817912528335
• Upwork Job ID: 2056714817912528335
• Last Price Increase: 2026-05-26

[MelvinBot]

Proposal

What is the root cause of that problem?

There is an Onyx key mismatch between where the bank account verification metadata is written and where it is read.

When a user clicks a bank account, configureExpensifyCardsForPolicy writes isLoading/isSuccess to the Onyx key EXPENSIFY_CARD_BANK_ACCOUNT_METADATA_{workspaceAccountID}.

However, WorkspaceExpensifyCardBankAccounts reads from EXPENSIFY_CARD_BANK_ACCOUNT_METADATA_{defaultFundID}, where defaultFundID comes from the useDefaultFundID hook. This hook prefers lastSelectedExpensifyCardFeed or domainFundID over workspaceAccountID.

When defaultFundID !== workspaceAccountID (e.g. when a workspace already has a card feed or domain fund configured), the component never sees the isLoading/isSuccess states. The getVerificationState() function returns an empty string, so BankAccountVerificationView renders its children (the bank account list) instead of the "Verifying" or "Bank account verified" animations.

What changes do you think we should make in order to solve the problem?

In WorkspaceExpensifyCardBankAccounts.tsx, the Onyx read for cardBankAccountMetadata should use workspaceAccountID (from policy?.workspaceAccountID) instead of defaultFundID, to match the key used by the write side in configureExpensifyCardsForPolicy. This aligns the read key with the write key at Card.ts:1350.

What alternative solutions did you explore? (Optional)

An alternative would be to change the write side (configureExpensifyCardsForPolicy) to use defaultFundID instead of workspaceAccountID. However, the write side intentionally uses workspaceAccountID (the value it already receives as a parameter), and the metadata is conceptually about the workspace account being configured — so fixing the read side is the more correct approach.

Investigation details

Write side (Card.ts:1335-1404): configureExpensifyCardsForPolicy always writes to EXPENSIFY_CARD_BANK_ACCOUNT_METADATA_{workspaceAccountID} for optimistic, success, and failure data.

Read side (WorkspaceExpensifyCardBankAccounts.tsx:48): Reads from EXPENSIFY_CARD_BANK_ACCOUNT_METADATA_{defaultFundID}.

useDefaultFundID hook (useDefaultFundID.ts:59-65): Returns lastSelectedExpensifyCardFeed (if exists with a valid paymentBankAccountID) > domainFundID > workspaceAccountID. For workspaces with an existing card feed, defaultFundID will differ from workspaceAccountID.

Flow when keys mismatch:

1. User clicks bank account → handleSelectBankAccount → configureExpensifyCardsForPolicy(policyID, workspaceAccountID, bankAccountID)
2. Optimistic data sets isLoading: true on key ..._{workspaceAccountID}
3. Component reads from ..._{defaultFundID} → gets undefined → getVerificationState() returns ''
4. BankAccountVerificationView with empty verificationState renders children (bank account list)
5. User sees "Choose bank account" instead of "Verifying" animation

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[yusufdeveloper2903]

🚨 Edited by proposal-police: This proposal was edited at 2026-05-19 12:37:30 UTC.

Proposal

What is the root cause of that problem?

The verification screen reads and writes the bank-account metadata under different Onyx keys, so the optimistic / success update never reaches the view.

• The row's onPress calls configureExpensifyCardsForPolicy(policyID, policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID, value), which writes the optimistic and success merges to ${EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${workspaceAccountID} (keyed by the policy's workspaceAccountID) —

  App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

  Lines 76 to 78 in 40223f2

  	const handleSelectBankAccount = (value?: number) => {
  	configureExpensifyCardsForPolicy(policyID, policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID, value);
  	};

  and

  App/src/libs/actions/Card.ts

  Lines 1335 to 1404 in 40223f2

  	function configureExpensifyCardsForPolicy(policyID: string, workspaceAccountID: number, bankAccountID?: number) {
  	if (!bankAccountID) {
  	return;
  	}
  	const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS | typeof ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`,
  	value: {
  	isLoading: true,
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${workspaceAccountID}`,
  	value: {
  	isLoading: true,
  	isSuccess: false,
  	},
  	},
  	];
  	const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS | typeof ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`,
  	value: {
  	isLoading: false,
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${workspaceAccountID}`,
  	value: {
  	isLoading: false,
  	isSuccess: true,
  	},
  	},
  	];
  	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS | typeof ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`,
  	value: {
  	isLoading: false,
  	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${workspaceAccountID}`,
  	value: {
  	isLoading: false,
  	isSuccess: false,
  	},
  	},
  	];
  	const parameters = {
  	policyID,
  	bankAccountID,
  	};
  	API.write(WRITE_COMMANDS.CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY, parameters, {
  	optimisticData,
  	successData,
  	failureData,
  	});

  .
• But the same screen reads that metadata via useOnyx(${EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${defaultFundID}) — keyed by useDefaultFundID(policyID) —

  App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

  Lines 46 to 48 in 40223f2

  	const defaultFundID = useDefaultFundID(policyID);
  	const [cardBankAccountMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${defaultFundID}`);

  .
• useDefaultFundID resolves to lastSelectedExpensifyCardFeed → domainFundID → workspaceAccountID → CONST.DEFAULT_NUMBER_ID —

  App/src/hooks/useDefaultFundID.ts

  Lines 20 to 72 in 40223f2

  	function useDefaultFundID(policyID: string | undefined) {
  	const workspaceAccountID = useWorkspaceAccountID(policyID);
  	const [lastSelectedExpensifyCardFeed] = useOnyx(`${ONYXKEYS.COLLECTION.LAST_SELECTED_EXPENSIFY_CARD_FEED}${policyID}`);
  	const [lastSelectedCardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${lastSelectedExpensifyCardFeed}`);
  	const lastSelectedSettings = getCardSettings(lastSelectedCardSettings);
  	const getDomainFundID = useCallback(
  	(cardSettings: OnyxCollection<ExpensifyCardSettings>) => {
  	const eligibleEntries = Object.entries(cardSettings ?? {}).filter(
  	([key, settings]) => !!settings && !key.includes(workspaceAccountID.toString()) && settings.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
  	);
  	if (policyID) {
  	const preferredMatch = eligibleEntries.find(([, settings]) => getPreferredPolicyFromExpensifyCardSettings(settings)?.toUpperCase() === policyID.toUpperCase());
  	if (preferredMatch) {
  	return getFundIdFromSettingsKey(preferredMatch[0]);
  	}
  	const linkedMatch = eligibleEntries.find(([, settings]) => isPolicyIDInLinkedExpensifyCardPolicyList(getLinkedPolicyIDsFromExpensifyCardSettings(settings), policyID));
  	if (linkedMatch) {
  	return getFundIdFromSettingsKey(linkedMatch[0]);
  	}
  	}
  	return getFundIdFromSettingsKey('');
  	},
  	[policyID, workspaceAccountID],
  	);
  	const [domainFundID] = useOnyx(
  	ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS,
  	{
  	selector: getDomainFundID,
  	},
  	[getDomainFundID],
  	);
  	const isFeedPendingDelete = lastSelectedCardSettings?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
  	if (lastSelectedExpensifyCardFeed && lastSelectedSettings?.paymentBankAccountID && !isFeedPendingDelete) {
  	return lastSelectedExpensifyCardFeed;
  	}
  	if (domainFundID) {
  	return domainFundID;
  	}
  	if (workspaceAccountID) {
  	return workspaceAccountID;
  	}
  	return CONST.DEFAULT_NUMBER_ID;
  	}

  . After the precondition ("Add BA via Expensify card tab") the user already has a selected feed in Onyx, so defaultFundID is the feed's fund ID, not policy.workspaceAccountID.

Concretely: tapping the bank account writes isLoading: true then isSuccess: true to …METADATA<workspaceAccountID>, while the view is subscribed to …METADATA<defaultFundID>. Neither merge is observed, getVerificationState() stays '', and BankAccountVerificationView renders its children (the bank list) instead of the verifying/verified blocking views —

App/src/components/BankAccountVerificationView.tsx

Lines 32 to 102 in 40223f2

	if (!verificationState) {
	return children;
	}
	switch (verificationState) {
	case CONST.EXPENSIFY_CARD.VERIFICATION_STATE.LOADING:
	return (
	<BlockingView
	title={translate('workspace.expensifyCard.verifyingBankAccount')}
	subtitle={translate('workspace.expensifyCard.verifyingBankAccountDescription')}
	animation={LottieAnimations.ReviewingBankInfo}
	animationStyles={styles.loadingVBAAnimation}
	animationWebStyle={styles.loadingVBAAnimationWeb}
	subtitleStyle={styles.textLabelSupporting}
	containerStyle={styles.pb20}
	addBottomSafeAreaPadding
	/>
	);
	case CONST.EXPENSIFY_CARD.VERIFICATION_STATE.ON_WAITLIST:
	return (
	<>
	<BlockingView
	title={translate('workspace.expensifyCard.oneMoreStep')}
	subtitle={translate('workspace.expensifyCard.oneMoreStepDescription')}
	icon={illustrations.Puzzle}
	subtitleStyle={styles.textLabelSupporting}
	iconHeight={variables.cardPreviewHeight}
	iconWidth={variables.cardPreviewHeight}
	/>
	<Button
	success
	large
	text={translate('workspace.expensifyCard.goToConcierge')}
	style={[styles.m5, bottomSafeAreaPaddingStyle]}
	pressOnEnter
	onPress={() => Navigation.navigate(ROUTES.CONCIERGE)}
	/>
	</>
	);
	case CONST.EXPENSIFY_CARD.VERIFICATION_STATE.VERIFIED:
	return (
	<>
	{isReduceMotionEnabled ? (
	<BlockingView
	title={verifiedTitle ?? translate('workspace.expensifyCard.bankAccountVerified')}
	subtitle={verifiedSubtitle ?? translate('workspace.expensifyCard.bankAccountVerifiedDescription')}
	icon={illustrations.Fireworks}
	iconWidth={Number(styles.loadingVBAAnimation.width)}
	iconHeight={Number(styles.loadingVBAAnimation.height)}
	subtitleStyle={styles.textLabelSupporting}
	/>
	) : (
	<BlockingView
	title={verifiedTitle ?? translate('workspace.expensifyCard.bankAccountVerified')}
	subtitle={verifiedSubtitle ?? translate('workspace.expensifyCard.bankAccountVerifiedDescription')}
	animation={LottieAnimations.Fireworks}
	animationStyles={styles.loadingVBAAnimation}
	animationWebStyle={styles.loadingVBAAnimationWeb}
	subtitleStyle={styles.textLabelSupporting}
	/>
	)}
	<Button
	success
	large
	text={verifiedButtonText ?? translate('workspace.expensifyCard.gotIt')}
	style={[styles.m5, bottomSafeAreaPaddingStyle]}
	pressOnEnter
	onPress={onVerifiedButtonPress}
	/>
	</>
	);

. The brief "Verifying" header the QA video shows comes from the parallel …PRIVATE_EXPENSIFY_CARD_SETTINGS<defaultFundID>.isLoading flip that PRs touching the issue-new-card flow already drive elsewhere; the success state for THIS screen never lands.

This is a leftover from #71076 (commit 40ed0a4, merged 2025-09-26 — "Use correct workspace ID for any type of the feeds for Expensify card"). That PR migrated the read in this file from useWorkspaceAccountID → useDefaultFundID because "for domain feeds workspaceAccountId is equal 0", but it did not update the write path — handleSelectBankAccount still passes policy?.workspaceAccountID to the action. The two sides have been out of sync since.

What changes do you think we should make in order to solve the problem?

Pass the same ID the view subscribes to (defaultFundID) into the action, so optimistic / success merges land on the key useOnyx is reading:

     const handleSelectBankAccount = (value?: number) => {
-        configureExpensifyCardsForPolicy(policyID, policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID, value);
+        configureExpensifyCardsForPolicy(policyID, defaultFundID, value);
     };

useDefaultFundID already falls back to CONST.DEFAULT_NUMBER_ID when nothing resolves, so the existing guard semantics are preserved. The action body is unchanged — both writes (PRIVATE_EXPENSIFY_CARD_SETTINGS and EXPENSIFY_CARD_BANK_ACCOUNT_METADATA) now go to the same fund ID as every other read in this screen and the rest of the Expensify-Card pages that #71076 migrated. The bank list closes, the "Verifying" animation transitions to the "Bank account verified" Fireworks blocking view, and the user can continue to "Issue new card".

What alternative solutions did you explore? (Optional)

• Read with workspaceAccountID instead of defaultFundID. Re-introduces Use correct workspace ID for any type of the feeds for Expensify card #71076's original bug for domain feeds (Settlement button missing, settings/cards-list mis-keyed when policy.workspaceAccountID === 0).
• Resolve defaultFundID inside configureExpensifyCardsForPolicy. Couples a pure write action to feed-selection state (lastSelectedExpensifyCardFeed, PRIVATE_EXPENSIFY_CARD_SETTINGS traversal) it shouldn't read; the call site already has the resolved value.
• Write to both keys. Doubles the optimistic-state surface area and leaves stale isLoading: true on whichever key isn't the live one — masks future drifts like this.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022056714817912528335

[melvin-bot]

📣 @Marshall7777! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[github-actions]

⚠️ @yusufdeveloper2903 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Web (Chrome/Safari), after adding a bank account through the Expensify Card tab and selecting it on the "Choose bank account" screen, the user briefly sees the "Verifying" animation but is then returned to the "Choose bank account" list instead of seeing the "Bank account verified" success screen. The expected behavior is that, once the backend confirms verification, the success screen with the "Bank account verified" message and animation should be displayed.

What is the root cause of that problem?

In src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx:48, cardBankAccountMetadata is read from ${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${defaultFundID}, but configureExpensifyCardsForPolicy writes that metadata under ${...}${workspaceAccountID} (src/libs/actions/Card.ts:1350). When a policy already has a previously selected card feed, useDefaultFundID (src/hooks/useDefaultFundID.ts:59-65) returns lastSelectedExpensifyCardFeed / domainFundID instead of workspaceAccountID, so the page subscribes to a different Onyx key than the one the action mutates. cardBankAccountMetadata?.isLoading and ?.isSuccess therefore stay falsy, getVerificationState() (line 51) returns '', and BankAccountVerificationView falls through to render children (the bank-choice list) instead of the Loading/Verified screens.

What changes do you think we should make in order to solve the problem?

1. In src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx:48, subscribe to ${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_BANK_ACCOUNT_METADATA}${policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID} so the reader matches the writer in configureExpensifyCardsForPolicy.
2. Keep useDefaultFundID for resolving an existing card feed for other reads on this page, but do not use it to key the verification metadata, since that metadata is always written under workspaceAccountID at src/libs/actions/Card.ts:1350 (and 1387 for failure).
3. Confirm handleSelectBankAccount (WorkspaceExpensifyCardBankAccounts.tsx:76-78) keeps passing policy?.workspaceAccountID to configureExpensifyCardsForPolicy so reader and writer share the same key.
4. Verify the same key is used at other consumers of EXPENSIFY_CARD_BANK_ACCOUNT_METADATA (e.g., DynamicReconciliationAccountSettingsPage.tsx) and align them on workspaceAccountID if they share the verification flow.
5. Add a regression test/manual check: select a bank account on a policy that already has a lastSelectedExpensifyCardFeed set to a feed whose fund ID ≠ workspaceAccountID, and confirm "Verifying" → "Bank account verified" screen appears.

What alternative solutions did you explore? (Optional)

Alternatively, change configureExpensifyCardsForPolicy to also write the metadata under the resolved fundID, but that requires the action to know about the same fund-resolution logic and would still break for any other reader keyed on workspaceAccountID; aligning the reader is the smaller, safer change.

[kamronbek04]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.