Custom modal not displayed before requesting location permission

[Julesssss]

Problem

Google Play rejected our latest release for missing Prominent Disclosure on BACKGROUND_LOCATION. Our custom disclosure modal used to render before the OS permission prompt, but it now no longer fires in the canAskAgain === false branch of the GPS distance flow.

In BackgroundLocationPermissionsFlow/index.android.tsx and index.ios.tsx, once foreground or background location has been denied with "don't ask again", checkPermissions() calls onDeny() immediately without rendering any modal. Returning users — and Google reviewers retrying — therefore see nothing before being routed away.

Parent issue: https://github.com/Expensify/Expensify/issues/639340

Solution

Render the disclosure modal before onDeny() in the bypass branches on both Android and iOS, so the user always sees a custom disclosure (with appropriate "open device settings" CTA when canAskAgain is false) before the flow proceeds.

[godzillaxbox19982014-lgtm]

Hi jules, I looked at this too. The issue seems to be the early onDeny() in checkPermissions() on both Android and iOS before the disclosure modal gets a chance to render. I’d route those canAskAgain === false branches through the existing custom modal/settings CTA first, then call onDeny() after the modal action/dismiss. i imagine you already have this covered but figured i'd chip in.