Expense - Submit button is shown instead of Mark as done in More menu

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88455
Email or phone of affected tester (no customers): jsoidjnoisndionjionjsi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with new Gmail account.
3. Skip work email step.
4. Select Track expenses for my business.
5. Complete the onboarding.
6. Go to workspace chat.
7. Create an expense.
8. Open the expense.
   → Mark as done button is shown.
9. Click More > Hold.
10. Enter reason and save it.
11. Click More menu.

Expected Result:

Mark as done button will be shown in More menu.

Actual Result:

Submit button is shown instead of Mark as done in More menu.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7163799_1779827964707.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7163799

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/28621b3e39f5b5e9766a1993c7c9efb824c7244d35fbfd9285db1a75b5fd993e

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #88455

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Valforte]

@jayeshmangwani can you please check if it's a quick fix?

[MelvinBot]

Proposal

What is the root cause of that problem?

When an expense is put on hold, the primary action changes from SUBMIT to REMOVE_HOLD (in ReportPrimaryActionUtils.ts:498). This causes the submit action to move from the primary button to the secondary/More menu.

The primary button correctly calls shouldShowMarkAsDone() to conditionally display "Mark as done" — see SubmitPrimaryAction.tsx:75-79. However, the secondary/More menu entry in useLifecycleActions.tsx:231 hardcodes the text as translate('common.submit') and never checks shouldShowMarkAsDone, so it always shows "Submit" instead of "Mark as done".

What changes do you think we should make in order to solve the problem?

In useLifecycleActions.tsx, the SUBMIT secondary action entry should conditionally set its text using shouldShowMarkAsDone(), matching the pattern already used by SubmitPrimaryAction.tsx and MoneyReportHeaderSelectionDropdown.tsx. The text at line 231 should be changed from the hardcoded translate('common.submit') to a conditional expression that returns translate('common.markAsDone') when shouldShowMarkAsDone returns true.

What alternative solutions did you explore? (Optional)

N/A — this is a straightforward missing check. The same shouldShowMarkAsDone utility is already used in all other submit button locations (SubmitPrimaryAction.tsx:75, MoneyReportHeaderSelectionDropdown.tsx:384); the secondary menu entry was simply missed.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[Valforte]

@MelvinBot implement this