Report -Dividers in "More" menu change when moving track expense to report and when reopened

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90097
Email or phone of affected tester (no customers): ibellicotest+2723@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace.
Prerequisite 2: Account has Self DM.

1. Open the Expensify app.
2. Navigate to Self DM.
3. Create a manual expense.
4. Open the just created expense.
5. Tap on report field > "Create Report"
6. Once landing on report again, tap on "More" menu.
7. Note that "Hold", "Split" and "Merge" are on the same divider and "Duplicate expense" and "Move to report" on another one.
8. Navigate to workspace where expense was moved and reopen it.
9. Tap on "More" again.
10. Note that "Hold" is now in one divider with "Add Expense", and "Split" and "Merge" are displayed on another divider together with "Duplicate Expense" and "Move to report"

Expected Result:

Dividers on "More" menu should be consistent when opening an expense when just moved from Self DM, and when reopening it on workspace chat.

Actual Result:

Options on dividers in "More" menu, change when opening menu after moving track expense to workspace and when reopening it on workspace chat.
"Hold", "Split", "Merge", "Duplicate Expense" and "Move to Report" options are displayed on different dividers.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7164588_1779909587248.Divider.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #90097

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #90097 - "Add dividers to More menu actions" by @aswin-s (High confidence)
Related Issues: None

Recommendation: REVERT

The section groupings introduced in PR #90097 define "Hold" in different sections depending on context—it is placed in the primary actions section (section 0, alongside "Add Expense") in REPORT_MORE_MENU_SECTIONS, but in its own section (section 0, alongside "Split" and "Merge") in TRANSACTION_MORE_MENU_SECTIONS. This causes the inconsistent divider placement reported: after moving an expense to a workspace report, the user sees a different sectioning layout when reopening the expense from the workspace chat, because the component switches between the transaction-level and report-level menu implementations with different section definitions.

Assigned: @aswin-s (PR author), @Julesssss, @flaviadefaria, @rojiphil (approving reviewers)
Labels: DeployBlockerCash kept (frontend App PR is the cause). No label changes made.

Detailed Analysis

Evidence

• The issue is reproducible on staging only (new feature, not in production), matching that this was introduced by a staging PR.
• The melvin-bot automatically identified PR Add dividers to More menu actions #90097 as the causing PR and linked it in a comment.
• PR Add dividers to More menu actions #90097 merged on 2026-05-27 and is listed in the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-05-27 #91866).
• The PR introduces src/libs/PopoverMenuSections.ts with two section definition arrays: TRANSACTION_MORE_MENU_SECTIONS (used by MoneyRequestHeaderSecondaryActions.tsx) and REPORT_MORE_MENU_SECTIONS (used by MoneyReportHeaderSecondaryActions.tsx).

Verification

• The affected files are src/libs/PopoverMenuSections.ts, src/components/MoneyRequestHeaderSecondaryActions.tsx, and src/components/MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions.tsx.
• PR Add dividers to More menu actions #90097 directly creates and modifies all of these files.
• The PR modifies the sortAndSectionPopoverMenuItems function which controls the divider placement logic.

Root Cause

In TRANSACTION_MORE_MENU_SECTIONS, the "Hold"/"Remove Hold", "Split", and "Merge" actions are grouped together in section 0. In REPORT_MORE_MENU_SECTIONS, "Hold"/"Remove Hold" is in section 0 (primary actions, with "Add Expense"), while "Split" and "Merge" are in section 1 (expense actions). When a user creates an expense in Self DM and views it, the transaction-level "More" menu (MoneyRequestHeaderSecondaryActions) is rendered, showing one grouping. When the expense is moved to a workspace and the user reopens it from the workspace chat, the report-level "More" menu (MoneyReportHeaderSecondaryActions) is rendered with a different section definition, producing a different grouping. This inconsistency in section definitions between the two contexts causes the reported divider mismatch.