Android - Workspaces - "Domains" page is not scrollable in landscape mode.

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.91-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: http://github.com/Expensify/App/pull/91305
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Workspace Settings

Action Performed:

Prerequisite: Account has no Domains yet.

1. Open the Expensify app.
2. Navigate to "Workspaces" > "Domains"
3. Switch to landscape mode.
4. Note that page is not scrollable and user can´t reach "New Domain" button.

Expected Result:

"Domains" page should be scrollable and user should be able to reach "New Domain" button.

Actual Result:

"Domains" page is not scrollable on landscape mode and user can´t reach the "New Domain" button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7169411_1780391823755.Domains.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7169411

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c0a20a1710ff0df1c40e62957a09fd55382bd70eba421dc4142d83276f5018d2

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #91305

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

🤖 Automated analysis by MelvinBot — high confidence.

TL;DR: The empty Domains page can't scroll in landscape because the shared Table component applies flex: 1 to the FlashList content container when the list is empty, which collapses the content to the viewport height. The fix is to use flexGrow: 1 instead.

What is the root cause of that problem?

The Domains page renders its empty state (illustration + title + subtitle + "New domain" button) as the FlashList ListEmptyComponent inside the shared Table component.

When the list is empty, TableBody.tsx:98 sets the FlashList contentContainerStyle to styles.flex1:

contentContainerStyle={[filteredAndSortedData.length === 0 && styles.flex1, ...]}

styles.flex1 is {flex: 1}, which in React Native expands to flexGrow: 1, flexShrink: 1, flexBasis: 0%. On a scroll container's content, the flexShrink: 1 + flexBasis: 0% force the content to shrink to the viewport height and never grow beyond it — so it can never scroll. In portrait there's enough vertical room for the whole empty state, so the missing scroll goes unnoticed. In landscape (much less height) the content overflows but is clipped, leaving the "New domain" button unreachable.

This is the standard React Native gotcha: flex: 1 on contentContainerStyle breaks scrolling for overflowing content, whereas flexGrow: 1 centers short content and allows tall content to scroll. The empty-state component itself already uses the correct pattern (flexGrow1 + flexShrink0 at EmptyStateComponent/index.tsx:44) — but its parent FlashList content container overrides that intent with flex: 1.

Evidence chain

• DomainsListPage.tsx:104 renders <DomainListTable domains={domainRows} />.
• Tables/DomainListTable/index.tsx:73 passes ListEmptyComponent={DomainListEmptyState} to Table.
• TableBody.tsx:91-101 renders the FlashList; line 98 applies styles.flex1 to contentContainerStyle only when filteredAndSortedData.length === 0 — which is exactly the empty-Domains case from the repro ("Account has no Domains yet").
• The flex1 is applied only when the list is empty, which is why a populated Domains list scrolls fine and only the empty state is broken.

Why landscape only: the gate is viewport height, not orientation. Portrait has enough height to fit the entire empty state, so clipping isn't visible; landscape doesn't, so the bottom (the button) is cut off with no way to scroll to it.

What changes do you think we should make in order to solve the problem?

In TableBody.tsx:98, change the empty-state content container style from styles.flex1 to styles.flexGrow1. This keeps the empty state centered when it fits and lets it grow past the viewport (enabling scroll) when it doesn't.

Since Table is a shared component, the empty states of other tables using it should be sanity-checked in landscape as part of QA.

What alternative solutions did you explore? (Optional)

Wrapping DomainListEmptyState in a dedicated ScrollView would also work, but it's a narrower fix that leaves the same bug latent for every other table's empty state and duplicates scroll behavior FlashList already provides. Fixing the shared content-container style is cleaner and DRY.

Note on assignment: This issue was auto-assigned via the regression-testing link to #91305, but that PR (read-only workspace access) does not touch Table, TableBody, or any Domains page — so it is not the cause. The bug lives in the shared Table empty-state rendering. No revert of #91305 is needed.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92353) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.