Fix foreground notification display bug#1034
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
# Conflicts: # src/pages/SetPasswordPage.js # src/pages/SignInPage.js
roryabraham
changed the title
Contributor
|
I'll give this a look once it's no longer a draft. Would you mind changing the title to indicate it's a WIP, or use GH's draft function to mark this as such? |
Contributor
Author
|
Hey Luke, np - I'll mark this as WIP while I work on fixing the E2E tests. |
roryabraham
changed the title
roryabraham
changed the title
Contributor
Author
|
@Luke9389 this is no longer WIP |
Contributor
|
Ok cool! Are there tests I can perform for this? |
Contributor
Author
|
My bad @Luke9389 🤦 There are testing steps now 👍 |
Contributor
|
No problemo my dude! 😄 One actual problemo is that I don't have an iPhone... 😬 |
Contributor
|
I don't have an iPhone either so can't test this. |
Luke9389
approved these changes
Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @marcaaron @AndrewGable
Details
Turns out that we had included
@react-native-community/push-notification-iosas a dependency in order to display the unread indicator badge on iOS. This conflicted with our UA integration, which merges foreground presentation settings from the AppDelegate. Does that even make sense? It's pretty close to being true. Details here.Fixed Issues
https://github.com/Expensify/Expensify/issues/144297
Tests