[No QA] Add log line if hack is being hit

[roryabraham]

Details

Just adding a log line so that we can come back in a week or so and evaluate if it's safe to remove this hack.

Fixed Issues

$ (partial) #14574

Tests

None.

• Verify that no errors appear in the JS console

Offline tests

None

QA Steps

None.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

None, just adding a log line.

[MelvinBot]

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chiragsalian]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	721.998 ms → 759.773 ms (+37.775 ms, +5.2%)
App start runJsBundle	195.250 ms → 208.344 ms (+13.094 ms, +6.7%)
Open Search Page TTI	619.790 ms → 623.588 ms (+3.798 ms, +0.6%)
App start nativeLaunch	19.548 ms → 20.000 ms (+0.452 ms, +2.3%)
App start regularAppStart	0.017 ms → 0.016 ms (-0.001 ms, -7.5%)

Show details

Name	Duration
App start TTI	Baseline Mean: 721.998 ms Stdev: 34.906 ms (4.8%) Runs: 659.1578489998356 666.7977229999378 669.10807499988 681.2271360000595 681.3267330001108 687.165748000145 691.9557159999385 693.2437740000896 696.4453329998069 698.7872939999215 704.4320120001212 712.1134970001876 713.8197010001168 714.7602670001797 714.8621249999851 714.9456420000643 718.9915040000342 720.618207000196 729.671045999974 732.4549309997819 733.5050050001591 734.6772110001184 734.904234000016 750.9318140000105 751.9957969998941 752.8144600000232 755.3353639999405 759.6213070000522 772.8234120002016 773.6521299998276 774.7371780001558 807.0584800001234 Current Mean: 759.773 ms Stdev: 38.150 ms (5.0%) Runs: 688.5748939998448 699.5116260000505 702.5374480001628 703.4585440000519 714.4425169997849 715.4342220001854 720.685765999835 725.7237680000253 739.3991740001366 740.3326739999466 743.6506159999408 745.0481420001015 745.7444600001909 748.5116119999439 753.2299199998379 754.2421030001715 761.0219580000266 769.8141419999301 770.9568179999478 777.18335200008 778.3581650000997 780.9981149998493 784.1312210001051 786.8670749999583 788.7920340001583 789.1879679998383 794.0696000000462 803.4132070001215 814.1570009998977 817.9581059999764 822.5408350001089 832.7607120000757
App start runJsBundle	Baseline Mean: 195.250 ms Stdev: 20.842 ms (10.7%) Runs: 164 164 165 171 173 173 175 179 184 184 185 186 186 189 189 190 191 192 196 196 203 203 203 204 214 217 220 222 223 231 237 239 Current Mean: 208.344 ms Stdev: 22.585 ms (10.8%) Runs: 168 174 180 181 184 186 188 189 190 191 196 197 198 199 203 204 205 205 211 215 219 220 223 230 231 233 233 235 236 241 249 253
Open Search Page TTI	Baseline Mean: 619.790 ms Stdev: 18.213 ms (2.9%) Runs: 593.1989750000648 596.6580400001258 597.4753419999033 599.2104079998098 599.6542159998789 600.0617269999348 603.3307300000452 603.8454590002075 604.550414999947 605.4961749999784 607.0819899998605 608.6444100001827 612.6876229997724 613.9980480000377 614.5608729999512 614.812663000077 619.0087490002625 620.1857909997925 621.1036790004 621.5180260003544 622.0310069997795 626.8240149999037 629.614949000068 631.062215000391 632.978108999785 634.1040849997662 642.3091639997438 647.2473550001159 647.3461510003544 649.7363690002821 655.3072509998456 657.6256510000676 Current Mean: 623.588 ms Stdev: 18.242 ms (2.9%) Runs: 596.3272710000165 599.2136639999226 600.1343179997057 600.4243979998864 604.6927089998499 605.8815919999033 607.1269529997371 608.1127110002562 610.7325849998742 612.3865160001442 614.6861169999465 614.7841799999587 615.5850419998169 615.7591969999485 617.3687340002507 618.5870769997127 618.922730000224 619.7154550002888 622.9464520001784 624.8074539997615 626.3559159999713 628.521525000222 628.9922690000385 629.1809900002554 631.8945720000193 635.4840899999253 642.7088629999198 646.1445730002597 647.1348069999367 650.3605140000582 657.5489909998141 661.7240810003132 664.1444100001827
App start nativeLaunch	Baseline Mean: 19.548 ms Stdev: 1.562 ms (8.0%) Runs: 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 20 20 20 21 21 21 21 21 22 22 23 23 Current Mean: 20.000 ms Stdev: 1.576 ms (7.9%) Runs: 17 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 21 21 21 21 21 21 21 22 24 24
App start regularAppStart	Baseline Mean: 0.017 ms Stdev: 0.002 ms (8.8%) Runs: 0.015137000009417534 0.015544000081717968 0.015584999695420265 0.015666000079363585 0.015705999918282032 0.01582799991592765 0.015828999690711498 0.015950000379234552 0.016032000072300434 0.016559999901801348 0.016642000060528517 0.016642999835312366 0.016682999674230814 0.016682999674230814 0.01680499967187643 0.016845999751240015 0.016887000296264887 0.017171000130474567 0.017293999902904034 0.01733399974182248 0.01733400020748377 0.018106999807059765 0.018106999807059765 0.01822899980470538 0.018920999951660633 0.01904299994930625 0.019084000028669834 0.019896999932825565 0.020710999611765146 0.020913999993354082 Current Mean: 0.016 ms Stdev: 0.001 ms (5.9%) Runs: 0.014159999787807465 0.0142000000923872 0.01464799977838993 0.0147299999371171 0.0148930000141263 0.015015000011771917 0.015137000009417534 0.01525900000706315 0.015544000081717968 0.015584000386297703 0.015625 0.015625 0.01582799991592765 0.015868999995291233 0.015909000299870968 0.0159919997677207 0.01607200037688017 0.016112999990582466 0.016194000374525785 0.01623600022867322 0.016316000372171402 0.016439000144600868 0.016600999981164932 0.016682999674230814 0.01688600005581975 0.016927000135183334 0.017130000051110983 0.01717099966481328 0.017374000046402216 0.018188999965786934

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.70-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅