Fix isIOUOwnedByCurrentUser #15339

luacmartins · 2023-02-22T02:42:55Z

Details

This logic always returned false as currentUserLogin is an object containing user login information and not the user email.

Additionally, this line always returned true for !report.isIOUReportOwner since isIOUReportOwner is not a property of the report object.

cc @Julesssss @tgolen

Fixed Issues

$ #15390

Tests

Log into an account that has IOUs in which you owe and are owed
Verify that the chats with IOUs where you owe are sorted at the top of the LHN
Verify that the chats with IOUs where you are owed follow the most recent message sorting order

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

luacmartins · 2023-02-22T03:02:40Z

src/libs/ReportUtils.js

 * @returns {Boolean}
 */
-function isIOUOwnedByCurrentUser(report, currentUserLogin, iouReports = {}) {
+function isIOUOwnedByCurrentUser(report, iouReports = {}) {


currentUserLogin is already declared in the upper scope -

App/src/libs/ReportUtils.js

Line 42 in 70f5212

let currentUserEmail;

luacmartins · 2023-02-22T03:03:18Z

src/libs/SidebarUtils.js

        }

-        if (report.hasOutstandingIOU && !report.isIOUReportOwner) {
+        if (report.hasOutstandingIOU && !ReportUtils.isIOUOwnedByCurrentUser(report, iouReports)) {


isIOUReportOwner is not a property of the report object

Julesssss · 2023-02-22T10:38:05Z

Nice find, looking good so far. Ping me when it's ready for review!

Julesssss · 2023-02-22T10:38:30Z

Oh, i thought I was assigned -- I didn't realise it was just a CC :)

tgolen · 2023-02-22T18:28:50Z

Nice that you found those. Refactoring all that logic was a bear. Sorry for messing it up in these spots!

MelvinBot · 2023-02-22T22:51:51Z

@s77rt @Gonals One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-02-22T22:53:13Z

@s77rt we'll review this one internally since it's part of a fix for a design doc

Julesssss

Tests as expected, though I'm starting to question the logic behind the ordering.

Verify that the chats with IOUs where you owe are sorted at the top of the LHN

Has it been discussed that reports where you are owed, should NOT be prioritized in the LHN ordering? AFAIK we wanted both red and green badges to be prioritized, to avoid losing track of money that is owed, but maybe I missed the discussion that changed this.

luacmartins · 2023-02-23T19:21:19Z

That's a good point and I questioned that as well. I think that since we are deprecating the IOU badge and moving to highlighting "to dos", this would be expected. I asked in our Manual Requests chat to clarify though.

Julesssss · 2023-02-24T10:24:42Z

That's a good point and I questioned that as well. I think that since we are deprecating the IOU badge and moving to highlighting "to dos", this would be expected. I asked in our Manual Requests chat to clarify though.

We still show the green badge, so I'd expect that to be pinned. We should probably take this to a more public channel

luacmartins · 2023-02-24T13:37:12Z

Yea, for now we show the green badge and I'd also expect those to be pinned. After Manual Requests though, we're only pinning chats for admins and payers (P2P), so this would be the expected behavior. I'm fine waiting to merge this until we start with the implementation for Manual Requests.

Gonals · 2023-03-08T10:29:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-03-08T11:06:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-09T04:20:11Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.2.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-10T14:06:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.81-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix IsIOUOwnedByCurrentUser

a2fde3b

luacmartins self-assigned this Feb 22, 2023

luacmartins added 2 commits February 21, 2023 19:48

fix getOrderedReportIDs logic for outstanding IOUs

e39513e

clean up logic

70f5212

luacmartins commented Feb 22, 2023

View reviewed changes

luacmartins marked this pull request as ready for review February 22, 2023 22:51

luacmartins requested a review from a team as a code owner February 22, 2023 22:51

luacmartins requested a review from Julesssss February 22, 2023 22:51

melvin-bot bot requested review from Gonals and s77rt and removed request for a team February 22, 2023 22:51

luacmartins removed the request for review from s77rt February 22, 2023 22:53

Julesssss reviewed Feb 23, 2023

View reviewed changes

Julesssss approved these changes Mar 7, 2023

View reviewed changes

Gonals approved these changes Mar 8, 2023

View reviewed changes

Gonals merged commit 730054f into main Mar 8, 2023

Gonals deleted the cmartins-fixIsIOUOwnedByCurrentUser branch March 8, 2023 11:03

OSBotify mentioned this pull request Mar 9, 2023

Deploy Checklist: New Expensify 2023-03-09 #15767

Closed

19 tasks

MelvinBot mentioned this pull request Mar 10, 2023

[HOLD for payment 2023-03-17] Fix broken logic in isIOUOwnedByCurrentUser #15390

Closed

Fix isIOUOwnedByCurrentUser #15339

Fix isIOUOwnedByCurrentUser #15339

Uh oh!

Conversation

luacmartins commented Feb 22, 2023 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Feb 22, 2023

Uh oh!

Julesssss commented Feb 22, 2023

Uh oh!

tgolen commented Feb 22, 2023

Uh oh!

MelvinBot commented Feb 22, 2023

Uh oh!

luacmartins commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Feb 23, 2023

Uh oh!

Julesssss commented Feb 24, 2023

Uh oh!

luacmartins commented Feb 24, 2023

Uh oh!

Gonals commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Mar 8, 2023

Uh oh!

OSBotify commented Mar 9, 2023

Uh oh!

OSBotify commented Mar 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luacmartins commented Feb 22, 2023 •

edited by Julesssss

Loading

luacmartins commented Feb 22, 2023 •

edited

Loading

Gonals commented Mar 8, 2023 •

edited

Loading