Migrate Composer. web by perunt · Pull Request #23359 · Expensify/App

perunt · 2023-07-21T16:18:19Z

Details

Fixed Issues

$ #16129
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

This PR updated the composer related to text input only on WEB

Test Case 1: Input Functionality

Input random characters in the text box and verify that the entered characters are correctly displayed.
Try to input various types of text, such as emojis, special characters, numbers, and a mixture of these.
Check for proper functionality in both normal and capitalized modes.

Test Case 2: Multiline Input Functionality

Try to input a multiline text in the text box.
Verify that the text formatting (like new lines, spaces, etc.) is correctly retained and displayed.
Check the scrolling functionality for multiline inputs.

Test Case 3: Focus Functionality

Switch between the text box and the emoji picker multiple times, and verify that the focus is correctly switched each time.
Verify that the text box regains focus when coming back from the emoji picker.

Test Case 4: Style Functionality

Try to input a text that should trigger style changes (like shrinking or expanding).
Verify that the style changes are correctly displayed.
Check if these changes are retained when switching between different interfaces (like going to the emoji picker and coming back).

Test Case 5: Message Sending Functionality

After inputting a message, hit the send button and verify that the message is sent.
Verify that the text box is cleared after the message is sent.
Check if the sent message is correctly displayed in the chat history.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-27.at.14.18.50.mov

Mobile Web - Chrome

telegram-cloud-document-2-5336800175870455938.mp4

Mobile Web - Safari

Screen.Recording.2023-07-27.at.14.46.54.mov

Desktop

Screen.Recording.2023-07-27.at.15.07.41.mov

iOS

Android

…composer-fc-web

…into migrate-composer-fc-web

…composer-fc-web

melvin-bot · 2023-07-27T13:17:07Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2023-07-28T11:25:37Z

@perunt, please fix the lint issues. You can use the lint command from package.json scripts

perunt · 2023-07-28T12:01:49Z

it's quite weird that optional chaining is prohibited, as I saw it in the code
fixed, thanks @ArekChr !

ArekChr · 2023-07-28T11:43:55Z

-                    caretContent: this.getNextChars(this.props.value, event.nativeEvent.selection.start),
-                },
+    const addCursorPositionToSelectionChange = (event) => {
+        flushSync(() => {


Could you explain the usage of flushSync here?

I need to return up-to-date data for positioning an inline autosuggestion within the callback. If we remove flushSync, we will receive an outdated value, which will lag(be delayed) by one value

I see, thanks for the explanation!

ArekChr · 2023-07-28T12:06:56Z

+                ref={setTextInputRef}
+                selection={selection}
+                style={[
+                    StyleSheet.flatten([style, {outline: 'none'}]),


In some places, implementation is slightly different. Could you explain why these changes? There is no outline: 'none', old code.

We use the outline in the old code here
do you mean using useMemo for this?

Thanks, it's ok, I couldn't find this style because git diff changes are going crazy, harder to compare

Yeah, sometimes it just gets too messy 😄

ArekChr

Overall LGTM, please fix lint errors.

perunt · 2023-08-04T09:09:58Z

@ArekChr should be good to go

ArekChr · 2023-08-04T11:17:08Z

Hey @perunt, it looks like the test steps are missing. Could you update the location where I can check the logs, especially if no errors occur? Thank you!

ArekChr

I compared both files separately because the git diff was difficult to follow. It appears that the implementations have slightly changed, e.g. updateNumberOfLines has been removed. Please retain the original logic and only rewrite the class lifecycle methods with hooks, so the outcome will more accurately reflect the original implementation.

…composer-fc-web

perunt · 2023-08-14T12:49:16Z

@ArekChr, any issue here so far?

allroundexperts · 2023-08-15T12:05:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-15.at.4.24.42.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-15.at.4.41.19.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-15.at.4.39.48.PM.mov

Desktop

Screen.Recording.2023-08-15.at.5.02.07.PM.mov

iOS

Screen.Recording.2023-08-15.at.4.58.01.PM.mov

Android

Screen.Recording.2023-08-15.at.4.51.17.PM.mov

allroundexperts

Tests well!

Screen recordings are missing for iOS and android but I'm approving it since this is urgent.

perunt · 2023-08-15T13:40:48Z

It's a WEB-only change, next time will add it.

mountiny

Thanks for the quick testing @allroundexperts

@perunt Keep an eye on #expensify-bugs in case there is anything new from this refactoring as its quite complex

mountiny · 2023-08-15T13:35:37Z

-    checkComposerVisibility: () => false,
-};
+// Get characters from the cursor to the next space or new line
+const getNextChars = (str, cursorPos) => {


I think that would be handy but we can make it in a follow up PR

OSBotify · 2023-08-15T13:46:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:21:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bondydaa · 2023-08-17T15:56:41Z

looks like this caused this regression #25409 where if you copy some text, open any RHP then paste it will paste your clipboard contents twice.

ShogunFire · 2023-08-17T16:38:12Z

And maybe this one: #25413

OSBotify · 2023-08-21T22:28:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:11:20Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2023-09-25T10:13:07Z

Coming from #25413:
This could have been caught and fixed earlier if edit message was thoroughly tested on all platforms, especially initial cursor position.

aimane-chnaif · 2023-11-22T11:51:37Z

This caused Web - App adds extra line in edit message box
More details about the root cause: #27622 (comment)

hoangzinh · 2024-07-26T12:34:37Z

+        setSelection((prevSelection) => {
+            if (!!prevSelection && selectionProp.start === prevSelection.start && selectionProp.end === prevSelection.end) {
+                return;
+            }
+            return selectionProp;
+        });


Coming from #44259, instead of using a set state function updater, we can use setState function directly

perunt added 9 commits July 12, 2023 16:36

Merge branch 'main' of https://github.com/Expensify/App into migrate-…

a95d0fd

…composer-fc-web

WIP migrate to fc

2f9b89d

WIP migration composer with numberOfLines

22be821

fix positionX and positionX

4f415ed

Merge branch 'main' of https://github.com/Expensify/App into migrate-…

7d3fd0c

…composer-fc-web

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

cc051cd

…into migrate-composer-fc-web

updateIsFullComposerAvailable

0b38fd9

Merge branch 'main' of https://github.com/Expensify/App into migrate-…

073a7a4

…composer-fc-web

fix jumping

09b5740

perunt marked this pull request as ready for review July 27, 2023 13:17

perunt requested a review from a team as a code owner July 27, 2023 13:17

melvin-bot Bot requested review from ArekChr and removed request for a team July 27, 2023 13:17

remove optional chaining

fcba1d3

ArekChr reviewed Jul 28, 2023

View reviewed changes

perunt added 2 commits July 28, 2023 15:19

memo input style

0956e6d

use destructing

db03912

ArekChr reviewed Jul 31, 2023

View reviewed changes

Comment thread src/components/Composer/index.js Outdated

Comment thread src/components/Composer/index.js Outdated

ArekChr suggested changes Jul 31, 2023

View reviewed changes

perunt added 2 commits August 4, 2023 10:56

fix lint

5a90581

again lint

561687c

ArekChr suggested changes Aug 4, 2023

View reviewed changes

Comment thread src/components/Composer/index.js Outdated

Comment thread src/components/Composer/index.js

Comment thread src/components/Composer/index.js Outdated

AndrewGable requested a review from a team August 4, 2023 15:06

melvin-bot Bot requested review from mananjadhav and removed request for a team August 4, 2023 15:06

Merge branch 'main' of https://github.com/Expensify/App into migrate-…

6149e98

…composer-fc-web

hannojg mentioned this pull request Aug 14, 2023

[WIP] Performance: chat input margelo/Expensify#12

Merged

57 tasks

mountiny assigned perunt Aug 15, 2023

mountiny requested a review from allroundexperts August 15, 2023 10:55

allroundexperts approved these changes Aug 15, 2023

View reviewed changes

Expensify deleted a comment from ArekChr Aug 15, 2023

mountiny approved these changes Aug 15, 2023

View reviewed changes

mountiny merged commit 61ab4bc into Expensify:main Aug 15, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

daordonez11 mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-08-28] [$1000] Chat - Email is pasted twice in the composer when copied from user profile #25409

Closed

6 tasks

daordonez11 mentioned this pull request Aug 17, 2023

Fix for double paste in composer after function component mig #25419

Merged

57 tasks

melvin-bot Bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$250] Migrate index.js to function component #16129

Closed

1 task

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

bernhardoj mentioned this pull request Sep 18, 2023

[HOLD for payment 2023-11-22] [$500] Web - App adds extra line in edit message box #27622

Closed

6 tasks

situchan mentioned this pull request Sep 25, 2023

[$1000] Chat - Cursor does not remain the same place when Edit message #25413

Closed

6 tasks

kavimuru mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-11-13] [$500] Composer height is not resized when resizing browser #28660

Closed

6 tasks

nebiyuelias1 mentioned this pull request Oct 4, 2023

[$500] Chat - Text partially cut for last text on paste of long text #28847

Closed

6 tasks

hoangzinh reviewed Jul 26, 2024

View reviewed changes

hoangzinh mentioned this pull request Jul 26, 2024

[Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh #44259

Closed

6 tasks

Conversation

perunt commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 27, 2023

Uh oh!

ArekChr commented Jul 28, 2023

Uh oh!

perunt commented Jul 28, 2023

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ArekChr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

perunt commented Aug 4, 2023

Uh oh!

ArekChr commented Aug 4, 2023

Uh oh!

ArekChr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perunt commented Aug 14, 2023

Uh oh!

allroundexperts commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

perunt commented Aug 15, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

bondydaa commented Aug 17, 2023

Uh oh!

ShogunFire commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

situchan commented Sep 25, 2023

perunt commented Jul 21, 2023 •

edited

Loading

ArekChr left a comment •

edited

Loading

ArekChr left a comment •

edited

Loading

allroundexperts commented Aug 15, 2023 •

edited

Loading