The edited message does not dynamically update between the main chat and sub-thread by dukenv0307 · Pull Request #23706 · Expensify/App

dukenv0307 · 2023-07-27T02:53:13Z

Details

When in editing mode, the edited message does not dynamically update between the main chat and sub-thread

Fixed Issues

$ #22368
PROPOSAL: #22368 (comment)

Tests

Login to an account
Send a message - X
Hover on the message X at step 2 and select the “Reply in thread” option
Inside the thread, hover on X and select the “Edit” option but leave it here, DO NOT save
Click the link on the chat report header to go back to “Main chat”
Hover on X again, select the Edit option, change the message to Y and Save
Hover on the edited message (now it became Y) and select “Reply in thread” again
Verify that The pending edit text should be updated to Y (since the message ID is still the same)
Select Edit message X but not save
Go to the thread of that message then change the message to Z and Save
Verify that The pending edit text should be updated to Z (since the message ID is still the same)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to an account
Send a message - X
Hover on the message X at step 2 and select the “Reply in thread” option
Inside the thread, hover on X and select the “Edit” option but leave it here, DO NOT save
Click the link on the chat report header to go back to “Main chat”
Hover on X again, select the Edit option, change the message to Y and Save
Hover on the edited message (now it became Y) and select “Reply in thread” again
Verify that The pending edit text should be updated to Y (since the message ID is still the same)
Select Edit message X but not save
Go to the thread of that message then change the message to Z and Save
Verify that The pending edit text should be updated to Z (since the message ID is still the same)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web_compress.mp4

Mobile Web - Chrome

chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop_compress.mp4

iOS

ios.2.mp4

Android

android.mp4

melvin-bot · 2023-07-29T08:33:34Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr

Tests well, just some minor

mollfpr · 2023-07-31T04:41:02Z

+    withLocalize,
+    withReportActionsDrafts({
+        propName: 'drafts',
+        transformValue: (drafts) => drafts,


Is define transformValue necessary?

mollfpr · 2023-07-31T04:41:04Z

+        }
+        // updating in parent message cause child draft message to change
+        if (props.action.childReportID) {
+            if (lodashGet(props.drafts, [`reportActionsDrafts_${props.action.childReportID}_${props.action.reportActionID}`], undefined)) {


Use ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS instead reportActionDrafts.

mollfpr · 2023-07-31T05:29:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

23706.Web.mp4

Mobile Web - Chrome

23706.mWeb-Chrome.mp4

Mobile Web - Safari

23706.mWeb-Safari.mp4

Desktop

23706.Desktop.mp4

iOS

23706.iOS.mp4

Android

23706.Android.mp4

…x/22368

dukenv0307 · 2023-07-31T06:45:15Z

@mollfpr PR updated. Please help review again

mollfpr

LGTM and tests well 👍

dukenv0307 · 2023-08-01T03:59:45Z

@youssef-lr Please help review

dukenv0307 · 2023-08-02T06:56:32Z

@youssef-lr ICYMI. Please help review this PR

youssef-lr · 2023-08-02T21:10:20Z

Reviewing today.

dukenv0307 · 2023-08-04T02:42:07Z

@youssef-lr Bump, please help to review

dukenv0307 · 2023-08-07T02:34:13Z

@youssef-lr ICYMI. please help review the PR

youssef-lr · 2023-08-07T23:18:43Z

Left a minor comment!

Co-authored-by: Youssef Lourayad <youssef@expensify.com>

dukenv0307 · 2023-08-08T02:07:41Z

@youssef-lr Updated. Thanks for your comment
cc @mollfpr

mollfpr

dukenv0307 · 2023-08-10T02:00:51Z

@youssef-lr ICYMI. Please help review the PR

dukenv0307 · 2023-08-14T03:03:06Z

@youssef-lr Bump

youssef-lr · 2023-08-14T22:56:29Z

Seems like there's a unit test failing.

dukenv0307 · 2023-08-15T01:43:19Z

@youssef-lr Unit test failed from the main branch, I just merged the main branch and It is resolved. Help to check again
cc @mollfpr

OSBotify · 2023-08-15T01:48:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:21:52Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:28:37Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:11:38Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 7 commits July 22, 2023 17:33

update draft

44fc467

update draft

c643622

fix: update draft message logic

3636f88

fix: remove redundant function

b6ba307

Merge branch 'main' into fix/22368

5f201bf

Merge branch 'main' into fix/22368

f9347f9

merge main

963ddd2

dukenv0307 marked this pull request as ready for review July 29, 2023 08:33

dukenv0307 requested a review from a team as a code owner July 29, 2023 08:33

melvin-bot Bot requested review from mollfpr and removed request for a team July 29, 2023 08:33

dukenv0307 mentioned this pull request Jul 29, 2023

[HOLD for payment 2023-08-28] [$1000] When in editing mode, the edited message does not dynamically update between the main chat and sub-thread #22368

Closed

6 tasks

mollfpr requested changes Jul 31, 2023

View reviewed changes

dukenv0307 added 2 commits July 31, 2023 12:42

fix: comment

0031c68

Merge branch 'fix/22368' of https://github.com/dukenv0307/App into fi…

7b34a1a

…x/22368

mollfpr approved these changes Jul 31, 2023

View reviewed changes

melvin-bot Bot requested a review from youssef-lr July 31, 2023 10:47

dukenv0307 added 2 commits August 2, 2023 09:43

Merge branch 'main' into fix/22368

4fb0ab8

fix conflict

666168a

youssef-lr reviewed Aug 7, 2023

View reviewed changes

Comment thread src/pages/home/report/ReportActionItemMessageEdit.js Outdated

youssef-lr reviewed Aug 7, 2023

View reviewed changes

Comment thread src/pages/home/report/ReportActionItemMessageEdit.js Outdated

dukenv0307 and others added 2 commits August 8, 2023 09:07

Update src/pages/home/report/ReportActionItemMessageEdit.js

a1d9932

Co-authored-by: Youssef Lourayad <youssef@expensify.com>

Update src/pages/home/report/ReportActionItemMessageEdit.js

77d7f01

Co-authored-by: Youssef Lourayad <youssef@expensify.com>

mollfpr approved these changes Aug 8, 2023

View reviewed changes

melvin-bot Bot requested a review from youssef-lr August 8, 2023 14:30

merge main

050b41a

youssef-lr approved these changes Aug 14, 2023

View reviewed changes

merge main

954eba4

youssef-lr merged commit 4275741 into Expensify:main Aug 15, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

eh2077 mentioned this pull request Sep 15, 2023

[HOLD for payment 2023-10-09] [HOLD for payment 2023-09-04] [HOLD 25758][$2000] App displays strong HTML tag in reply in thread first message if we keep it in edit mode and edit message in main report #21527

Closed

6 tasks

situchan mentioned this pull request Sep 26, 2023

[HOLD for payment 2023-10-09] [HOLD App#28154] [$500] Chat - Editing composer is closed when saving empty message in thread first chat #27605

Closed

6 tasks

Conversation

dukenv0307 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 29, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jul 31, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 1, 2023

Uh oh!

dukenv0307 commented Aug 2, 2023

Uh oh!

youssef-lr commented Aug 2, 2023

Uh oh!

dukenv0307 commented Aug 4, 2023

Uh oh!

dukenv0307 commented Aug 7, 2023

Uh oh!

Uh oh!

Uh oh!

youssef-lr commented Aug 7, 2023

Uh oh!

dukenv0307 commented Aug 8, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 10, 2023

Uh oh!

dukenv0307 commented Aug 14, 2023

Uh oh!

youssef-lr commented Aug 14, 2023

Uh oh!

dukenv0307 commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Jul 27, 2023 •

edited

Loading

mollfpr commented Jul 31, 2023 •

edited

Loading