Update hover color for lounge access icon by hungvu193 · Pull Request #24358 · Expensify/App

hungvu193 · 2023-08-10T09:14:49Z

Details

Update hover color for lounge access icon

Fixed Issues

$ #22766
PROPOSAL: #22766 (comment)

Tests

Click on the settings (profile icon)
Hover over various buttons, observe color change of the icon.
Click Profile.
Hover over personal details, observe color change of the icon.
Hover over or long pressing Lounge Access.
Verify that LoungeAccess icon turn into white when hovering.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Click on the settings (profile icon)
Hover over various buttons, observe color change of the icon.
Click Profile.
Hover over personal details, observe color change of the icon.
Hover over or long pressing Lounge Access.
Verify that LoungeAccess icon turn into white when hovering.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-10.at.16.27.48.mov

Mobile Web - Chrome

RPReplay_Final1691662040.MP4

Mobile Web - Safari

Screen.Recording.2023-08-10.at.16.29.53.mov

Desktop

Screen.Recording.2023-08-10.at.16.27.48.mov

iOS

Screen.Recording.2023-08-10.at.16.40.40.mov

Android

Screen.Recording.2023-08-10.at.16.30.35.mov

melvin-bot · 2023-08-10T09:41:30Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-08-10T10:08:32Z

@situchan PR is ready for review! Please have a look. Ty 😄

situchan · 2023-08-11T07:39:40Z

 import Link from '../../../assets/images/link.svg';
 import LinkCopy from '../../../assets/images/link-copy.svg';
 import Lock from '../../../assets/images/lock.svg';
-import LoungeAccess from '../../../assets/images/lounge-access.svg';


Let's remove lounge-access.svg file

situchan · 2023-08-11T07:45:05Z

+    /** The width of the icon. */
+    width: PropTypes.number,
+
+    /** The height of the icon. */
+    height: PropTypes.number,


These props are unused and can be removed

situchan

Requesting these changes because of these warnings:

situchan · 2023-08-11T08:00:52Z

+                            isHovered={this.props.isHovered}
+                            isPressed={this.props.isPressed}


Suggested change

isHovered={this.props.isHovered}

isPressed={this.props.isPressed}

hovered={this.props.isHovered.toString()}

pressed={this.props.isPressed.toString()}

situchan · 2023-08-11T08:01:12Z

+                    isHovered={this.props.isHovered}
+                    isPressed={this.props.isPressed}


Suggested change

isHovered={this.props.isHovered}

isPressed={this.props.isPressed}

hovered={this.props.isHovered.toString()}

pressed={this.props.isPressed.toString()}

situchan · 2023-08-11T08:01:44Z

+    fill: PropTypes.string,
+
+    /** Is icon hovered */
+    isHovered: PropTypes.bool,


Suggested change

isHovered: PropTypes.bool,

hovered: PropTypes.string,

situchan · 2023-08-11T08:01:59Z

+    isHovered: PropTypes.bool,
+
+    /** Is icon pressed */
+    isPressed: PropTypes.bool,


Suggested change

isPressed: PropTypes.bool,

pressed: PropTypes.string,

situchan · 2023-08-11T08:02:20Z

+    isHovered: false,
+    isPressed: false,


Suggested change

isHovered: false,

isPressed: false,

hovered: 'false',

pressed: 'false',

situchan · 2023-08-11T08:02:36Z

+            </G>
+            <G>
+                <Path
+                    fill={props.isHovered || props.isPressed ? props.fill : themeColors.starDefaultBG}


Suggested change

fill={props.isHovered || props.isPressed ? props.fill : themeColors.starDefaultBG}

fill={props.hovered === 'true' || props.pressed === 'true' ? props.fill : themeColors.starDefaultBG}

Thank you man, you saved my day. Update in seconds

hungvu193 · 2023-08-11T08:19:32Z

Updated ! @situchan

situchan · 2023-08-11T08:32:07Z

@hungvu193 star not changing to white on hover. can you investigate?

hungvu193 · 2023-08-11T08:34:10Z

@hungvu193 star not changing to white on hover. can you investigate?

LEt me see

hungvu193 · 2023-08-11T08:42:42Z

Updated. I forgot to change Icon props name. Should be working fine now

Screen.Recording.2023-08-11.at.15.43.00.mov

situchan · 2023-08-11T17:12:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

LGTM

hungvu193 · 2023-08-15T05:37:16Z

Friendly bump @aldo-expensify

aldo-expensify

Thanks for the ping!

It looks good to me

OSBotify · 2023-08-15T07:38:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:21:43Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:28:28Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:11:29Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

hungvu193 added 2 commits August 10, 2023 16:09

update hover color for lounge access icon

1ccb131

fix linting

789aec2

hungvu193 marked this pull request as ready for review August 10, 2023 09:41

hungvu193 requested a review from a team as a code owner August 10, 2023 09:41

melvin-bot Bot requested review from situchan and removed request for a team August 10, 2023 09:41

situchan reviewed Aug 11, 2023

View reviewed changes

situchan suggested changes Aug 11, 2023

View reviewed changes

fix warning and remove unused icon

5ea39f2

hungvu193 force-pushed the fix-22766 branch from f1d72d8 to 5ea39f2 Compare August 11, 2023 08:19

change icon props name

ba79828

situchan approved these changes Aug 11, 2023

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify August 11, 2023 17:13

aldo-expensify approved these changes Aug 15, 2023

View reviewed changes

aldo-expensify merged commit 56f0b0f into Expensify:main Aug 15, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

melvin-bot Bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$1000] Web - Lounge access icon does not change color on hover #22766

Closed

6 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

		isHovered={this.props.isHovered}
		isPressed={this.props.isPressed}

	fill={props.isHovered \|\| props.isPressed ? props.fill : themeColors.starDefaultBG}
	fill={props.hovered === 'true' \|\| props.pressed === 'true' ? props.fill : themeColors.starDefaultBG}

Conversation

hungvu193 commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 10, 2023

Uh oh!

hungvu193 commented Aug 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Aug 11, 2023

Uh oh!

situchan commented Aug 11, 2023

Uh oh!

hungvu193 commented Aug 11, 2023

Uh oh!

hungvu193 commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Aug 11, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Aug 15, 2023

Uh oh!

aldo-expensify left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hungvu193 commented Aug 10, 2023 •

edited

Loading

situchan Aug 11, 2023 •

edited

Loading

hungvu193 commented Aug 11, 2023 •

edited

Loading