Hide reports with error from task share somewhere list by Nikhil-Vats · Pull Request #24506 · Expensify/App

Nikhil-Vats · 2023-08-13T14:40:38Z

Details

Hides report that couldn't be created on backend from share destination list for tasks.

Fixed Issues

$ #23361
PROPOSAL: #23361 (comment)

Tests

Go to FAB > new chat.
Enter an email like a@_.ab. Press enter.
Verify that composer is hidden and error invalid email is shown in the bottom.
Go back to FAB > assign task.
Enter a title and click next. Click on Share somewhere.
Verify that the new chat with a@_.ab is not in the list of contacts shown.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

23361_web.mov

Mobile Web - Chrome

23361_mweb_chrome.mov

Mobile Web - Safari

23361_mweb_safari.mov

Desktop

23361_desktop.mov

iOS

23361_ios.mov

Android

23361_android.mov

melvin-bot · 2023-08-13T14:40:42Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-08-13T18:28:19Z

Jest unit tests are failing on multiple PRs, I will try to find out what broke the tests but it is not related to this PR since they are failing on PRs before this one.

@arosiclair @aimane-chnaif as per your feedback -

We should think about renaming this ReportUtils.shouldHideComposer function since at this point it is for a lot more than just the composer, but let's not block on that.

I have renamed the function to shouldDisableWriteActionsand also changed the comment -

/**
 * Returns true if write actions like assign task, money request, send message should be disabled on a report
 * @param {Object} report
 * @returns {Boolean}
 */
function shouldDisableWriteActions(report) {
    const reportErrors = getAddWorkspaceRoomOrChatReportErrors(report);
    return isArchivedRoom(report) || !_.isEmpty(reportErrors) || !isAllowedToComment(report) || isAnonymousUser;
}

What do you think? Do you have any other alternatives?

aimane-chnaif · 2023-08-13T18:30:34Z

@Nikhil-Vats don't care about unit tests. It was reported here.

PauloGasparSv · 2023-08-14T13:07:10Z

Hey team, do you mind pulling from main to fix the broken test?

Nikhil-Vats · 2023-08-14T13:13:44Z

Thanks @PauloGasparSv . I will do that.

Nikhil-Vats · 2023-08-14T13:55:12Z

Hey @aimane-chnaif, I have merged the latest main and all checks are passing now. PR is ready for review.

aimane-chnaif · 2023-08-14T17:45:34Z

@Nikhil-Vats please fix conflict

Nikhil-Vats · 2023-08-14T17:50:26Z

Done @aimane-chnaif

aimane-chnaif · 2023-08-14T22:14:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉

aimane-chnaif · 2023-08-14T18:19:58Z

 * @returns {Boolean}
 */
-function shouldHideComposer(report) {
+function shouldDisableWriteActions(report) {


I am not against this naming. But will defer to @arosiclair

arosiclair

Looks good just remove those comments about the hiding composer since they aren't needed anymore

arosiclair · 2023-08-15T16:05:20Z

@@ -156,7 +156,7 @@ class ReportScreen extends React.Component {

    componentDidUpdate(prevProps) {
        // If composer should be hidden, hide emoji picker as well


Suggested change

// If composer should be hidden, hide emoji picker as well

arosiclair · 2023-08-15T16:05:56Z

@@ -257,7 +257,7 @@ function getOptionData(report, reportActions, personalDetails, preferredLocale,
    result.notificationPreference = report.notificationPreference || null;

    // If the composer is hidden then the user is not allowed to comment, same can be used to hide the draft icon.


Suggested change

// If the composer is hidden then the user is not allowed to comment, same can be used to hide the draft icon.

Nikhil-Vats · 2023-08-15T16:34:39Z

Done @arosiclair.

melvin-bot · 2023-08-15T16:46:32Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-08-15T16:51:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:21:22Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:28:04Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:11:05Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Hide reports with error from task share somewhere list

36b0cdc

Nikhil-Vats requested a review from a team as a code owner August 13, 2023 14:40

melvin-bot Bot requested review from aimane-chnaif and removed request for a team August 13, 2023 14:40

Nikhil-Vats added 2 commits August 13, 2023 20:12

Fix lint issues

ae3b4a0

NIT: change comment

0c4ccb9

Merge branch 'main' into 23361_disable_sharing_task_on_room_with_error

700af1a

Merge branch 'main' into 23361_disable_sharing_task_on_room_with_error

ec53f58

aimane-chnaif approved these changes Aug 14, 2023

View reviewed changes

melvin-bot Bot requested a review from arosiclair August 14, 2023 22:15

arosiclair requested changes Aug 15, 2023

View reviewed changes

Remove unnecessary comments

0086d15

arosiclair approved these changes Aug 15, 2023

View reviewed changes

arosiclair merged commit ad73e8c into Expensify:main Aug 15, 2023

melvin-bot Bot added the Emergency label Aug 15, 2023

arosiclair removed the Emergency label Aug 15, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot Bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$1000] Web - Can create a task on a room archived #23361

Closed

6 tasks

marcaaron mentioned this pull request Aug 23, 2023

[HOLD for payment 2023-09-04] Task -App becomes unresponsive when Assign Task to user that doesn't have a NewDot account yet #25688

Closed

6 tasks

		@@ -156,7 +156,7 @@ class ReportScreen extends React.Component {

		componentDidUpdate(prevProps) {
		// If composer should be hidden, hide emoji picker as well

		@@ -257,7 +257,7 @@ function getOptionData(report, reportActions, personalDetails, preferredLocale,
		result.notificationPreference = report.notificationPreference \|\| null;

		// If the composer is hidden then the user is not allowed to comment, same can be used to hide the draft icon.

Conversation

Nikhil-Vats commented Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 13, 2023

Uh oh!

Nikhil-Vats commented Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Aug 13, 2023

Uh oh!

PauloGasparSv commented Aug 14, 2023

Uh oh!

Nikhil-Vats commented Aug 14, 2023

Uh oh!

Nikhil-Vats commented Aug 14, 2023

Uh oh!

aimane-chnaif commented Aug 14, 2023

Uh oh!

Nikhil-Vats commented Aug 14, 2023

Uh oh!

aimane-chnaif commented Aug 14, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

arosiclair Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

Nikhil-Vats commented Aug 15, 2023

Uh oh!

melvin-bot Bot commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 15, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nikhil-Vats commented Aug 13, 2023 •

edited

Loading

Nikhil-Vats commented Aug 13, 2023 •

edited

Loading