fix: android app - expand icon doesn't disappear immediately after sending the message by HezekielT · Pull Request #27015 · Expensify/App

HezekielT · 2023-09-08T11:29:28Z

Details

Fixed Issues

$ #25975
PROPOSAL: #25975 (comment)

Tests

Open any chat.
Start typing multiline messages until the expand icon appears.
Click on the send button.
Verify that the expand icon disappears immediately.

Verify that no errors appear in the JS console

Offline tests

Same as Tests Section.

QA Steps

Same as Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mwebChrome.mov

Mobile Web - Safari

iosSafari.mov

Desktop

Desktop.mov

iOS

IosNative.mov

Android

IosNative.mov

melvin-bot · 2023-09-08T11:29:33Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-09-08T19:13:56Z

@HezekielT On ios the plus button jumps after sending a msg

CleanShot.2023-09-08.at.20.10.37.mp4

HezekielT · 2023-09-08T19:51:08Z

@fedirjh If you search for isComposerFullSize and isFullComposerAvailable in AttachmentPickerWithMenuItems.js and ReportActionCompose.js, it seems a lot of styling depends on them which means we also have to add && !isCommentEmpty to all of them. The problem is that even after adding this check to all of them, the styles are not working properly.

So, I was wondering if we can go with the main solution I suggested in my proposal which is to set isComposerFullSize and isFullComposerAvailable to false in SendButton.js. It is simple compared to !isCommentEmpty check and works perfectly. I can push the changes and you can check them.
What do you think?

fedirjh · 2023-09-08T19:53:48Z

@HezekielT Sounds good let's try the main solution.

fedirjh · 2023-09-08T19:55:21Z

@HezekielT Just to confirm, applying the main solution will fix this #27015 (comment) without any extra changes to styles?

HezekielT · 2023-09-08T20:20:21Z

@fedirjh

Just to confirm, applying the main solution will fix this #27015 (comment) without any extra changes to styles?

Yes, it will be solved. Sorry for not stating that clearly in my previous comment.

Please take a look at the code changes I made when you get the chance. Thanks.

fedirjh

Test well, left comment about code readability.

fedirjh · 2023-09-09T09:28:45Z

@HezekielT I think we can update this line to :

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 359 in ec95ab0

isFullComposerAvailable={isFullComposerAvailable}

There is a little improvement in transition after applying that change:

Before	After
Before.mp4	After.mp4

fedirjh · 2023-09-09T10:50:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-09-08.at.19.41.16.mp4

Mobile Web - Chrome

CleanShot.2023-09-09.at.09.40.36.mp4

Mobile Web - Safari

CleanShot.2023-09-08.at.19.43.44.mp4

Desktop

CleanShot.2023-09-09.at.11.17.42.mp4

iOS

CleanShot.2023-09-09.at.08.20.09.mp4

Android

android.mp4

HezekielT · 2023-09-09T11:08:56Z

@fedirjh

@HezekielT I think we can update this line to :

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

That is even better in fact we can even do the same for isComposerFullSize but I'm noticing the following edge case in android native.

video

edge1.mov

and trying to solve it by adding && !isCommentEmpty to the styles here is giving me this weird behaviour as shown below.

video

edgeCase2.mov

So I think we can get the best result by combining both the solution you suggested and still reseting the size in SendButton. what do you think?

fedirjh · 2023-09-09T11:20:19Z

So I think we can get the best result by combining both the solution you suggested and still reseting the size in SendButton. what do you think?

@HezekielT This is actually what I had suggested. My intention was to keep the use of resetFullComposerToFalse + include the extra check.

HezekielT · 2023-09-09T11:25:04Z

@fedirjh
Oh, I see.

I have pushed the changes please take a look. Thanks again for the suggestion.

fedirjh · 2023-09-09T13:25:10Z

@HezekielT Can you please revert the last commit, that code is not redundant and it’s used to reset the composer when we send an attachment.

reset.mp4

HezekielT · 2023-09-09T13:45:02Z

@fedirjh reverted.

fedirjh

Looks good to me.

🎀 👀 🎀 C+ reviewed

OSBotify · 2023-09-11T02:40:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-11T03:48:03Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-11T23:43:46Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-12T00:18:28Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:44:55Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

abdulrahuman5196 · 2023-10-10T15:45:22Z

                                    report={report}
                                    reportParticipantIDs={reportParticipantIDs}
-                                    isFullComposerAvailable={isFullComposerAvailable}
+                                    isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}


This caused regression of not showing compose button on multiple new lines - #28093 (comment)

HezekielT added 2 commits September 8, 2023 14:04

use isCommentEmpty flag to hide expand Icon of composer

aa9c074

remove indentation

a501d5e

HezekielT requested a review from a team as a code owner September 8, 2023 11:29

melvin-bot Bot requested review from fedirjh and removed request for a team September 8, 2023 11:29

reset isComposerFullSize to false in SendButton

d8adf78

fedirjh suggested changes Sep 9, 2023

View reviewed changes

Comment thread src/pages/home/report/ReportActionCompose/ReportActionCompose.js Outdated

added extra check and renamed the function to make it more descriptive

1116ace

remove redundant code

a17dec6

revert change

6232d7e

fedirjh approved these changes Sep 9, 2023

View reviewed changes

melvin-bot Bot requested a review from MariaHCD September 9, 2023 15:59

MariaHCD approved these changes Sep 11, 2023

View reviewed changes

MariaHCD merged commit 4a8fb06 into Expensify:main Sep 11, 2023

OSBotify mentioned this pull request Sep 11, 2023

Deploy Checklist: New Expensify 2023-09-11 #27120

Closed

31 tasks

melvin-bot Bot mentioned this pull request Sep 11, 2023

[HOLD for payment 2023-09-18] [$1000] Android App - The resizing icon doesn't disappear immediately after sending the message #25975

Closed

6 tasks

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

kbecciv mentioned this pull request Sep 24, 2023

[HOLD for payment 2023-10-12] [$500] Chat - Expand button does not show if composer only contains new line #28093

Closed

6 tasks

abdulrahuman5196 reviewed Oct 10, 2023

View reviewed changes

Conversation

HezekielT commented Sep 8, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 8, 2023

Uh oh!

fedirjh commented Sep 8, 2023

Uh oh!

HezekielT commented Sep 8, 2023

Uh oh!

fedirjh commented Sep 8, 2023

Uh oh!

fedirjh commented Sep 8, 2023

Uh oh!

HezekielT commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fedirjh commented Sep 9, 2023

Uh oh!

fedirjh commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

HezekielT commented Sep 9, 2023

Uh oh!

fedirjh commented Sep 9, 2023

Uh oh!

HezekielT commented Sep 9, 2023

Uh oh!

fedirjh commented Sep 9, 2023

Uh oh!

HezekielT commented Sep 9, 2023

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 11, 2023

Uh oh!

OSBotify commented Sep 11, 2023

Uh oh!

OSBotify commented Sep 11, 2023

Uh oh!

OSBotify commented Sep 12, 2023

Uh oh!

OSBotify commented Sep 13, 2023

Uh oh!

abdulrahuman5196 Oct 10, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HezekielT commented Sep 8, 2023 •

edited

Loading

fedirjh commented Sep 9, 2023 •

edited

Loading