Skip to content

[No QA] [TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #28269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 19 commits into from
Nov 6, 2023
Merged

[No QA] [TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #28269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
63c06cf
Rename file to TS
fabioh8010 Sep 26, 2023
4ac2485
Organize imports
fabioh8010 Sep 26, 2023
0a1bae4
Migrate PersonalDetails to TS
fabioh8010 Sep 26, 2023
0513362
Remove underscore usage
fabioh8010 Sep 26, 2023
1f5f253
Improve PendingFields and ErrorFields
fabioh8010 Sep 26, 2023
3206385
Merge branch 'main' into ts/lib/PersonalDetails
fabioh8010 Oct 3, 2023
b76af47
Improve typings
fabioh8010 Oct 3, 2023
1464338
Merge remote-tracking branch 'origin/main' into ts/lib/PersonalDetails
fabioh8010 Oct 3, 2023
c2105b4
Merge branch 'main' into ts/lib/PersonalDetails
fabioh8010 Oct 4, 2023
3992778
Minor fixes
fabioh8010 Oct 4, 2023
318b020
Merge branch 'main' into ts/lib/PersonalDetails
kubabutkiewicz Oct 9, 2023
2250991
fix: resolve comments
kubabutkiewicz Oct 9, 2023
57dfebb
Merge remote-tracking branch 'origin/main' into ts/lib/PersonalDetails
fabioh8010 Oct 23, 2023
067cce1
Address review comments
fabioh8010 Oct 26, 2023
f12b828
Merge remote-tracking branch 'origin/main' into ts/lib/PersonalDetails
fabioh8010 Oct 27, 2023
58eb8f3
Improve comments
fabioh8010 Oct 27, 2023
fe109f1
Merge remote-tracking branch 'origin/main' into ts/lib/PersonalDetails
fabioh8010 Oct 30, 2023
c801a02
Merge branch 'main' of github.com:fabioh8010/expensify-app into ts/li…
kubabutkiewicz Nov 6, 2023
3d2abe0
Merge branch 'ts/lib/PersonalDetails' of github.com:fabioh8010/expens…
kubabutkiewicz Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ONYXKEYS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ type OnyxValues = {
[ONYXKEYS.FORMS.WELCOME_MESSAGE_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.LEGAL_NAME_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.WORKSPACE_INVITE_MESSAGE_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.DATE_OF_BIRTH_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.DATE_OF_BIRTH_FORM]: OnyxTypes.DateOfBirthForm;
Comment thread
fabioh8010 marked this conversation as resolved.
[ONYXKEYS.FORMS.HOME_ADDRESS_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.NEW_ROOM_FORM]: OnyxTypes.Form;
[ONYXKEYS.FORMS.ROOM_SETTINGS_FORM]: OnyxTypes.Form;
Expand Down
Loading