RequestorStep: Fix forward ref by kacper-mikolajczak · Pull Request #28454 · Expensify/App

kacper-mikolajczak · 2023-09-29T09:32:50Z

Details

Fixed Issues

$ #28390
PROPOSAL: #28390 (comment)

Tests

Verify that no errors/warnings appear in the JS console when accessing BankAccount flow:

Open Settings panel
Go to Workspaces
Pick a workspace
Go to Bank Account
Go through required steps to see RequestorStep
See if error appears

Offline tests

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

requestorStep_rec_web.mov

Mobile Web - Chrome

requestorStep_rec_mandroid.mov

Mobile Web - Safari

requestorStep_rec_mios.mov

Desktop

requestorStep_rec_desktop.mov

iOS

requestorStep_rec_ios.mov

Android

requestorStep_rec_android.mov

kacper-mikolajczak · 2023-09-29T12:07:58Z

While fixing this, I stumbled upon, such issue. It looks like there is a problem with withOnyx in Form component, which tries to access draftValues. draftValues seems to be undefined while Onyx tries to set its content in setWithOnyxState

Screen.Recording.2023-09-29.at.13.31.37.mov

Therefore, I could not get nice videos for all platforms, but I provided as an example recordings for Web and iOS, so we can see that currently investigated error with forwardRef disappeared. Let me know what you guys think, if this should be handled in the spearate issue, thanks!

kacper-mikolajczak · 2023-10-03T09:37:28Z

While testing on different platforms, it:

works on Chrome

Screen.Recording.2023-10-03.at.11.34.27.mov

does not work on iOS

Screen.Recording.2023-10-03.at.10.53.42.mov

kacper-mikolajczak · 2023-10-03T09:39:37Z

Also tested with merged current main and the error still appears, so it does not look like a external regression

kacper-mikolajczak · 2023-10-10T09:47:45Z

There is a warning in the console when accessing third step of Bank account flow:

Failed prop type: Invalid prop `listLoaderComponent` of type `object` supplied to `GooglePlacesAutocomplete`, expected `function`.

It looks like it is also present on main branch. It is also visible in the recordings.

kacper-mikolajczak · 2023-10-10T09:49:18Z

I needed to forwarded ref in the ScreenWrapper component

melvin-bot · 2023-10-10T12:12:50Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kacper-mikolajczak · 2023-10-17T09:05:14Z

Hi @aimane-chnaif, have you got an estimate on when this PR will be checked? Thanks!

aimane-chnaif · 2023-10-30T10:26:14Z

@kacper-mikolajczak please fix conflict

kacper-mikolajczak · 2023-10-30T14:19:28Z

@aimane-chnaif Conflicts resolved 👍

kacper-mikolajczak · 2023-10-31T10:17:19Z

Hi @aimane-chnaif did you have a chance to look at the PR? Is there anything I can help you with to move it further? Thanks!

aimane-chnaif · 2023-10-31T11:29:40Z

@kacper-mikolajczak some checklist items are missing. please fix them

kacper-mikolajczak · 2023-10-31T11:50:43Z

@aimane-chnaif Done ✅

aimane-chnaif · 2023-10-31T17:27:02Z

@kacper-mikolajczak conflicts.

And I am still seeing this (android only)

android.bug.mov

kacper-mikolajczak · 2023-11-02T10:57:19Z

Hi @aimane-chnaif,

Conflicts resolved ✅

Warning does not seem to be present after last merge and a fix, could you check on your side? Thanks!

out.mp4

aimane-chnaif · 2023-11-05T13:42:49Z

@kacper-mikolajczak I am still seeing in android

Screen.Recording.2023-11-05.at.2.41.23.PM.mov

aimane-chnaif · 2023-11-05T14:34:01Z

I finally figured out why this is happening on android only.
The issue is in /components/DatePicker/index.android.js
Let's fix that

kacper-mikolajczak · 2023-11-06T09:16:53Z

Thanks @aimane-chnaif, I pushed the fix - let me know if warning is gone 👍

aimane-chnaif · 2023-11-06T09:27:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

aimane-chnaif

LGTM 🎉

joelbettner

I think it looks good, but there are conflicts (@kacper-mikolajczak).

kacper-mikolajczak · 2023-11-06T19:35:43Z

Thanks @joelbettner, conflicts resolved ✅

joelbettner · 2023-11-07T16:24:11Z

Not sure why perf-tests are failing. Following protocol found here.

Merging

melvin-bot · 2023-11-07T16:24:21Z

@joelbettner looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-11-07T16:28:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-08T08:30:42Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.96-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:46:13Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T16:02:21Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:55:48Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2023-11-26T21:57:23Z

+            // We need to have this prop to remove keyboard before going away from the screen, to avoid previous screen look weird for a brief moment,
+            // also we need to have generic control in future - to prevent closing keyboard for some rare cases in which beforeRemove has limitations
+            // described here https://reactnavigation.org/docs/preventing-going-back/#limitations
+            const beforeRemoveSubscription = shouldDismissKeyboardBeforeClose
+                ? navigation.addListener('beforeRemove', () => {
+                      if (!isKeyboardShownRef.current) {
+                          return;
+                      }
+                      Keyboard.dismiss();
+                  })
+                : undefined;
+
+            return () => {
+                unsubscribeTransitionEnd();
+
+                if (beforeRemoveSubscription) {
+                    beforeRemoveSubscription();
                }
-
-                return (
-                    <View
-                        style={[styles.flex1, {minHeight}]}
-                        // eslint-disable-next-line react/jsx-props-no-spreading
-                        {...(isDevelopment ? panResponder.panHandlers : {})}
-                        testID={testID}
-                    >
+            };


This did not work as intended. It later caused #30268

kacper-mikolajczak added 2 commits September 28, 2023 19:07

Fix refs

07172be

add clarifying comment

a8e58e5

kacper-mikolajczak added 2 commits October 10, 2023 09:52

Merge branch 'main' into fix/28390/requestor-step-refs

3450b0f

forward ref in ScreenWrapper

cda0b1f

waterim approved these changes Oct 10, 2023

View reviewed changes

kacper-mikolajczak marked this pull request as ready for review October 10, 2023 12:12

kacper-mikolajczak requested a review from a team as a code owner October 10, 2023 12:12

melvin-bot bot requested review from aimane-chnaif and removed request for a team October 10, 2023 12:12

rezkiy37 approved these changes Oct 10, 2023

View reviewed changes

kacper-mikolajczak mentioned this pull request Oct 19, 2023

[$500] DEV: Bank Account - Console error on Connect bank account page #28390

Closed

6 tasks

aimane-chnaif reviewed Oct 22, 2023

View reviewed changes

Comment thread src/pages/ReimbursementAccount/RequestorStep.js Outdated

merge main

a7bbb40

Merge branch 'main' into fix/28390/requestor-step-refs

c1c3b46

kacper-mikolajczak requested a review from aimane-chnaif November 3, 2023 08:55

kacper-mikolajczak added 2 commits November 6, 2023 09:40

Merge branch 'main' into fix/28390/requestor-step-refs

9adbed8

fix android DatePicker propTypes

4e8f849

aimane-chnaif approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from joelbettner November 6, 2023 09:39

joelbettner previously approved these changes Nov 6, 2023

View reviewed changes

Merge branch 'main' into fix/28390/requestor-step-refs

245a43a

kacper-mikolajczak dismissed joelbettner’s stale review via 245a43a November 6, 2023 19:26

joelbettner approved these changes Nov 7, 2023

View reviewed changes

joelbettner merged commit b5a0a74 into Expensify:main Nov 7, 2023

melvin-bot bot added the Emergency label Nov 7, 2023

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

allroundexperts reviewed Nov 26, 2023

View reviewed changes

allroundexperts mentioned this pull request Nov 26, 2023

[$500] The keyboard closes after a moment when tapping back button #30268

Closed

6 tasks

Conversation

kacper-mikolajczak commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

kacper-mikolajczak commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kacper-mikolajczak commented Oct 3, 2023

Uh oh!

kacper-mikolajczak commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kacper-mikolajczak commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kacper-mikolajczak commented Oct 10, 2023

Uh oh!

melvin-bot bot commented Oct 10, 2023

Uh oh!

kacper-mikolajczak commented Oct 17, 2023

Uh oh!

Uh oh!

aimane-chnaif commented Oct 30, 2023

Uh oh!

kacper-mikolajczak commented Oct 30, 2023

Uh oh!

kacper-mikolajczak commented Oct 31, 2023

Uh oh!

aimane-chnaif commented Oct 31, 2023

Uh oh!

kacper-mikolajczak commented Oct 31, 2023

Uh oh!

aimane-chnaif commented Oct 31, 2023

Uh oh!

kacper-mikolajczak commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Nov 5, 2023

Uh oh!

aimane-chnaif commented Nov 5, 2023

Uh oh!

kacper-mikolajczak commented Nov 6, 2023

Uh oh!

aimane-chnaif commented Nov 6, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

joelbettner left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kacper-mikolajczak commented Nov 6, 2023

Uh oh!

joelbettner commented Nov 7, 2023

Uh oh!

melvin-bot bot commented Nov 7, 2023

Uh oh!

OSBotify commented Nov 7, 2023

Uh oh!

OSBotify commented Nov 8, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

allroundexperts Nov 26, 2023

Choose a reason for hiding this comment

Uh oh!

kacper-mikolajczak commented Sep 29, 2023 •

edited

Loading

kacper-mikolajczak commented Sep 29, 2023 •

edited

Loading

kacper-mikolajczak commented Oct 3, 2023 •

edited

Loading

kacper-mikolajczak commented Oct 10, 2023 •

edited

Loading

kacper-mikolajczak commented Nov 2, 2023 •

edited

Loading

joelbettner left a comment •

edited

Loading