[No QA][TS migration] Migrate 'Clipboard' lib to TypeScript#28789
[No QA][TS migration] Migrate 'Clipboard' lib to TypeScript#28789Julesssss merged 18 commits intoExpensify:mainfrom teneeto:ts-migration/clipboard
Conversation
fvlvte
left a comment
There was a problem hiding this comment.
Left comments about JSDoc, everything else LGTM.
Co-authored-by: Fábio Henriques <fabio.lacerda@outlook.com>
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey @sobitneupane, could you please review this PR? I assigned you here, but if you'd rather I assign someone else, no worries! |
fabioh8010
left a comment
There was a problem hiding this comment.
LGTM after addressing comments
|
@teneeto We have lint errors now. |
@fabioh8010 fixing now. |
Done. |
|
@Julesssss @sobitneupane The PR is ready to review again! |
|
@teneeto Could you please resolve the merge conflict? |
|
@Julesssss @sobitneupane can we take a look at this again?. |
|
Code seems fine, but it would be great to get an answer to my question here first |
|
Also, @sobitneupane could you please complete the checklist now? Thanks |
Hey @Julesssss, Sorry about that. Let me drop a comment there. |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Screen.Recording.2023-11-03.at.18.54.09.mov
Android: mWeb Chrome
Screen.Recording.2023-11-03.at.18.34.29.mov
iOS: Native
Screen.Recording.2023-11-03.at.18.24.34.mov
iOS: mWeb Safari
Screen.Recording.2023-11-03.at.18.22.48.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-03.at.18.16.08.mov
MacOS: Desktop
Screen.Recording.2023-11-03.at.18.29.13.mov
|
🎯 @sobitneupane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #30841. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.96-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀
|
Details
This change is made to migrate src/libs/Clipboard/index.native.js and src/libs/Clipboard/index.js lib files to TS
Fixed Issues
$: 24887
PROPOSAL: 24887
Tests
On mobile devices - Tap and hold on text to copy.
TAP on
Copy to clipboardfrom the bottom sheet.Confirm that the text is copied with a green check icon and text
Copied!press and hold any input field to paste copied text - to confirm that text was copied to clipboard.
For web or hoverable screen, hover any text and click on the copy icon.
6 paste text into any input field or text area to confirm that text was copied to clipboard.
Offline tests
On mobile devices - Tap and hold on text to copy.
TAP on
Copy to clipboardfrom the bottom sheet.Confirm that the text is copied with a green check icon and text
Copied!press and hold any input field to paste copied text - to confirm that text was copied to clipboard.
For web or hoverable screen, hover any text and click on the copy icon.
6 paste text into any input field or text area to confirm that text was copied to clipboard.
QA Steps
On mobile devices - Tap and hold on text to copy.
TAP on
Copy to clipboardfrom the bottom sheet.Confirm that the text is copied with a green check icon and text
Copied!press and hold any input field to paste copied text - to confirm that text was copied to clipboard.
For web or hoverable screen, hover any text and click on the copy icon.
6 paste text into any input field or text area to confirm that text was copied to clipboard.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-10-04.at.14.05.22.mov
Mobile Web - Chrome
Screen.Recording.2023-10-04.at.14.04.15.mov
Mobile Web - Safari
Screen.Recording.2023-10-04.at.14.02.18.mov
Desktop
Screen.Recording.2023-10-04.at.13.59.58.mov
iOS
Screen.Recording.2023-10-04.at.13.51.53.mov
Android
Screen.Recording.2023-10-06.at.05.58.47.mov