Skip to content

fix: 30268 The keyboard closes after a moment when tapping back button #30557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 3 commits into from
Nov 6, 2023
Merged

fix: 30268 The keyboard closes after a moment when tapping back button #30557

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba1a321
fix: 30268
tienifr Oct 28, 2023
1fb2b62
Merge branch 'main' into fix/30268
tienifr Oct 29, 2023
ed42039
Merge branch 'main' of https://github.com/tienifr/App into fix/30268
tienifr Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/ScreenWrapper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ function ScreenWrapper({
const maxHeight = shouldEnableMaxHeight ? windowHeight : undefined;
const isKeyboardShown = lodashGet(keyboardState, 'isKeyboardShown', false);

const isKeyboardShownRef = useRef();

isKeyboardShownRef.current = lodashGet(keyboardState, 'isKeyboardShown', false);

const panResponder = useRef(
PanResponder.create({
onStartShouldSetPanResponderCapture: (e, gestureState) => gestureState.numberActiveTouches === CONST.TEST_TOOL.NUMBER_OF_TAPS,
Expand Down Expand Up @@ -80,7 +84,7 @@ function ScreenWrapper({
// described here https://reactnavigation.org/docs/preventing-going-back/#limitations
const beforeRemoveSubscription = shouldDismissKeyboardBeforeClose
? navigation.addListener('beforeRemove', () => {
if (!isKeyboardShown) {
if (!isKeyboardShownRef.current) {
return;
}
Keyboard.dismiss();
Expand Down