[fix] show continue or start over widget on form filling exit from step 3 by keisyrzk · Pull Request #31439 · Expensify/App

keisyrzk · 2023-11-16T12:57:51Z

Details

It is a fix to #29166 reported along side with reverting the changes.

Fixed Issues

PROPOSAL:
Delete the code form the functional component's implementation:

useEffect(() => {
    setHasACHDataBeenLoaded(reimbursementAccount !== ReimbursementAccountProps.reimbursementAccountDefaultProps);
  }, [reimbursementAccount]);

It is not necessary and causes the reported issue.

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Settings > Workspaces > any workspace.
Click Bank account.
Click Connect manually.
Proceed until Step 3 of bank account setup.
Close the setup by clicking outside the RHN.
Go to Settings > Workspaces > any workspace.
Click Bank account.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_safari.mov

MacOS: Chrome / Safari

macOS_chrome.mov

macOS_safari.mov

MacOS: Desktop

macOS_desktop.mov

rezkiy37

Left a few comments, besides LGTM.

melvin-bot · 2023-11-17T05:36:20Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-11-17T05:45:04Z

Testing in few minutes

parasharrajat · 2023-11-17T06:24:39Z

We are bringing back the changes from the reverted PR and fixing the regression. @ntdiary Could you please take over as the original C+? Also, you have more context for it.

ntdiary · 2023-11-17T08:34:02Z

We are bringing back the changes from the reverted PR and fixing the regression. @ntdiary Could you please take over as the original C+? Also, you have more context for it.

@parasharrajat, ah, sure, thank you for the reminder. :)

ntdiary · 2023-11-17T15:57:05Z

Hi, @rezkiy37, when I click 'Continue with setup', the app crashes. Merging the main branch code will automatically fix this issue.
Additionally, it seems issue #31212 hasn't been fully fixed yet, I will continue to dig deeper later.

31439-test.mp4

keisyrzk · 2023-11-29T11:09:40Z

hey @ntdiary , would you mind posting an update if indeed everything is fine or some extra actions need to be applied?

ntdiary · 2023-11-30T15:27:01Z

hey @ntdiary , would you mind posting an update if indeed everything is fine or some extra actions need to be applied?

@keisyrzk, ah, sorry, I missed this PR. It's still strange, just as I demonstrated in the video above, whenever I select "Connect bank account" from the Cards page, it always skips the "Start Over" page, which means we haven't full fixed that regression #31212. Can you reproduce this problem?

Based on my investigation, for class components, during the update function, reimbursementAccount.isLoading is true, and it becomes false after the API request is completed. However, in our functional component, during the initial rendering, there is no such field in reimbursementAccount, causing shouldShowContinueSetupButton to be set to false prematurely. 🤔

keisyrzk · 2023-12-01T06:23:49Z

@ntdiary
I have merged the latests main.
From workspace / Reimbursements / "Unlock next-day reimbursements" -> Connect bank account
it works as intended every time.
From workspace / cards / Connect bank account see it working on app launch

reimbursementTest.mov

However, following this path again I do experience the problem indeed.

As the reported issue is about the workspace / Reimbursements / "Unlock next-day reimbursements" -> Connect bank account path and it is a big blocker I would like to suggest merging this PR and open a separate issue for the workspace / cards / Connect bank account path. It seems it needs deeper investigation.
What do you think @ntdiary ?

ntdiary · 2023-12-01T08:05:55Z

We have several paths:

workspace / Reimbursements / "Unlock next-day reimbursements" -> Connect bank account
workspace / Bills / "Unlock online bill payment" -> Connect bank account
workspace / Cards / Connect bank account
workspace / Bank account / Connect bank account

Actually, the 1st one can work in our original PR, and issue #31212 reported the 4th one, which also led to our original PR being reverted. 😂

So far, the 2nd, 3rd, and 4th ones are still unresolved. There's a precondition for reproducing, refresh page and make sure there is no reimbursementAccount.isLoading in Onyx (if you've visited Reimbursements page, that value will be saved).

demo.mp4

Co-authored-by: wentao <ntdiary@163.com>

keisyrzk · 2023-12-01T09:47:31Z

@ntdiary this looks good. I have tested all mentioned paths multiple times and works as intended. Good catch!

ntdiary

It looks like some code was missed during resolving conflicts. :)

Co-authored-by: wentao <ntdiary@163.com>

keisyrzk · 2023-12-04T06:38:07Z

@ntdiary
I pushed the changes.

ntdiary · 2023-12-04T07:49:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

31439-android-app.mp4

Android: mWeb Chrome

31439-android-chrome.mp4

iOS: Native

31439-ios-app.mp4

iOS: mWeb Safari

31439-ios-safari.mp4

MacOS: Chrome / Safari

31439-web.mp4

MacOS: Desktop

31439-desktop.mp4

ntdiary

LGTM. :)

OSBotify · 2023-12-04T18:15:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:55:38Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:40:43Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:30:48Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:20Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

keisyrzk added 2 commits November 16, 2023 07:31

fix

25b29b6

Merge branch 'main' into reimbursementFix

4c4ee67

rezkiy37 reviewed Nov 16, 2023

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated

rezkiy37 reviewed Nov 16, 2023

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated

rezkiy37 reviewed Nov 16, 2023

View reviewed changes

keisyrzk added 2 commits November 16, 2023 14:49

visual updates

868a1ad

prettier ran

5dce9d3

keisyrzk marked this pull request as ready for review November 17, 2023 05:36

keisyrzk requested a review from a team as a code owner November 17, 2023 05:36

melvin-bot bot removed the request for review from a team November 17, 2023 05:36

melvin-bot bot requested a review from parasharrajat November 17, 2023 05:36

parasharrajat suggested changes Nov 17, 2023

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated

pr cosmetics

5a68e6f

Merge branch 'main' into reimbursementFix

90d2a4e

keisyrzk added 2 commits December 1, 2023 06:38

merge main

7eaaa01

merge conflicts

8300f57

ntdiary reviewed Dec 1, 2023

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated

Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js

76b1a29

Co-authored-by: wentao <ntdiary@163.com>

ntdiary suggested changes Dec 1, 2023

View reviewed changes

Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js

2ef98f8

Co-authored-by: wentao <ntdiary@163.com>

keisyrzk and others added 4 commits December 4, 2023 07:06

Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js

46fa265

Co-authored-by: wentao <ntdiary@163.com>

Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js

17ac677

Co-authored-by: wentao <ntdiary@163.com>

merge missings

b57985c

linter & prettier

a1a578e

ntdiary approved these changes Dec 4, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 December 4, 2023 08:13

johnmlee101 approved these changes Dec 4, 2023

View reviewed changes

johnmlee101 merged commit 299721b into Expensify:main Dec 4, 2023

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

ntdiary mentioned this pull request Dec 5, 2023

[$500] Workspace - Bank account setup page appears briefly when opening BA when BA is already set up #31207

Closed

6 tasks

ntdiary mentioned this pull request Dec 7, 2023

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$250] Migrate ReimbursementAccountPage.js to function component #16245

Closed

1 task

MelvinBot mentioned this pull request Feb 26, 2026

Skip loading indicator when refreshing bank account data after reconnection #83413

Closed

52 tasks

Conversation

keisyrzk commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

rezkiy37 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 17, 2023

Uh oh!

parasharrajat commented Nov 17, 2023

Uh oh!

parasharrajat commented Nov 17, 2023

Uh oh!

Uh oh!

Uh oh!

ntdiary commented Nov 17, 2023

Uh oh!

ntdiary commented Nov 17, 2023

Uh oh!

keisyrzk commented Nov 29, 2023

Uh oh!

ntdiary commented Nov 30, 2023

Uh oh!

keisyrzk commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntdiary commented Dec 1, 2023

Uh oh!

Uh oh!

keisyrzk commented Dec 1, 2023

Uh oh!

ntdiary left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keisyrzk commented Dec 4, 2023

Uh oh!

ntdiary commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ntdiary left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 4, 2023

Uh oh!

OSBotify commented Dec 5, 2023

Uh oh!

OSBotify commented Dec 5, 2023

Uh oh!

OSBotify commented Dec 6, 2023

Uh oh!

OSBotify commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

keisyrzk commented Nov 16, 2023 •

edited

Loading

keisyrzk commented Dec 1, 2023 •

edited

Loading

ntdiary commented Dec 4, 2023 •

edited

Loading