Fix: Undefined displayed in header when opening left thread in offline mode by tienifr · Pull Request #32331 · Expensify/App

tienifr · 2023-12-01T07:10:28Z

Details

Leave thread and rejoin it in offline mode leads to undefined shown in thread header. This PR fixes that.

Fixed Issues

$ #28997
PROPOSAL: #28997 (comment)

Tests

Start a thread and send some messages
Go offline
Leave thread
Open thread
Verify skeleton shows in thread body and title shows in thread header

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Start a thread and send some messages
Go offline
Leave thread
Open thread
Verify skeleton shows in thread body and title shows in thread header

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-01.at.14.28.15-compressed.mov

Android: mWeb Chrome

Screen.Recording.2023-12-01.at.14.30.11-compressed.mov

iOS: Native

Screen.Recording.2023-12-01.at.14.21.20-compressed.mov

iOS: mWeb Safari

Screen.Recording.2023-12-01.at.14.18.52-compressed.mov

MacOS: Chrome / Safari

Untitled.mov

MacOS: Desktop

Screen.Recording.2023-12-01.at.14.17.17-compressed.mov

melvin-bot · 2023-12-01T07:31:20Z

@shawnborton @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-12-01T14:17:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

32331.Android.mp4

Android: mWeb Chrome

32331.mWeb-Android.mp4

iOS: Native

32331.iOS.mp4

iOS: mWeb Safari

32331.mWeb-Safari.mp4

MacOS: Chrome / Safari

32331.Web.mp4

MacOS: Desktop

32331.Desktop.mp4

mollfpr

Looks good. Just some question to clarify.

mollfpr · 2023-12-02T04:01:31Z

 */
 function shouldReportShowSubscript(report: OnyxEntry<Report>): boolean {
-    if (isArchivedRoom(report)) {
+    if (isArchivedRoom(report) && !isWorkspaceThread(report)) {


Could explain why we need to add check here?

@tienifr Can you answer this question? Since I am about to fix isWorkspaceThread function.

mollfpr · 2023-12-02T04:18:23Z

+                      parentReportID: report.parentReportID,
+                      parentReportActionID: report.parentReportActionID,
+                      policyID: report.policyID,
+                      type: report.type,


Why do we need to retain the value policy?

tienifr · 2023-12-05T12:26:17Z

@mollfpr I have left this comment above but there's a confusing Pending status so I posted here again to make sure you can see it:

mollfpr

LGTM 👍

OSBotify · 2023-12-06T20:03:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-06T22:18:34Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T23:12:45Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T01:09:52Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr · 2023-12-13T16:00:06Z

@shubham1206agra I have already replied here #32331 (comment).

tienifr added 4 commits October 6, 2023 20:19

fix: 28969

197dcc3

Merge branch 'main' into fix/28997

0e0898f

fix: Undefined displayed in header offline when opening left thread

001aae3

Merge branch 'main' of https://github.com/tienifr/App into fix/28997

082d31d

tienifr marked this pull request as ready for review December 1, 2023 07:31

tienifr requested a review from a team as a code owner December 1, 2023 07:31

melvin-bot bot requested review from mollfpr and shawnborton and removed request for a team December 1, 2023 07:31

tienifr mentioned this pull request Dec 1, 2023

[HOLD for payment 2023-12-15] [$500]Thread - Undefined displayed in header offline when opening left thread #28997

Closed

6 tasks

tienifr added 2 commits December 1, 2023 16:58

Merge branch 'main' of https://github.com/tienifr/App into fix/28997

3510952

fix avatar for workspace thread

baf668f

shawnborton approved these changes Dec 1, 2023

View reviewed changes

mollfpr reviewed Dec 2, 2023

View reviewed changes

mollfpr approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch December 6, 2023 15:11

nkuoch approved these changes Dec 6, 2023

View reviewed changes

nkuoch merged commit 2e8cfdb into Expensify:main Dec 6, 2023

github-actions bot mentioned this pull request Dec 6, 2023

Deploy Checklist: New Expensify 2023-12-06 #32589

Closed

74 tasks

lanitochka17 mentioned this pull request Dec 7, 2023

[$500] Thread - Title in thread is not shown when leaving and revisiting thread offline #32659

Closed

6 tasks

Conversation

tienifr commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 1, 2023

Uh oh!

mollfpr commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr Dec 2, 2023

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr Dec 2, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr commented Dec 5, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 6, 2023

Uh oh!

OSBotify commented Dec 6, 2023

Uh oh!

OSBotify commented Dec 6, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

tienifr commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tienifr commented Dec 1, 2023 •

edited

Loading

mollfpr commented Dec 1, 2023 •

edited

Loading