fix: add flags emojis support for Windows#32396
Merged
puneetlath merged 1 commit intoExpensify:mainfrom Dec 4, 2023
Merged
Conversation
6 tasks
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-03.at.7.06.58.PM.movAndroid: mWeb ChromeflagsAndroidmWebChrome.moviOS: NativeflagsiOSNative.moviOS: mWeb SafariflagsiOSSafari.movWindows: ChromeemojisWebWindows.mp4MacOS: DesktopflagsDesktop.mov |
puneetlath
approved these changes
Dec 4, 2023
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
66 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.8-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add flags emoji support for Windows
Fixed Issues
$ #31717
PROPOSAL: #31717 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
31717_android_native.mp4
Android: mWeb Chrome
31717_android_chrome.mp4
iOS: Native
31717_ios_native.mp4
iOS: mWeb Safari
31717_ios_safari.mp4
Windows Chrome
31717_windows_chrome.mp4
MacOS: Desktop
31717_mac_desktop.mp4