[TS migration] Migrate 'ReportActionItemTaskAction.js' component to TypeScript by VickyStash · Pull Request #32560 · Expensify/App

VickyStash · 2023-12-06T12:04:29Z

Details

[TS migration] Migrate 'ReportActionItemTaskAction.js' component to TypeScript

Fixed Issues

$ #31941
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open any task.
Mark it as complete and incomplete after that.
Make sure task actions messages (ex: marked as complete) look as expected

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Open any task.
Mark it as complete and incomplete after that.
Make sure task actions messages (ex: marked as complete) look as expected

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-08T10:22:06Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…onent # Conflicts: # src/components/ReportActionItem/TaskAction.js

getusha · 2023-12-12T15:37:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

getusha · 2023-12-12T15:40:08Z

src/components/ReportActionItem/TaskAction.tsx

+
+type TaskActionProps = {
+    /** Name of the reportAction action */
+    actionName: string;


i notice we are passing a value to taskReportID for this component, should we add it in this prop type?

@getusha I think taskReportID is not used anymore in this component

@VickyStash i noticed this comment above taskReportID in proptypes
// eslint-disable-next-line react/no-unused-prop-types -- This is used in the withOnyx HOC, so you're saying it is not used anymore in withOnyx HOC?

@getusha This component doesn't have withOnyx HOC where taskReportID was used, it was removed some time ago.

After some time taskReportID was also used in another place, but it also was updated

Could we remove this if that's the case, it is kind of confusing.

App/src/pages/home/report/ReportActionItem.js

Line 363 in 7f7cfb3

taskReportID={props.action.originalMessage.taskReportID.toString()}

@getusha Done!

getusha

LGTM

melvin-bot · 2023-12-13T10:35:35Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31941 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…onent # Conflicts: # src/components/ReportActionItem/TaskAction.js

OSBotify · 2023-12-14T19:03:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:43:21Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:46:42Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:14:17Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'ReportActionItemTaskAction.js' component

f89cc5b

fabioh8010 approved these changes Dec 7, 2023

View reviewed changes

blazejkustra approved these changes Dec 8, 2023

View reviewed changes

VickyStash marked this pull request as ready for review December 8, 2023 10:22

VickyStash requested a review from a team as a code owner December 8, 2023 10:22

melvin-bot bot requested review from getusha and removed request for a team December 8, 2023 10:22

VickyStash added 2 commits December 11, 2023 09:18

Merge branch 'main' into ts-migration/reportActionItemTaskAction-comp…

d18fe1f

…onent # Conflicts: # src/components/ReportActionItem/TaskAction.js

Updates to follow main branch

3c7e77a

getusha reviewed Dec 12, 2023

View reviewed changes

Remove unnecessary taskReportID prop

e486816

getusha approved these changes Dec 13, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam December 13, 2023 10:35

VickyStash added 2 commits December 14, 2023 08:38

Merge branch 'main' into ts-migration/reportActionItemTaskAction-comp…

16aeb28

…onent # Conflicts: # src/components/ReportActionItem/TaskAction.js

Update useThemeStyles hook import to follow main branch updates

3d2e50f

getusha approved these changes Dec 14, 2023

View reviewed changes

thienlnam approved these changes Dec 14, 2023

View reviewed changes

thienlnam merged commit 17c1ea8 into Expensify:main Dec 14, 2023

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[HOLD for payment 2023-12-28] [$500] [TS migration] Migrate 'ReportActionItemTaskAction.js' component to TypeScript #31941

Closed

Conversation

VickyStash commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 8, 2023

Uh oh!

getusha commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

VickyStash Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

getusha Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

VickyStash Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

VickyStash Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

getusha Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

VickyStash Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 19, 2023

Uh oh!

OSBotify commented Dec 19, 2023

Uh oh!

OSBotify commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VickyStash commented Dec 6, 2023 •

edited

Loading

getusha commented Dec 12, 2023 •

edited

Loading