Skip to content

Fix the favicon by using the generic path to this component#328

Merged
stitesExpensify merged 1 commit intomasterfrom
tgolen-fix-favicon
Aug 28, 2020
Merged

Fix the favicon by using the generic path to this component#328
stitesExpensify merged 1 commit intomasterfrom
tgolen-fix-favicon

Conversation

@tgolen
Copy link
Copy Markdown
Contributor

@tgolen tgolen commented Aug 28, 2020

Tests

  1. Have two users (A and B)
  2. User A is signed into the chat app on web
  3. User B is signed into a different chat app (like on mobile)
  4. Have user B (from mobile) comment on a report that User A has access to
  5. Verify that for User A, the favicon updates to be a brighter color (the tab title will change too)

@tgolen tgolen requested a review from sketchydroide August 28, 2020 18:03
@tgolen tgolen self-assigned this Aug 28, 2020
@tgolen tgolen requested review from bondydaa and stitesExpensify and removed request for bondydaa and sketchydroide August 28, 2020 19:14
@stitesExpensify
Copy link
Copy Markdown
Contributor

LGTM. Only thing I noticed while testing was that the (NEW!) never goes away in the title but that isn't really part of this fix

@stitesExpensify stitesExpensify merged commit 45ca8c2 into master Aug 28, 2020
@stitesExpensify stitesExpensify deleted the tgolen-fix-favicon branch August 28, 2020 20:18
@tgolen
Copy link
Copy Markdown
Contributor Author

tgolen commented Aug 28, 2020

That's strange... it should. Maybe I'll have a closer look at that (or you could dig into it too if you are interested).

mountiny pushed a commit that referenced this pull request Apr 24, 2026
…te-after-dismiss-rhp

Tab nav/fix navigate after dismiss rhp
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.3.62-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This is a one-line internal code fix that corrects an import path (PageTitleUpdater/index.nativePageTitleUpdater) to resolve a favicon update issue. It does not change any user-facing features, settings, workflows, or terminology that would need to be reflected in the help site documentation under docs/articles.

@mountiny
Copy link
Copy Markdown
Contributor

Fake news

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@arosiclair arosiclair mentioned this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants