[TS migration] Migrate 'IOU.js' lib to TypeScript by VickyStash · Pull Request #34092 · Expensify/App

VickyStash · 2024-01-08T09:45:27Z

Details

[TS migration] Migrate 'IOU.js' lib to TypeScript

Fixed Issues

$ #24926
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Make sure the Money Request / Split bill functionality works the same way as before. You can use next flows to test it.

First flows: Using FAB button

Manual Money Request

Press FAB button -> Request Money
Select Manual money request
Try to update the currency and change it back
Enter value -> Press next
Select a user to split request with
Update description/merchant/date and press Request button.
Make sure a request is successfully created and open it.
Update description/merchant/date again
In the top right corner, tap on the three dots menu -> Add receipt
Attach any photo of a receipt
Tap on the attached receipt -> menu in the top right corner
Test that receipt Replace and Delete works as expected.
Delete created Money Request.

Scan Money Request

Press FAB button -> Request Money
Select Scan money request
Select a photo of any receipt
Select a user to split request with
Press request button
Make sure a money request with scanning in progress is created
Open it and update the description.
Check it later to see scanned results.

Distance Money Request

Press FAB button -> Request Money
Select Distance money request
Select start and finish locations, press next
Select a workspace to share request with
Update description/category
Press request button
Make sure a distance money request is created, open it
Try to update distance points, make sure the request is updated as well
Update description/date/category
Delete the created Money Request.

Second flows: Chat with another user:

Manual Money Request

Open any chat with another user -> Press the plus button in the input
Request Money -> Select Manual money request
Try to update the currency and change it back
Enter value -> Press next
Update amount/description/merchant/date and press Request button.
Make sure the request is successfully created and open it.
Update description/merchant/date again
Delete created Money Request.

Scan Money Request

Open any chat with another user -> Press the plus button in the input
Request Money -> Select Scan money request
Select a photo of any receipt
Press request button
Make sure a money request with scanning in progress is created
Open it and update the description.
Check it later to see scanned results.

Third flows: Workspace chat

Split bill -> Manual

Open any workspace chat-> Press the plus button in the input
Split bill -> Select Manual option
Try to update the currency and change it back
Enter value -> Press next
Add merchant/description, update date, and press Split button.
Make sure the split is created successfully, open it, and check the details.

Split bill -> Scan

Open any workspace chat-> Press the plus button in the input
Split bill -> Select Scan option
Select a photo of any receipt
Add category/description and press Split button.
Make sure the split is created successfully, open it, and check the details (the merchant field can be missed, but it should be populated when scanning is finished)
Check it later to see scanned results.

Split bill -> Distance

Open any workspace chat-> Press the plus button in the input
Split bill -> Select the Distance option
Select start and finish locations, press next
Update the description/category and press Split button
Make sure the split is created successfully, open it, and check the details

Money Request-> Manual

Open any workspace chat-> Press the plus button in the input
Request Money -> Select Manual money request
Enter value -> Press next
Update amount/description/merchant/date/category and press Request button.
Make sure the request is successfully created and open it.
Update description/merchant/date/category again
Delete created Money Request.

Money Request -> Scan

Open any workspace chat-> Press the plus button in the input
Request Money -> Select Scan money request
Select a photo of any receipt
Press request button
Make sure a money request with scanning in progress is created
Open it and update the description.
Check it later to see scanned results.

Money Request -> Distance

Open any workspace chat-> Press the plus button in the input
Request Money -> Select Distance money request
Select start and finish locations, press next
Update description/category
Press request button
Make sure a distance money request is created, open it
Try to update distance points, make sure the request is updated as well
Update description/date/category
Delete the created Money Request.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android_iou1.mp4

Android: mWeb Chrome

android_web_iou1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

…nfo functions

# Conflicts: # src/libs/ReportUtils.ts

…pantsFromReport functions

…ipt functions

# Conflicts: # src/libs/IOUUtils.ts # src/libs/ReportUtils.ts # src/libs/TransactionUtils.ts # src/libs/actions/IOU.ts # src/types/onyx/Transaction.ts # src/types/onyx/index.ts

…st, updateMoneyRequestAmountAndCurrency functions

# Conflicts: # src/libs/actions/IOU.ts

# Conflicts: # src/ONYXKEYS.ts # src/components/OfflineWithFeedback.tsx # src/libs/actions/IOU.ts # src/types/onyx/Transaction.ts

VickyStash · 2024-02-03T11:32:06Z

@aimane-chnaif @roryabraham Conflicts are resolved! 🙂

aimane-chnaif · 2024-02-04T14:53:07Z

    payeeAccountID = userAccountID,
    payeeEmail = currentUserEmail,


These 2 params don't exist on main. Not sure why git diff doesn't indicate that.

oh ok, so you changed order of theses params

aimane-chnaif · 2024-02-04T15:04:40Z

Re-tested all possible cases of money request flow. No issues found.
But let's still be on a look out for any regressions since this is large PR.

@roryabraham all yours for merge

# Conflicts: # src/libs/actions/IOU.ts

VickyStash · 2024-02-05T14:26:05Z

@aimane-chnaif @roryabraham I've resolved comments one more time, let's try to merge it today

aimane-chnaif · 2024-02-05T19:31:10Z

@VickyStash please fix conflict again

aimane-chnaif · 2024-02-05T19:32:13Z

Hope it would be the last one. @roryabraham is ready to merge immediately once fixed

# Conflicts: # src/libs/actions/IOU.ts

OSBotify · 2024-02-05T20:34:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:08:58Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:30:43Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

cristipaval · 2024-02-06T16:37:03Z

@@ -3103,7 +3073,7 @@ function getSendMoneyParams(report, amount, currency, comment, paymentMethodType
            paymentMethodType,
            transactionID: optimisticTransaction.transactionID,
            newIOUReportDetails,
-            createdReportActionID: isNewChat ? optimisticCreatedAction.reportActionID : 0,
+            createdReportActionID: isNewChat ? optimisticCreatedAction.reportActionID : '',


This created a warning on the server, polluting the logs. It should be '0' instead of an empty string, as the server expects an integer. Here's a PR that fixes it

Got it, thank you!

@VickyStash As PR already raised thanks to @cristipaval, can you please co-review #35918?

lanitochka17 · 2024-02-06T18:48:23Z

This PR is failing because of issue #35942

The issue is reproducible in: Android, mWeb, IOS

Bug6369674_1707243456539.az_recorder_20240206_180530.1.mp4

Bug6369674_1707243456496.az_recorder_20240206_175443.1.mp4

aimane-chnaif · 2024-02-06T19:00:58Z

This PR is failing because of issue #35942

The issue is reproducible in: Android, mWeb, IOS

Bug6369674_1707243456539.az_recorder_20240206_180530.1.mp4
Bug6369674_1707243456496.az_recorder_20240206_175443.1.mp4

yes, it's caused by another PR #34564 and the fix is being CPed

OSBotify · 2024-02-07T09:51:07Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ikevin127 · 2025-04-12T19:28:38Z

            const diff = TransactionUtils.getAmount(transaction, true) - TransactionUtils.getAmount(updatedTransaction, true);
-            if (ReportUtils.isExpenseReport(iouReport)) {
+            if (ReportUtils.isExpenseReport(iouReport) && typeof updatedMoneyRequestReport.total === 'number') {


Looks like the number type check here led to the following issue (more details in #59267 (comment)):

[Due for payment 2025-04-14] [$250] Reports - "Pay" button disappears and reappears if editing expense category more than once #59267

which we fixed by changing the check to !Number.isNaN(iouReport.total) && iouReport.total !== undefined, using iouReport.total !== undefined instead of !!iouReport.total because its value can be 0.

VickyStash added 30 commits December 28, 2023 12:16

Migrate Onyx.connect methods to TS

996ee26

Migrate simple functions

b7af44a

Migrate startMoneyRequest_temporaryForRefactor and resetMoneyRequestI…

519852e

…nfo functions

Migrate buildOnyxDataForMoneyRequest function

e5f8cc3

Migrate getMoneyRequestInformation function

98a1e6b

Fix failing Money request

19035e5

Migrate createDistanceRequest and requestMoney functions

ad41a60

Migrate startSplitBill function

578cc50

Merge branch 'main' into ts-migration/iou

7b55077

# Conflicts: # src/libs/ReportUtils.ts

Replace Split type with Participant

8f0418d

Migrate completeSplitBill function

417e173

Merge branch 'main' into ts-migration/iou

6c962b3

Migrate getIOUReportID, navigateToNextPage and setMoneyRequestPartici…

ecdd7dd

…pantsFromReport functions

Migrate approveMoneyRequest, submitReport, detachReceipt, replaceRece…

016c19e

…ipt functions

Migrate createSplitsAndOnyxData function

012cd76

Merge branch 'main' into ts-migration/iou

041bde6

# Conflicts: # src/libs/IOUUtils.ts # src/libs/ReportUtils.ts # src/libs/TransactionUtils.ts # src/libs/actions/IOU.ts # src/types/onyx/Transaction.ts # src/types/onyx/index.ts

Migrate getReceiptError function; fix type imports after merging main

4711e1c

Migrate splitBill and splitBillAndOpenReport functions

372785b

Migrate getUpdateMoneyRequestParams function

4e7fab0

Migrate updateMoneyRequestDate, updateDistanceRequest, editMoneyReque…

cdcb7d5

…st, updateMoneyRequestAmountAndCurrency functions

Migrate setDraftSplitTransaction, editRegularMoneyRequest functions

c71ae90

Migrate getSendMoneyParams function

9aad84a

Migrate deleteMoneyRequest function

6357670

Migrate getPayMoneyRequestParams and payMoneyRequest functions

992fdea

Get rid of lodashGet and underscore usage

6f658cd

Fix TS errors

4c7928b

Merge branch 'main' into ts-migration/iou

490f208

# Conflicts: # src/libs/actions/IOU.ts

TS fixes after merging main

e60ebaa

Lint fixes

36420a7

Minor code improvements

d082cd4

VickyStash added 2 commits February 3, 2024 12:07

Merge branch 'main' into ts-migration/iou

59262ed

# Conflicts: # src/ONYXKEYS.ts # src/components/OfflineWithFeedback.tsx # src/libs/actions/IOU.ts # src/types/onyx/Transaction.ts

Lint fix

c445c5e

VickyStash dismissed roryabraham’s stale review via c445c5e February 3, 2024 11:13

Update comments

de69ae8

aimane-chnaif reviewed Feb 4, 2024

View reviewed changes

VickyStash added 2 commits February 5, 2024 14:32

Merge branch 'main' into ts-migration/iou

a7b8fc1

# Conflicts: # src/libs/actions/IOU.ts

Get rid of removed screen type

88d805d

Merge branch 'main' into ts-migration/iou

5359633

# Conflicts: # src/libs/actions/IOU.ts

roryabraham approved these changes Feb 5, 2024

View reviewed changes

roryabraham merged commit b7a3fca into Expensify:main Feb 5, 2024

github-actions Bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks

cristipaval mentioned this pull request Feb 6, 2024

[CP Staging] Fix warning on the server #35918

Merged

50 tasks

cristipaval reviewed Feb 6, 2024

View reviewed changes

lanitochka17 mentioned this pull request Feb 6, 2024

Split scan - On creating Split scan in WS, shows 0 in preview in mweb , app crashes in android #35942

Closed

6 tasks

lanitochka17 mentioned this pull request Feb 6, 2024

[$500] Workspace - Two different IOUs are created #35961

Closed

6 tasks

melvin-bot Bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-14] [HOLD #24918][TS migration] Migrate 'IOU.js' lib to TypeScript #24926

Closed

blimpich mentioned this pull request Feb 13, 2024

Cancel Payment command (again and again) #34719

Merged

50 tasks

lakchote mentioned this pull request Feb 27, 2024

Web - IOU - There is a delay in sending money #37300

Closed

6 tasks

ikevin127 reviewed Apr 12, 2025

View reviewed changes

		payeeAccountID = userAccountID,
		payeeEmail = currentUserEmail,

Conversation

VickyStash commented Jan 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented Feb 3, 2024

Uh oh!

aimane-chnaif Feb 4, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Feb 4, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Feb 4, 2024

Uh oh!

VickyStash commented Feb 5, 2024

Uh oh!

aimane-chnaif commented Feb 5, 2024

Uh oh!

aimane-chnaif commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

cristipaval Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

lanitochka17 commented Feb 6, 2024

Uh oh!

aimane-chnaif commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

ikevin127 Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

VickyStash commented Jan 8, 2024 •

edited

Loading

aimane-chnaif commented Feb 6, 2024 •

edited

Loading