[No QA][TS migration] Migrate @react-native-firebase/crashlytics mock#35542
Merged
marcochavezf merged 6 commits intoExpensify:mainfrom Feb 7, 2024
Conversation
fabioh8010
reviewed
Feb 1, 2024
Co-authored-by: Fábio Henriques <fabio.lacerda@outlook.com>
VickyStash
reviewed
Feb 2, 2024
Co-authored-by: Viktoryia Kliushun <vikstash@gmail.com>
filip-solecki
approved these changes
Feb 6, 2024
s77rt
suggested changes
Feb 6, 2024
…rashlytics.ts Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
Member
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
s77rt
approved these changes
Feb 7, 2024
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25243 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Member
|
@ruben-rebelo Can you add |
Member
Member
|
The failing perf test is not related to this PR (many PRs have same failing test). @ruben-rebelo Try merge |
marcochavezf
approved these changes
Feb 7, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
77 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.39-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
[TS migration] Migrate *crashlytics.js mock to TypeScript
Fixed Issues
$ #25243
PROPOSAL: N/A
Tests
Verify that no errors appear in the JS console
Run Unit tests works as before
Offline tests
N/A
QA Steps
Same as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/a
Android: mWeb Chrome
N/a
iOS: Native
N/a
iOS: mWeb Safari
N/a
MacOS: Chrome / Safari
N/a
MacOS: Desktop
N/a