Refactor/34411 lhn previews followup name for group chat by koko57 · Pull Request #36591 · Expensify/App

koko57 · 2024-02-15T15:10:39Z

Details

Fixed Issues

$ #34411
PROPOSAL: #34411 (comment)

Tests

Log in on two user accounts on different platforms or different browsers (or browser profiles).
As User A start a group chat with User B and User C, send a message.
Verify that your name is not displayed in the LHN preview.
Open the Search Page, search for the chat (if it's not displayed at the top).
Verify that your name is not displayed in the list item preview.
As User B send a message in this chat.
As User A after receiving the message: verify that User B's name is displayed in the LHN preview.
Open the Search Page, search for the chat (if it's not displayed at the top).
Verify that User B's name is displayed in the list item preview.
Look through the other chat previews if there's no additional lastActorName with a colon before the message.

Verify that no errors appear in the JS console

Offline tests

You can verify steps 1.-4.

QA Steps

Log in on two user accounts on different platforms or different browsers (or browser profiles).
As User A start a group chat with User B and User C, send a message.
Verify that your name is not displayed in the LHN preview.
Open the Search Page, search for the chat (if it's not displayed at the top).
Verify that your name is not displayed in the list item preview.
As User B send a message in this chat.
As User A after receiving the message: verify that User B's name is displayed in the LHN preview.
Open the Search Page, search for the chat (if it's not displayed at the top).
Verify that User B's name is displayed in the list item preview.
Look through the other chat previews if there's no additional lastActorName with colon before the message.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…r-group-chat

koko57 · 2024-02-16T18:14:23Z

@mountiny while I was fixing the issue I've noticed one strange thing - I used the isGroupChat function and it worked for >3 participants (including me) but not for 3. I've found out that we're checking now if the participantAccountIDs array is longer than two, which doesn't make sense bc in this array there's no currentUserID, we have only the ids for the other users.
Is there a chance that I might be wrong and we have cases that the currentUserID is in participantAccountIDs array? I.e. for the chats migrated from the OD?

I changed it to check for more than 1 and now it works.

Before my changes, this function was used in two locations and for the same purpose - to get the report's name either with getGroupChatName method or getReportName. For 3 participants (owner + 2 other users) isGroupChat was false

but the title was still created properly thanks to this logic in getReportName

App/src/libs/ReportUtils.ts

Lines 2553 to 2557 in 79ce049

    
           const participantAccountIDs = report?.participantAccountIDs ?? []; 
        
           const participantsWithoutCurrentUser = participantAccountIDs.filter((accountID) => accountID !== currentUserAccountID); 
        
           const isMultipleParticipantReport = participantsWithoutCurrentUser.length > 1; 
        
           return participantsWithoutCurrentUser.map((accountID) => getDisplayNameForParticipant(accountID, isMultipleParticipantReport)).join(', ');

. After changing the condition in isGroupChat the title is created the same way but with getGroupChatName. So it should not introduce any regressions.

If we really don't have any case of currentUserID in the participantAccountIDs I think we can also get rid of this filtering here:

App/src/libs/ReportUtils.ts

Line 2554 in 79ce049

    
           const participantsWithoutCurrentUser = participantAccountIDs.filter((accountID) => accountID !== currentUserAccountID);

and checking for participants here

App/src/libs/GroupChatUtils.ts

Line 10 in 7fd529b

const isMultipleParticipantReport = participants.length > 1;

seems to be redundant, as we always check if there is more participants before we even call this function. I haven't changed it yet- I wanted to ask you first 🙂

mountiny · 2024-02-19T22:06:31Z

@koko57 thank you very much for raising this.

I believe we went a bit back and forth potentially on if the "owner" or the currentUserID is part of the participants list.

I believe we are going to update how the group chats work, we will be able to identify it much easier:

The Group chat will be identifiable by it’s rNVP type = 'chat’ and rNVP chatType = ‘group’

I think you can update the check to see if there is 1> participants

…r-group-chat

koko57 · 2024-02-20T08:22:26Z

@mountiny thanks! Opening it ready for review then 🙂

melvin-bot · 2024-02-20T08:22:33Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-02-20T18:44:22Z

@mananjadhav what is your ETA for this one?

mananjadhav · 2024-02-21T00:36:59Z

I'll have this reviewed today.

mananjadhav · 2024-02-21T18:04:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mananjadhav · 2024-02-26T18:29:36Z

Picking this now.

mananjadhav · 2024-02-26T20:12:33Z

@mountiny I forgot what's our stance on display name not set. The name prefix will only show if the display name is set right?

koko57 · 2024-02-28T15:10:39Z

@mananjadhav @mountiny are we all set to merge it?

…r-group-chat

mountiny

Thanks!

OSBotify · 2024-03-04T17:40:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:03:08Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:52:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary · 2025-04-23T12:45:56Z

        }

-        result.alternateText = lastMessageText || formattedLogin;
+        result.alternateText = ReportUtils.isGroupChat(report) && lastActorDisplayName ? `${lastActorDisplayName}: ${lastMessageText}` : lastMessageText || formattedLogin;


The last actor's name was displayed before the archive reason message, we removed it in issue #58938.

koko57 added 2 commits February 12, 2024 14:02

fix: display actor name for group chat

ced292a

Merge branch 'main' into refactor/34411-lhn-previews-followup-name-fo…

9762e8d

…r-group-chat

koko57 mentioned this pull request Feb 15, 2024

[HOLD for payment 2024-03-13] [MEDIUM] Follow-ups to the LHN previews #34411

Closed

6 tasks

koko57 added 3 commits February 16, 2024 15:44

Merge branch 'main' into refactor/34411-lhn-previews-followup-name-fo…

27813a9

…r-group-chat

fix: display actor name only for group chats

9e9a13e

fix: change the condition for group chats

1ec1ad3

mountiny assigned koko57 Feb 19, 2024

Merge branch 'main' into refactor/34411-lhn-previews-followup-name-fo…

392e879

…r-group-chat

koko57 marked this pull request as ready for review February 20, 2024 08:22

koko57 requested a review from a team as a code owner February 20, 2024 08:22

melvin-bot bot requested review from mananjadhav and removed request for a team February 20, 2024 08:22

mananjadhav approved these changes Feb 26, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny February 26, 2024 20:28

Merge branch 'main' into refactor/34411-lhn-previews-followup-name-fo…

0448509

…r-group-chat

mountiny approved these changes Mar 4, 2024

View reviewed changes

mountiny merged commit af8ef4c into Expensify:main Mar 4, 2024

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

ntdiary reviewed Apr 23, 2025

View reviewed changes

Conversation

koko57 commented Feb 15, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

koko57 commented Feb 16, 2024

Uh oh!

mountiny commented Feb 19, 2024

Uh oh!

koko57 commented Feb 20, 2024

Uh oh!

melvin-bot bot commented Feb 20, 2024

Uh oh!

mountiny commented Feb 20, 2024

Uh oh!

mananjadhav commented Feb 21, 2024

Uh oh!

mananjadhav commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Feb 26, 2024

Uh oh!

mananjadhav commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koko57 commented Feb 28, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

ntdiary Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

koko57 commented Feb 15, 2024 •

edited by github-actions bot

Loading

mananjadhav commented Feb 21, 2024 •

edited

Loading

mananjadhav commented Feb 26, 2024 •

edited

Loading