Request location only when necessary in MapView by esh-g · Pull Request #36761 · Expensify/App

esh-g · 2024-02-17T14:56:37Z

Details

Fixed Issues

$ #36491
PROPOSAL: #36491 (comment)

Tests

Make sure the location permission is unset and app is allowed to ask permission.
Click on '+' -> 'request money' -> 'distance tab'
Notice that we are prompted for location permission
Dismiss it without granting and continue after entering miscellaneous waypoints.
Make sure we are not prompted for location on the next page.
After creating request, try to edit distance
Make sure we are not prompted for location permission.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Make sure the location permission is unset and app is allowed to ask permission.
Click on '+' -> 'request money' -> 'distance tab'
Notice that we are prompted for location permission
Dismiss it without granting and continue after entering miscellaneous waypoints.
Make sure we are not prompted for location on the next page.
After creating request, try to edit distance
Make sure we are not prompted for location permission.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-19.at.9.29.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-19.at.9.36.15.PM.mov

iOS: Native

Screen.Recording.2024-02-19.at.9.54.35.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-19.at.9.41.18.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-17.at.8.17.27.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-19.at.10.03.28.PM.mov

melvin-bot · 2024-02-17T14:56:41Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-02-17T15:59:53Z

+                if (!shouldPanMapToCurrentPosition()) {
+                    setCurrentPositionToInitialState();
+                    return;
+                }
+


Why don't we just return early?

@s77rt It is because currentPosition needs to bet set so that pending view is not displayed.

App/src/components/MapView/MapView.tsx

Line 145 in 6f3d8f6

{!isOffline && Boolean(accessToken) && Boolean(currentPosition) ? (

s77rt · 2024-02-18T20:03:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

s77rt · 2024-02-18T20:04:02Z

Please add missing screenshots / videos

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

esh-g · 2024-02-19T16:39:10Z

@s77rt Added all the videos! Sorry for the delay.. Android simulator was (and still is) having issues

github-actions · 2024-02-20T14:06:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36761/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36761/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36761/NewExpensify.dmg	https://36761.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

s77rt · 2024-02-20T15:33:17Z

@esh-g Can you please check #36761 (comment)

esh-g · 2024-02-20T16:34:10Z

@esh-g Can you please check #36761 (comment)

@s77rt Replied!

esh-g · 2024-02-20T16:49:52Z

Made the change @s77rt!

s77rt · 2024-02-20T16:54:29Z

@esh-g Please run prettier (lint failing)

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

OSBotify · 2024-02-20T20:08:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:08:23Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:56:59Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Request location only when necessary in MapView

6fb17e7

esh-g requested a review from a team as a code owner February 17, 2024 14:56

melvin-bot bot removed the request for review from a team February 17, 2024 14:56

melvin-bot bot requested a review from s77rt February 17, 2024 14:56

Fix lint

d1725f4

esh-g mentioned this pull request Feb 17, 2024

[$500] IOU - In distance request confirmation page, location access permission box is shown. #36491

Closed

6 tasks

s77rt suggested changes Feb 17, 2024

View reviewed changes

Fix lint

6c1924a

s77rt suggested changes Feb 18, 2024

View reviewed changes

Comment thread src/components/MapView/MapView.tsx Outdated

Comment thread src/components/MapView/MapView.tsx Outdated

Update src/components/MapView/MapView.tsx

59cb60b

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

Julesssss added the Ready To Build label Feb 20, 2024

This comment was marked as outdated.

Sign in to view

esh-g added 2 commits February 20, 2024 22:09

Remove unecessary dependency

1faec43

Rename current position

fde1898

Prettify 💫

75a173f

s77rt suggested changes Feb 20, 2024

View reviewed changes

Comment thread src/components/MapView/MapView.tsx Outdated

Update src/components/MapView/MapView.tsx

b2f2dac

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt approved these changes Feb 20, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian February 20, 2024 17:12

chiragsalian approved these changes Feb 20, 2024

View reviewed changes

chiragsalian merged commit e74f357 into Expensify:main Feb 20, 2024

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Conversation

esh-g commented Feb 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 17, 2024

Uh oh!

s77rt Feb 17, 2024

Choose a reason for hiding this comment

Uh oh!

esh-g Feb 18, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

s77rt commented Feb 18, 2024

Uh oh!

esh-g commented Feb 19, 2024

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Feb 20, 2024

Uh oh!

s77rt commented Feb 20, 2024

Uh oh!

esh-g commented Feb 20, 2024

Uh oh!

esh-g commented Feb 20, 2024

Uh oh!

s77rt commented Feb 20, 2024

Uh oh!

Uh oh!

OSBotify commented Feb 20, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

esh-g commented Feb 17, 2024 •

edited

Loading

s77rt commented Feb 18, 2024 •

edited

Loading