FIx downloading video crash by shahinyan11 · Pull Request #37122 · Expensify/App

shahinyan11 · 2024-02-23T07:11:26Z

Details

Fixed Issues

$ #36833
PROPOSAL: #36833 (comment)

Tests

Launch New Expensify app.
Go to any chat.
Upload a video.
Tap 3-dot menu and make sure there is no Download action.

Verify that no errors appear in the JS console

Offline tests

Same as in the Tests section.

QA Steps

Same as in the Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-28.at.13.28.39.mov

Android: mWeb Chrome

Screenrecorder-2024-02-28-15-33-39-773.mp4

iOS: Native

Screen.Recording.2024-02-28.at.13.49.46.mov

iOS: mWeb Safari

Screen.Recording.2024-02-28.at.14.13.49.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-28.at.14.09.18.mov

MacOS: Desktop

Screen.Recording.2024-02-28.at.14.06.08.mov

melvin-bot · 2024-02-23T07:11:30Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shahinyan11 · 2024-02-23T12:46:21Z

@francoisl We have another error which reproducible only for native platforms. The problem becomes from here.
On IOS the Url.getPathFromURL function gets file:///Users/... as param and returns Users/... which causes the download to fail here.
And on Android It does not work at all. It gets data/user/0/com.expensify.chat.dev/... and returns '' which causes the download to fail here.

Here we should use original status.uri for IOS and file://${status.uri} for Android instead sourceURI.

eVoloshchak · 2024-02-23T19:49:45Z

@francoisl, I don't have access to this doc, but according to the discussion here, besides adding a Ready To Build label you have to manually start the build

https://stackoverflowteams.com/c/expensify/questions/15778/15779

francoisl · 2024-02-23T20:49:41Z

Yes I did, it just takes a while to build :) Anyway, it's built now except for ~~iOS~~desktop, I'll restart it manually.

github-actions · 2024-02-23T20:59:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37122/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/37122/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37122/NewExpensify.dmg	https://37122.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

francoisl · 2024-02-23T23:06:33Z

At step 4 of the test, what gets downloaded for me is just a HTML page, is this due to the same issue you were referring to in this comment?

Screen.Recording.2024-02-23.at.3.03.11.PM.mov

eVoloshchak · 2024-02-23T23:36:08Z

I'm seeing "Attachment cannot be downloaded" error on iOS (simulator)

Screen.Recording.2024-02-24.at.00.32.27.mov

Weirdly, on a physical device even with current prod (without the fix from this PR), video preview is not displayed. Was this discussed and is this by design?

RPReplay_Final1708731177.MP4

eVoloshchak · 2024-02-23T23:39:06Z

Also, could you please upload the missing videos for iOS/Android (native)?

francoisl · 2024-02-24T00:28:44Z

video preview is not displayed. Was this discussed and is this by design?

Yes, at the moment on production, videos are still treated as regular file attachments. We just deployed the video player feature to staging.

eVoloshchak · 2024-02-24T01:25:09Z

Yes, at the moment on production, videos are still treated as regular file attachments. We just deployed the video player feature to staging

Ah, I see, thank you @francoisl!

The "Attachment cannot be downloaded" error is still present on a physical device

RPReplay_Final1708737731.MP4

shahinyan11 · 2024-02-24T06:24:32Z

@eVoloshchak @francoisl didn't you notice my comment ?

eVoloshchak · 2024-02-26T01:12:51Z

Ah, I see now!
Let's fix those two issues too, we definitely should get the whole download flow working

shahinyan11 · 2024-02-26T12:14:09Z

Ah, I see now! Let's fix those two issues too, we definitely should get the whole download flow working

@eVoloshchak It seems this PR will fix the problem with urls. We need hold current PR on that one

francoisl · 2024-02-26T18:02:42Z

That PR you linked is merged. I tested again and pulled main into your branch locally, by default the proposed filename for download doesn't have an extension, do you see a way to fix that?

github-actions · 2024-02-26T20:12:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37122/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37122/NewExpensify.dmg	https://37122.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shahinyan11 · 2024-02-26T22:40:17Z

That PR you linked is merged. I tested again and pulled main into your branch locally, by default the proposed filename for download doesn't have an extension, do you see a way to fix that?

Currently no. This needs to be explored further . But if it's a bug, it should be fixed in that PR because it was opened specifically to fix uploaded files.

francoisl · 2024-02-29T19:41:08Z

@eVoloshchak can you complete the checklist please?

eVoloshchak · 2024-03-04T16:13:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eVoloshchak

LGTM!

OSBotify · 2024-03-04T21:03:47Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:52:49Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2024-03-14T14:43:35Z

+    useEffect(() => {
+        currentVideoPlayerRef.current = videoPlayerRef.current;
+    }, [url, currentVideoPlayerRef]);


This change caused another crash.
ref: #37710 (comment)

But here #37710 (comment) you yourself wrote that the crash came from combination of multiple video player PRs.

yes, but I am commenting here since it's directly related.
I just suggested in the linked issue not affect payment.

I got it. Thank you

FIx downloading video crash

0dad1e2

melvin-bot bot removed the request for review from a team February 23, 2024 07:11

melvin-bot bot requested a review from eVoloshchak February 23, 2024 07:11

Fix lint error

1f76442

francoisl added the Ready To Build label Feb 23, 2024

This comment has been minimized.

Sign in to view

Shahe Shahinyan added 3 commits February 28, 2024 11:43

Pull last main

1498767

Hide download button for local files

84e44aa

Fix lint error

21765c1

francoisl reviewed Feb 29, 2024

View reviewed changes

Comment thread src/components/VideoPlayerContexts/VideoPopoverMenuContext.js Outdated

Comment thread src/components/VideoPlayerContexts/VideoPopoverMenuContext.js Outdated

Addressed to reviewer comments

f7852ad

eVoloshchak approved these changes Mar 4, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl March 4, 2024 17:39

francoisl approved these changes Mar 4, 2024

View reviewed changes

francoisl merged commit 49cb3b1 into Expensify:main Mar 4, 2024

This was referenced Mar 4, 2024

Investigate workflow job failing on main: typecheck / typecheck #37689

Closed

Investigate workflow job failing on main: confirmPassingBuild #37690

Closed

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

This was referenced Mar 5, 2024

[HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading #37710

Closed

[$500] - LOW - Android - Unexpected error when tapped on 3 dot menu in chat while video attachment is uploading #37633

Closed

melvin-bot bot mentioned this pull request Mar 6, 2024

[PAID] [$500] Video - Two different crashes occur when downloading video #36833

Closed

6 tasks

aimane-chnaif reviewed Mar 14, 2024

View reviewed changes

Conversation

shahinyan11 commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 23, 2024

Uh oh!

shahinyan11 commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak commented Feb 23, 2024

Uh oh!

This comment has been minimized.

francoisl commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2024

Uh oh!

francoisl commented Feb 23, 2024

Uh oh!

eVoloshchak commented Feb 23, 2024

Uh oh!

eVoloshchak commented Feb 23, 2024

Uh oh!

francoisl commented Feb 24, 2024

Uh oh!

eVoloshchak commented Feb 24, 2024

Uh oh!

shahinyan11 commented Feb 24, 2024

Uh oh!

eVoloshchak commented Feb 26, 2024

Uh oh!

shahinyan11 commented Feb 26, 2024

Uh oh!

francoisl commented Feb 26, 2024

Uh oh!

github-actions bot commented Feb 26, 2024

Uh oh!

shahinyan11 commented Feb 26, 2024

Uh oh!

Uh oh!

Uh oh!

francoisl commented Feb 29, 2024

Uh oh!

eVoloshchak commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

aimane-chnaif Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

shahinyan11 Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

shahinyan11 Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

shahinyan11 commented Feb 23, 2024 •

edited

Loading

shahinyan11 commented Feb 23, 2024 •

edited

Loading

francoisl commented Feb 23, 2024 •

edited

Loading

eVoloshchak commented Mar 4, 2024 •

edited

Loading