Track expense/self dm by ishpaul777 · Pull Request #37165 · Expensify/App

ishpaul777 · 2024-02-23T23:31:51Z

Details

Tasks in Scope:

Adding the reportName for this chat 'Your Name (you)'
Removing the option to 'Request/Send Money' from the chat
Preventing this self-dm from showing up in the participant selectors (except tasks)
Disabling the ability to update notification preferences
Removing share code / Members page
Determining how the details page of the self DM will look

Fixed Issues

$ #36361
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Adding the reportName for this chat 'Your Name (you)'

Verify in LHN the name of report is the 'originalDisplayName + (you)
verify in report header name of report is the 'originalDisplayName + (you)
verify in report details name of report is the 'originalDisplayName + (you)

Removing the option to 'Request/Send Money' from the chat

Verify Request/Send/Split money options are not visible in plus options in composer

Preventing this self-dm from showing up in the participant selectors (except tasks)

Verify self dm is only visible for task participants selector. ( it might be visible for other flows but that is only because its not a real selfDM and might in user contact list (we dont need modify any logic because in a actual self Dm will not be a user contact)(this will be better tested with actual DM)

Determining how the details page of the self DM will look.

-Verify it should looks same a 1:1 chat details page except all of the option like message/private notes/notification preference/settings/members should be hidden and their deeplinks should show not found page

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-02.at.6.59.28.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-02.at.6.46.12.AM.mov

iOS: Native

Screen.Recording.2024-03-02.at.6.30.57.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-02.at.6.36.11.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-02.at.6.12.36.AM-1.mov

MacOS: Desktop

Screen.Recording.2024-03-02.at.7.03.06.AM-1.mov

thienlnam · 2024-02-26T18:11:38Z

Thanks for this PR - I did some testing with my account that has a self-DM set up. There's a couple thing I noticed

Screen.Recording.2024-02-26.at.10.08.44.AM.mov

It looks like the reportName doesn't contain (you) after the name
For each comment added, it seems to think there there is another participant added. We may need to also update the addComment flow
Report page & Task seems to work a-okay
Leave button is still in the self-DM

shubham1206agra · 2024-02-28T02:14:53Z

@ishpaul777 Please fix conflicts and address #37165 (comment).

ishpaul777 · 2024-02-29T19:16:43Z

It looks like the reportName doesn't contain (you) after the name

fixed in 5d7a997

For each comment added, it seems to think there there is another participant added. We may need to also update the addComment flow

still have to investigate can't reproduce it with testing workaround but i am lookin into the addComment logic for better understanding

Leave button is still in the self-DM

fixed in c8ae559

ishpaul777 · 2024-02-29T19:18:01Z

@thienlnam do you mind taking a look again 🙇‍♂️

ishpaul777 · 2024-02-29T19:21:25Z

Typescript checks failing is unrelated

ishpaul777 · 2024-02-29T21:17:12Z

        const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(report);
        const isMoneyRequestReport = ReportUtils.isMoneyRequestReport(report);
+        const isSelfDM = ReportUtils.isSelfDM(report);
        const accountIDs = report.visibleChatMemberAccountIDs ?? [];


comment for reference

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

… into trackExpense/selfDM

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

… into trackExpense/selfDM

paultsimura

Looks good and tests well.

paultsimura · 2024-03-02T00:24:40Z

@ishpaul777 please fix lint and we'll be good to go 👍

thienlnam

🚀 Thank you!!

OSBotify · 2024-03-02T00:57:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:03:53Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MonilBhavsar · 2024-03-05T06:51:19Z

    );

-    const canJoinOrLeave = isChatThread || isUserCreatedPolicyRoom || canLeaveRoom;
+    const canJoinOrLeave = isChatThread || !isSelfDM || isUserCreatedPolicyRoom || canLeaveRoom;


Looks like this condition caused regression #37709
@ishpaul777 could you please take a look

OSBotify · 2024-03-06T21:52:55Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

getusha · 2024-03-29T13:13:47Z

We missed a case to update the LHN message for self DM
#38087

ikevin127 · 2025-01-25T01:00:05Z

                <Text style={[styles.textHero]}>{getWelcomeHeroText}</Text>
            </View>
            <View style={[styles.mt3, styles.mw100]}>
+                {isPolicyExpenseChat &&


As a result of this logic, we had a UX issue:

[HOLD for payment 2025-01-24] [$250] IOS - Empty screen seen when navigating back from workspace description the second time #53589

which we decided together with the design team to fix by replacing the pressable component with a view and not navigate anymore.

i think this PR https://github.com/Expensify/App/pull/34150/files#diff-efb29392ed56b170976d93494c7279dba94f19182551d5cca6c4e4e97bc0433f, introduced the Pressable component at first, blame history might be written over by this PR

ishpaul777 and others added 8 commits February 15, 2024 17:23

added v1 changes

500f458

Merge branch 'Expensify:main' into trackExpense/selfDM

07eb0d9

Merge branch 'Expensify:main' into trackExpense/selfDM

7819bc1

clean up and changes v2

376b452

fixes selfDm reportName in LHN

f16a19f

show report in detination for tasks

ad25805

prettier diffs

f6362ad

Merge branch 'Expensify:main' into trackExpense/selfDM

e120e7a

ishpaul777 commented Feb 26, 2024

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

ishpaul777 commented Feb 26, 2024

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

shubham1206agra mentioned this pull request Feb 27, 2024

Track Expense flow #37282

Merged

49 tasks

thienlnam mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-03-13] [$750] CRITICAL: [Track Expense] - FE - Handling for the self-DM #36361

Closed

ishpaul777 added 6 commits March 1, 2024 00:20

Merge branch 'main' into trackExpense/selfDM

ef11187

refactor after merge

8d002ca

prettier

4ac87bb

fixes leave option in header three dots

c8ae559

fix conflicts after merge

9426035

fix postfix for visible for self dm

5d7a997

ishpaul777 commented Feb 29, 2024

View reviewed changes

ishpaul777 added 3 commits March 1, 2024 03:10

fix user-avatar an share destination issue

279592b

remove console log

266cea6

fixes infinite loading when first load

3d4e4c7

ishpaul777 marked this pull request as ready for review February 29, 2024 22:59

ishpaul777 requested a review from a team as a code owner February 29, 2024 22:59

melvin-bot bot removed the request for review from a team February 29, 2024 22:59

ishpaul777 and others added 2 commits March 2, 2024 05:31

fixes you postfix not showing up in profilepage

c0b06bb

fixes comment as per suggestion

c8e1e02

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

paultsimura reviewed Mar 2, 2024

View reviewed changes

Comment thread src/libs/PersonalDetailsUtils.ts Outdated

ishpaul777 and others added 8 commits March 2, 2024 05:40

formatting

c812725

Merge branch 'trackExpense/selfDM' of https://github.com/ishpaul777/App…

acfdae8

… into trackExpense/selfDM

revert back changes

db38f3b

Update src/pages/ReportDetailsPage.tsx

68a348f

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

Update src/pages/home/HeaderView.js

5d167b0

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

Update src/libs/OptionsListUtils.ts

a67cbc8

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

fixes review comment

80a0e44

Merge branch 'trackExpense/selfDM' of https://github.com/ishpaul777/App…

ac5030f

… into trackExpense/selfDM

paultsimura approved these changes Mar 2, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek March 2, 2024 00:23

ishpaul777 added 2 commits March 2, 2024 05:56

lint fix

a4d858f

add comment for workaround

5cfb38d

thienlnam approved these changes Mar 2, 2024

View reviewed changes

thienlnam merged commit cbd13ed into Expensify:main Mar 2, 2024

thienlnam mentioned this pull request Mar 2, 2024

fixes report not showing in search #37653

Merged

50 tasks

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

nkdengineer mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat #37709

Closed

6 tasks

MonilBhavsar reviewed Mar 5, 2024

View reviewed changes

nkdengineer mentioned this pull request Mar 25, 2024

[HOLD for payment 2024-04-15] [$500] Self - DM - App returns to previous conversation instead of self-DM after leaving self-DM thread #38689

Closed

6 tasks

getusha mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-03-29] [$500] [Polish] Web - LHN - "This is the beginning of your chat" message can be seen for "Your space" #38087

Closed

6 tasks

TMisiukiewicz mentioned this pull request Apr 3, 2024

perf: Cache search options #38207

Merged

50 tasks

ikevin127 reviewed Jan 25, 2025

View reviewed changes

Conversation

ishpaul777 commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Adding the reportName for this chat 'Your Name (you)'

Removing the option to 'Request/Send Money' from the chat

Preventing this self-dm from showing up in the participant selectors (except tasks)

Determining how the details page of the self DM will look.

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

thienlnam commented Feb 26, 2024

Uh oh!

shubham1206agra commented Feb 28, 2024

Uh oh!

ishpaul777 commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Feb 29, 2024

Uh oh!

ishpaul777 commented Feb 29, 2024

Uh oh!

ishpaul777 Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

paultsimura commented Mar 2, 2024

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 2, 2024

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

MonilBhavsar Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

getusha commented Mar 29, 2024

Uh oh!

ikevin127 Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ishpaul777 commented Feb 23, 2024 •

edited

Loading

ishpaul777 commented Feb 29, 2024 •

edited

Loading