feat: category settings page by ArekChr · Pull Request #37209 · Expensify/App

ArekChr · 2024-02-26T15:24:01Z

Details

Fixed Issues

#35708
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open categories with a paid policy as an admin.
Go to workspace settings and open any category (details).
Enable or disable the category.
Confirm the category's enabled status has been updated.
Refresh the page.
Verify the category's status remains unchanged.

Offline tests

Open categories with a paid policy as an admin.
Go to workspace settings and open any category (details).
Turn off the network.
Enable or disable the category.
Confirm that the category's enabled status has changed and the option row is grayed out.
Turn on the network.
Verify that the pending action has disappeared.

QA Steps

Same as tests

Verify that no errors appear in the JS console
rest steps the same as above for test and offline

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

web.chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

web.safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ic data

…settings and categories settings

melvin-bot · 2024-02-29T13:24:16Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2024-02-29T13:25:14Z

Also added a fix for the CategoriesSettingsPage: the offline indicator now correctly appears at the bottom of the screen on mobile devices.

ArekChr · 2024-02-29T13:32:33Z

I'm wondering about page naming, to change from CategorySettingsPage to CategoryDetailsPage WDYT? 🧐

ArekChr · 2024-02-29T14:15:38Z

+                        [SCREENS.WORKSPACE.CATEGORY_SETTINGS]: {
+                            path: ROUTES.WORKSPACE_CATEGORY_SETTINGS.route,
+                            parse: {
+                                categoryName: (categoryName: string) => decodeURI(categoryName),


Regarding to checklist, It appears that this is a new pattern. Previously, parsing and linking were not utilized in this manner, In my opinion, it would be more effective to decode the category name before passing it to the route props.

@luacmartins ☝️ any thoughts ?

If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

ArekChr · 2024-02-29T14:31:43Z

If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

Do we need a scroll view on this page?

ishpaul777 · 2024-02-29T14:54:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.9.25.06.PM-1.mov

Screen.Recording.2024-02-29.at.9.27.09.PM-1.mov

Android: mWeb Chrome

Screen.Recording.2024-02-29.at.10.09.27.PM.mov

iOS: Native

Screen.Recording.2024-02-29.at.10.24.16.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.11.08.57.PM-1.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.9.06.38.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-29.at.11.50.39.PM.mov

Screen.Recording.2024-02-29.at.11.49.49.PM.mov

ishpaul777 · 2024-02-29T15:49:04Z

when deeplinking to category settings of unknown category the background screen is not category page

Screen.Recording.2024-02-29.at.9.17.49.PM.mov

ishpaul777 · 2024-02-29T15:51:12Z

@ArekChr how do you simulate a error while updating a category setting ?

luacmartins

Modal doesn't have < next to title

luacmartins · 2024-02-29T17:26:50Z

@Expensify/design

luacmartins

LGTM and tests well!

ishpaul777

LGTM

melvin-bot · 2024-03-01T15:02:38Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-01T15:04:42Z

Tests passed, but there's a GH incident for actions right now, which probably borked something on GH side:

OSBotify · 2024-03-01T15:42:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:04:08Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:53:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 · 2024-03-19T06:18:29Z

    },
+    WORKSPACE_CATEGORY_SETTINGS: {
+        route: 'workspace/:policyID/categories/:categoryName',
+        getRoute: (policyID: string, categoryName: string) => `workspace/${policyID}/categories/${encodeURI(categoryName)}` as const,


This line introduced regression #37885, because encodeURI won't encode /.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI#description

feat: category settings init

581f720

ArekChr changed the title ~~feat: category settings init~~ feat: category settings page Feb 26, 2024

luacmartins mentioned this pull request Feb 26, 2024

[HOLD for Payment April 2nd, 2024][Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category #35708

Closed

luacmartins self-requested a review February 27, 2024 00:46

luacmartins reviewed Feb 27, 2024

View reviewed changes

Comment thread src/libs/actions/Policy.ts Outdated

ArekChr commented Feb 27, 2024

View reviewed changes

Comment thread src/pages/workspace/categories/CategorySettingsPage.tsx Outdated

ArekChr added 5 commits February 27, 2024 11:44

fix: set policy categories params to string as strignified object

8256c93

fix: hide offline indicator in RHP

5fec6fd

Merge branch 'main' into feat/category_settings_page

eb30d4f

Merge branch 'main' into feat/category_settings_page

984a729

fix: remove disabled menu item

3b12585

luacmartins requested changes Feb 28, 2024

View reviewed changes

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/libs/actions/Policy.ts

Comment thread src/libs/actions/Policy.ts Outdated

ArekChr added 5 commits February 29, 2024 09:43

Merge branch 'main' into feat/category_settings_page

4aa8daf

fix: conflicts

1698e9a

fix: pending action and errors in onyx

6831991

show offline feedback for enabled prop in category, fix onyx optimist…

4e4c7f3

…ic data

fix: offline indicator on the bottom on mobile platforms on category …

f020194

…settings and categories settings

ArekChr requested a review from luacmartins February 29, 2024 13:24

ArekChr marked this pull request as ready for review February 29, 2024 13:24

ArekChr requested a review from a team as a code owner February 29, 2024 13:24

melvin-bot bot requested review from ishpaul777 and removed request for a team February 29, 2024 13:24

ArekChr commented Feb 29, 2024

View reviewed changes

luacmartins requested changes Feb 29, 2024

View reviewed changes

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/libs/actions/Policy.ts Outdated

Comment thread src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

luacmartins added the Design label Feb 29, 2024

ishpaul777 reviewed Feb 29, 2024

View reviewed changes

Comment thread src/pages/workspace/categories/CategorySettingsPage.tsx Outdated

ArekChr added 5 commits March 1, 2024 09:46

fix: clear onyx errors, show back chevron

a529784

fix: missing import

ba0c181

refactor: improve ts

c77d0f4

fix: show one latest error in catgory settings

21cbb10

fix: policy category error field add null values

e840259

ArekChr requested review from ishpaul777 and luacmartins March 1, 2024 09:31

ArekChr added 2 commits March 1, 2024 10:34

fix: remove unused import

e8b86d5

Merge branch 'main' into feat/category_settings_page

7db77b2

rezkiy37 reviewed Mar 1, 2024

View reviewed changes

Comment thread src/libs/actions/Policy.ts

luacmartins approved these changes Mar 1, 2024

View reviewed changes

ishpaul777 approved these changes Mar 1, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 1, 2024 14:59

luacmartins approved these changes Mar 1, 2024

View reviewed changes

luacmartins merged commit 46fbe51 into Expensify:main Mar 1, 2024

melvin-bot bot added the Emergency label Mar 1, 2024

luacmartins removed the Emergency label Mar 1, 2024

luacmartins mentioned this pull request Mar 1, 2024

[Categories] [LOW] Update the categories settings page copy #37614

Closed

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

hungvu193 reviewed Mar 19, 2024

View reviewed changes

hungvu193 mentioned this pull request Mar 19, 2024

[HOLD for payment 2024-03-25] [$500] [Wave Collect] [Categories] Categories - Not here page shows up when opening Parent/ and Parent/: Child category #37885

Closed

6 tasks

Conversation

ArekChr commented Feb 26, 2024 • edited by iwiznia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Feb 29, 2024

Uh oh!

ArekChr commented Feb 29, 2024

Uh oh!

ArekChr commented Feb 29, 2024

Uh oh!

ArekChr Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArekChr commented Feb 29, 2024

Uh oh!

ishpaul777 commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Feb 29, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Feb 29, 2024

Uh oh!

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 1, 2024

Uh oh!

luacmartins commented Mar 1, 2024

Uh oh!

OSBotify commented Mar 1, 2024

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

hungvu193 Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ArekChr commented Feb 26, 2024 •

edited by iwiznia

Loading

ishpaul777 Feb 29, 2024 •

edited

Loading

ishpaul777 commented Feb 29, 2024 •

edited

Loading

ishpaul777 commented Feb 29, 2024 •

edited

Loading