[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript by pac-guerreiro · Pull Request #39206 · Expensify/App

pac-guerreiro · 2024-03-28T18:44:23Z

Details

The original PR had to be reverted because it introduced errors on main.

Fixed Issues

$ #25309 #25310 #25311 #25312 #25313
PROPOSAL: N/A

Tests

N/A

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

…', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript" This reverts commit 39aaa56.

melvin-bot · 2024-03-28T18:44:50Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr · 2024-03-28T21:27:27Z

-const formatEntryDuration = (entry) => {
    if ('baseline' in entry && 'current' in entry) {
-        return format.formatDurationDiffChange(entry);
+        formattedDuration = format.formatDurationDiffChange(entry);


this is a bit more verbose, wondering why we needed this vs what we had before, did TS complain?

@youssef-lr Yeah, TS complained before!

marcaaron

LGTM. Let's test it before we merge this time 😅

…25312-25313-to-typescript

pac-guerreiro · 2024-04-03T08:09:39Z

@youssef-lr can you review this again and check that it's working so that we can merge this? Thanks 😄

…s failing because of daylight saving time

…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts # tests/unit/OptionsListUtilsTest.ts

…25312-25313-to-typescript

blazejkustra · 2024-04-04T07:59:18Z

@youssef-lr Kind bump 💌

fabioh8010 · 2024-04-04T15:08:11Z

@pac-guerreiro we have merge conflicts

…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts

pac-guerreiro · 2024-04-04T17:04:38Z

@fabioh8010 @blazejkustra @youssef-lr merge conflicts resolved!

fabioh8010 · 2024-04-04T17:28:53Z

@youssef-lr all yours!

youssef-lr · 2024-04-04T22:52:43Z

Testing now!

youssef-lr

LGTM

youssef-lr · 2024-04-04T23:01:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

youssef-lr · 2024-04-04T23:03:25Z

@pac-guerreiro conflicts sorry :/ I was not feeling well past few days apologies for the delay

…25312-25313-to-typescript

pac-guerreiro · 2024-04-05T09:23:07Z

@youssef-lr @fabioh8010 conflicts resolved, have fun! 😄

youssef-lr · 2024-04-05T11:42:47Z

did we get conflicts again?

fabioh8010 · 2024-04-05T15:28:07Z

@youssef-lr Here is not showing any conflicts 🤔

youssef-lr · 2024-04-05T15:29:29Z

Ok I was able to merge from mobile. Not sure why on desktop it was stuck like that.

OSBotify · 2024-04-08T11:08:53Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:05:31Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:23:08Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Reapply "[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js…

8244501

…', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript" This reverts commit 39aaa56.

pac-guerreiro requested a review from a team as a code owner March 28, 2024 18:44

melvin-bot Bot removed the request for review from a team March 28, 2024 18:44

melvin-bot Bot requested a review from youssef-lr March 28, 2024 18:44

pac-guerreiro mentioned this pull request Mar 28, 2024

[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript #37206

Merged

48 tasks

fix(typescript): jest tests and types

8fc529a

youssef-lr reviewed Mar 28, 2024

View reviewed changes

marcaaron self-requested a review March 29, 2024 04:09

marcaaron assigned pac-guerreiro Mar 29, 2024

marcaaron previously approved these changes Mar 29, 2024

View reviewed changes

Merge branch 'main' into pac-guerreiro/fix/migrate-25309-25310-25311-…

b50d838

…25312-25313-to-typescript

pac-guerreiro dismissed marcaaron’s stale review via b50d838 April 3, 2024 08:08

pac-guerreiro added 3 commits April 3, 2024 09:49

chore(dateutilstest): revert selected timezone change to prevent test…

cf08e80

…s failing because of daylight saving time

Merge branch 'main' into pac-guerreiro/fix/migrate-25309-25310-25311-…

aa4deb1

…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts # tests/unit/OptionsListUtilsTest.ts

Merge branch 'main' into pac-guerreiro/fix/migrate-25309-25310-25311-…

6d2ac5d

…25312-25313-to-typescript

blazejkustra approved these changes Apr 4, 2024

View reviewed changes

Merge branch 'main' into pac-guerreiro/fix/migrate-25309-25310-25311-…

20b34e9

…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts

blazejkustra approved these changes Apr 4, 2024

View reviewed changes

youssef-lr previously approved these changes Apr 4, 2024

View reviewed changes

Merge branch 'main' into pac-guerreiro/fix/migrate-25309-25310-25311-…

11ee146

…25312-25313-to-typescript

pac-guerreiro dismissed youssef-lr’s stale review via 11ee146 April 5, 2024 09:19

youssef-lr approved these changes Apr 5, 2024

View reviewed changes

youssef-lr merged commit 24888fc into Expensify:main Apr 5, 2024

github-actions Bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

Conversation

pac-guerreiro commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 28, 2024

Uh oh!

youssef-lr Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

pac-guerreiro Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

pac-guerreiro commented Apr 3, 2024

Uh oh!

blazejkustra commented Apr 4, 2024

Uh oh!

fabioh8010 commented Apr 4, 2024

Uh oh!

pac-guerreiro commented Apr 4, 2024

Uh oh!

fabioh8010 commented Apr 4, 2024

Uh oh!

youssef-lr commented Apr 4, 2024

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Apr 4, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

youssef-lr commented Apr 4, 2024

Uh oh!

pac-guerreiro commented Apr 5, 2024

Uh oh!

youssef-lr commented Apr 5, 2024

Uh oh!

fabioh8010 commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youssef-lr commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

OSBotify commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pac-guerreiro commented Mar 28, 2024 •

edited

Loading

fabioh8010 commented Apr 5, 2024 •

edited

Loading

youssef-lr commented Apr 5, 2024 •

edited

Loading