Hide notification badge on iOS app reinstall by ShridharGoel · Pull Request #39410 · Expensify/App

ShridharGoel · 2024-04-02T15:01:19Z

Details

Hide notification badge on iOS app reinstall.

Fixed Issues

$ #38715
PROPOSAL: #38715 (comment)

Tests

Ensure that you have a badge icon on the Expensify logo on iOS.
Uninstall the app.
Install it again via App Store.
Badge with notification count should show.
Close the app.
Badge should not show.

QA Steps

Ensure that you have a badge icon on the Expensify logo on iOS.
Uninstall the app.
Install it again via App Store.
Badge with notification count should show.
Close the app.
Badge should not show.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-03.at.1.09.20.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-03.at.1.03.49.PM.mov

iOS: Native

Screen.Recording.2024-04-02.at.8.28.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-03.at.1.02.34.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-03.at.12.59.34.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-03.at.1.00.11.PM.mov

melvin-bot · 2024-04-02T15:01:24Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-04-03T06:16:10Z

  // They will be passed down to the ViewController used by React Native.
  self.initialProps = @{};
-  
+


Revert this change

jayeshmangwani · 2024-04-03T06:16:15Z

  [RCTBootSplash initWithStoryboard:@"BootSplash"
                           rootView:(RCTRootView *)self.window.rootViewController.view]; // <- initialization using the storyboard file name
-  
+


Revert this change

jayeshmangwani · 2024-04-03T06:52:30Z

@ShridharGoel Though changes are in the native iOS files, we have to upload screenshots/videos for all the platforms for the checklist, so if you can just run the app for all the remaining platforms and record a video and update it to PR, it would be appreciated.

ShridharGoel · 2024-04-03T07:40:49Z

@jayeshmangwani Updated.

jayeshmangwani · 2024-04-03T08:13:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Lint is failing in local, its also failing in main, so not related to this PR

Changes LGTM 🚀

jayeshmangwani · 2024-04-03T10:26:43Z

@ShridharGoel @johnmlee101 Before merging this PR, I just wanted to clarify that I was testing the existing behavior of the app store on the iPhone Xs; on my side, I have tested the App Store app showing a badge when I install the app, but after opening the app, the badge is disappeared for me, so what we are trying to do in this PR, is already working for me, but not sure why, but for one of a tester badge is persistent after opening the app too.

RPReplay_Final1712139028_resized.mp4

jayeshmangwani · 2024-04-03T10:33:40Z

@ShridharGoel Remove the Details section or update; Current details are irrelevant to this PR.

ShridharGoel · 2024-04-03T11:08:07Z

@jayeshmangwani Then it seems that it's not happening on all devices. But at least this code change would ensure that it gets fixed for all.

ShridharGoel · 2024-04-05T03:12:57Z

@johnmlee101 Can you have a look?

OSBotify · 2024-04-05T16:13:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T11:09:32Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:06:10Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:23:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ShridharGoel requested a review from a team as a code owner April 2, 2024 15:01

melvin-bot Bot requested review from jayeshmangwani and removed request for a team April 2, 2024 15:01

Hide notification badge on iOS app reinstall

cb1cc78

ShridharGoel force-pushed the ios-badge branch from fee4714 to cb1cc78 Compare April 2, 2024 15:02

ShridharGoel mentioned this pull request Apr 2, 2024

[$500] There are notification of unread message on fresh install of the app #38715

Closed

6 tasks

jayeshmangwani reviewed Apr 3, 2024

View reviewed changes

Update AppDelegate.mm

9e775d5

jayeshmangwani approved these changes Apr 3, 2024

View reviewed changes

melvin-bot Bot requested a review from johnmlee101 April 3, 2024 08:17

johnmlee101 approved these changes Apr 5, 2024

View reviewed changes

johnmlee101 merged commit b10893a into Expensify:main Apr 5, 2024

github-actions Bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

		// They will be passed down to the ViewController used by React Native.
		self.initialProps = @{};

		[RCTBootSplash initWithStoryboard:@"BootSplash"
		rootView:(RCTRootView *)self.window.rootViewController.view]; // <- initialization using the storyboard file name

Conversation

ShridharGoel commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 2, 2024

Uh oh!

jayeshmangwani Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Apr 3, 2024

Uh oh!

ShridharGoel commented Apr 3, 2024

Uh oh!

jayeshmangwani commented Apr 3, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Apr 3, 2024

Uh oh!

jayeshmangwani commented Apr 3, 2024

Uh oh!

ShridharGoel commented Apr 3, 2024

Uh oh!

ShridharGoel commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Apr 5, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

OSBotify commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShridharGoel commented Apr 2, 2024 •

edited

Loading

ShridharGoel commented Apr 5, 2024 •

edited

Loading