[HelpDot] rename olddot hubs and update description#39576
Merged
MariaHCD merged 2 commits intoExpensify:mainfrom Apr 5, 2024
Merged
[HelpDot] rename olddot hubs and update description#39576MariaHCD merged 2 commits intoExpensify:mainfrom
MariaHCD merged 2 commits intoExpensify:mainfrom
Conversation
Member
Author
|
@fedirjh please approve to assign internal |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #39278 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
fedirjh
approved these changes
Apr 4, 2024
Contributor
|
Looks good but there are conflicts |
Member
Author
|
@MariaHCD conflicts resolved |
MariaHCD
approved these changes
Apr 5, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@MariaHCD looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.61-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.61-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀
|
This was referenced Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #39278
PROPOSAL: N.A.
Tests
cd docs && npm run createDocsRoutes && bundle exec jekyll serve --livereload --safeOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Details