[CP Staging] fix: taxpicker selection for tax settings by teneeto · Pull Request #39646 · Expensify/App

teneeto · 2024-04-04T19:42:25Z

Details

This PR fixes taxPicker selection for tax settings. The tax picker was missing a policyID prop which is needed to get policy tax rates from onyx. Also, we needed to update logic for the selected tax Rate.

Fixed Issues

$ #39602
PROPOSAL: issuecomment

Tests

.Create a new (Collect) workspace.
Go to Collect workspace settings > More features
Toggle on Taxes.
Go to Taxes tab.
Click Settings > Workspace currency default.
Go to Foreign currency default.
Click on the selected default tax.
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list

Verify that no errors appear in the JS console

Offline tests

.Create a new (Collect) workspace.
Go to Collect workspace settings > More features
Toggle on Taxes.
Go to Taxes tab.
Click Settings > Workspace currency default.
Go to Foreign currency default.
Click on the selected default tax.
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list

QA Steps

.Create a new (Collect) workspace.
Go to Collect workspace settings > More features
Toggle on Taxes.
Go to Taxes tab.
Click Settings > Workspace currency default.
Go to Foreign currency default.
Click on the selected default tax.
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-04-04.at.20.44.59.mov

iOS: Native

Screen.Recording.2024-04-04.at.21.22.56.mov

Android: Native

Screen.Recording.2024-04-04.at.22.11.36.mov

Android: mWeb Chrome

iOS: mWeb Safari

MacOS: Desktop

melvin-bot · 2024-04-04T19:42:53Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2024-04-04T21:36:51Z

@MonilBhavsar Should we get the original C+ to review this one so we can merge it?

jasperhuangg · 2024-04-04T23:02:45Z

@pecanoro I'm good with that, feel free to assign them

jasperhuangg · 2024-04-05T02:44:32Z

@pecanoro the C+ from the other issue is offline so I reached out in the C+ channel to get someone to pick it up

c3024 · 2024-04-05T02:51:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

taxAndroid.mp4

Android: mWeb Chrome

taxAndroidChrome.mp4

iOS: Native

taxiOS.mp4

iOS: mWeb Safari

taxiOSSafari.mp4

MacOS: Chrome / Safari

taxChrome.mp4

MacOS: Desktop

taxDesktop.mp4

c3024 · 2024-04-05T04:55:08Z

There are a couple of warnings which appear on prod as well.

Toggling taxes on shows a not found page for a second

notFoundPage.mp4

A warning on listener (this is not related to this PR)

These are happening on production as well so not blockers.

c3024

LGTM

melvin-bot · 2024-04-05T04:55:32Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #39681.

MonilBhavsar

Looks good!

OSBotify · 2024-04-05T05:08:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…for-tax-settings [CP Staging] fix: taxpicker selection for tax settings (cherry picked from commit 3ee7004)

OSBotify · 2024-04-05T11:11:31Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.60-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-05T11:25:49Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.60-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-08T10:58:59Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

teneeto added 3 commits April 4, 2024 20:40

make transaction in getDefaultTaxName optional

0aa3526

fix taxPicker selection for WorkspaceTaxesSettingsForeignCurrency

be56460

fix taxPicker selection for WorkspaceTaxesSettingsWorkspaceCurrency

bd3788f

teneeto requested a review from a team as a code owner April 4, 2024 19:42

melvin-bot Bot removed the request for review from a team April 4, 2024 19:42

melvin-bot Bot requested a review from MonilBhavsar April 4, 2024 19:42

MonilBhavsar reviewed Apr 4, 2024

View reviewed changes

Comment thread src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx Outdated

Comment thread src/pages/workspace/taxes/WorkspaceTaxesSettingsWorkspaceCurrency.tsx

Comment thread src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx Outdated

MonilBhavsar requested a review from pecanoro April 4, 2024 19:54

MonilBhavsar mentioned this pull request Apr 4, 2024

Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate #39602

Closed

6 tasks

MonilBhavsar changed the title ~~fix: taxpicker selection for tax settings~~ [CP Staging] fix: taxpicker selection for tax settings Apr 4, 2024

fix review comment

4fc604d

pecanoro approved these changes Apr 4, 2024

View reviewed changes

c3024 approved these changes Apr 5, 2024

View reviewed changes

melvin-bot Bot mentioned this pull request Apr 5, 2024

Payment issue for E/App PR#39646 #39681

Closed

MonilBhavsar approved these changes Apr 5, 2024

View reviewed changes

MonilBhavsar merged commit 3ee7004 into Expensify:main Apr 5, 2024

OSBotify pushed a commit that referenced this pull request Apr 5, 2024

Merge pull request #39646 from teneeto/fix/39602/taxpicker-selection-…

f6e4926

…for-tax-settings [CP Staging] fix: taxpicker selection for tax settings (cherry picked from commit 3ee7004)

github-actions Bot mentioned this pull request Apr 5, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

Conversation

teneeto commented Apr 4, 2024 • edited by pecanoro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pecanoro commented Apr 4, 2024

Uh oh!

jasperhuangg commented Apr 4, 2024

Uh oh!

jasperhuangg commented Apr 5, 2024

Uh oh!

c3024 commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 5, 2024

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 5, 2024

Uh oh!

OSBotify commented Apr 5, 2024

Uh oh!

OSBotify commented Apr 5, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

teneeto commented Apr 4, 2024 •

edited by pecanoro

Loading

c3024 commented Apr 5, 2024 •

edited

Loading

c3024 commented Apr 5, 2024 •

edited

Loading