Update redirects.csv for tax and copilots and delegates#39648
Update redirects.csv for tax and copilots and delegates#39648MonilBhavsar merged 1 commit intomainfrom
Conversation
Redirecting dead helpdot links with the correct redirects
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
A preview of your ExpensifyHelp changes have been deployed to https://931e4f95.helpdot.pages.dev ⚡️ |
| https://help.expensify.com/articles/expensify-classic/workspace-and-domain-settings/Tags,https://help.expensify.com/articles/expensify-classic/workspaces/Tags | ||
| https://help.expensify.com/articles/expensify-classic/copilots-and-delegates/User-Roles,https://help.expensify.com/articles/expensify-classic/workspaces/Change-member-workspace-roles | ||
| https://help.expensify.com/articles/expensify-classic/workspace-and-domain-settings/tax-tracking,https://help.expensify.com/articles/expensify-classic/expenses/expenses/Apply-Tax | ||
| https://help.expensify.com/articles/expensify-classic/copilots-and-delegates/User-Roles.html,https://help.expensify.com/expensify-classic/hubs/copilots-and-delegates/ |
There was a problem hiding this comment.
Are we sure we want to redirect from https://help.expensify.com/articles/expensify-classic/copilots-and-delegates/User-Roles.html to https://help.expensify.com/expensify-classic/hubs/copilots-and-delegates/
Asking as,
- the source link contains html
- And is a valid URL
- And is specific to user roles, while target is general url about /copilots-and-delegates/
There was a problem hiding this comment.
Yes! I have confirmed with @caitlinwhite1 we want the redirect to go there for now.
There was a problem hiding this comment.
Thank you for confirming!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.61-0 🚀
|
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.61-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀
|
Redirecting dead helpdot links with the correct redirects
Details
Working out of [this GH](https://github.com/Expensify/Expensify/issues/381301)Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/381301
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined