fix just display track expense of selfDM is loaded #40409

nkdengineer · 2024-04-18T09:38:33Z

Details

Fixed Issues

$ #40257
PROPOSAL: #40257 (comment)

Tests

Create a new account
Track Expense
After entering an amount, click 'Next'
You should see a final confirmation page, instead of seeing a participant selector page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a new account
Track Expense
After entering an amount, click 'Next'
You should see a final confirmation page, instead of seeing a participant selector page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-18.at.16.52.10.mov

Android: mWeb Chrome

Screen.Recording.2024-04-18.at.16.58.12.mov

iOS: Native

Screen.Recording.2024-04-18.at.17.02.25.mov

iOS: mWeb Safari

Screen.Recording.2024-04-18.at.17.00.42.mov

MacOS: Chrome / Safari

output.mp4

MacOS: Desktop

output.mp4

melvin-bot · 2024-04-18T09:38:38Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-04-18T16:10:38Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

                        onSelected: () => interceptAnonymousUser(Report.startNewChat),
                    },
-                    ...(canUseTrackExpense
+                    ...(canUseTrackExpense && selfDMReportID


I'm not sure how did you record the video in the checklist author but this line completely broke the current logic, it will make the Track expense button disappear if it's not selfDMReportID 😱

tbh, I prefer disable that button while report is loading, because even when you can go to next page when report is loading, you still can't get the personal detail 🤔 , yeah I'm talking about slow 3g case.

Screen.Recording.2024-04-19.at.08.16.46.mov

It will make the Track expense button disappear if it's not selfDMReportID

You mean in case the selfDMReportID is undefined, the Track expense button will disappear, right?

~~I don't think this is BE bug, revert the change make it worked as expected~~

OK, I see the problem now. For some accounts, ie my high traffic account, selfDMReport is not added to our allReports, I tried both reseting cache and logging out but no luck.

Related slack thread:
https://expensify.slack.com/archives/C049HHMV9SM/p1711754709599749

GH:
#39765

Yeah there definitely is a BE component to it - however I think we should also handle it better in the FE.

I like the idea of hiding the option

Ok cool. I'll complete the checklist then

hungvu193 · 2024-04-19T02:44:27Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

        }
    };
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    const selfDMReportID = useMemo(() => ReportUtils.findSelfDMReportID(), [isLoading]);


~~This useMemo cause the issue I mentioned.~~

selfDMReportID here 's always undefined, even I logout 🤔

Did you test the PR with high traffic account? @nkdengineer

I just tested with the account I used to test other issues. What is the high-traffic account?

Ideally, you should test your PR with a high traffic account, it's account with ton of reports, check it out here:
https://github.com/Expensify/App/blob/68e69623a8bca0dce5f384fa351d5cbb2214aeb4/contributingGuides/CONTRIBUTING.md#high-traffic-accounts

@hungvu193 I just tested it in high traffic account and it works well

hungvu193 · 2024-04-19T19:32:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-20.at.02.26.35.mov

Android: mWeb Chrome

Screen.Recording.2024-04-20.at.02.31.22.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desktop.mov

hungvu193

LGTM 🚀

thienlnam

Great! Thanks for the quick work here

OSBotify · 2024-04-19T19:44:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-23T23:44:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix just display track expense of selfDM is loaded

459d4e8

nkdengineer requested a review from a team as a code owner April 18, 2024 09:38

melvin-bot bot requested review from hungvu193 and removed request for a team April 18, 2024 09:38

nkdengineer mentioned this pull request Apr 18, 2024

CRITICAL: [Track Expense] [$500] Track Expense sometimes opens the participant selector #40257

Closed

6 tasks

nkdengineer added 2 commits April 18, 2024 17:11

fix lint

55b4f52

fix lint

0b61a9d

hungvu193 suggested changes Apr 18, 2024

View reviewed changes

hungvu193 suggested changes Apr 19, 2024

View reviewed changes

hungvu193 approved these changes Apr 19, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam April 19, 2024 19:33

thienlnam approved these changes Apr 19, 2024

View reviewed changes

thienlnam merged commit 3a3db88 into Expensify:main Apr 19, 2024

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

ZhenjaHorbach mentioned this pull request Apr 23, 2024

Track expense - Track expense option is not displayed in fab. #40752

Closed

6 tasks

fix just display track expense of selfDM is loaded #40409

fix just display track expense of selfDM is loaded #40409

Uh oh!

Conversation

nkdengineer commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Apr 19, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 19, 2024

Uh oh!

OSBotify commented Apr 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Apr 18, 2024 •

edited

Loading

nkdengineer Apr 19, 2024 •

edited

Loading

hungvu193 Apr 19, 2024 •

edited

Loading

hungvu193 Apr 19, 2024 •

edited

Loading

hungvu193 Apr 19, 2024 •

edited

Loading

hungvu193 Apr 19, 2024 •

edited

Loading