[App PR #41278] Prevent users from disabling accounting feature if there is active accounting connection by hayata-suenaga · Pull Request #40940 · Expensify/App

hayata-suenaga · 2024-04-24T20:28:09Z

Details

When there is a connection with an accounting software, we have to prevent the user from disabling the accounting integration feature on the MoreFeatures page.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/390465
PROPOSAL: N/A

Tests / QA Steps

Log into New Expensify with an account that is on the accounting beta
Enable the Accounting feature on the More Features page
Go to the Accounting screen and connect to QBO
Go to the More Features screen and confirm that the toggle next to Accounting is disabled with the lock icon.
Go back to the Accounting screen and disconnect the QBO (you have to click the three-dot icon to open the modal to show the disconnect button)e
Go back to the More Features screen and confirm that the toggle button next to Accounting is no longer disabled
Confirm that you can toggle the toggle button

Offline tests

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

… an active accounting connection

…ction to any of the accounting software

melvin-bot · 2024-04-24T20:28:14Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2024-04-24T20:31:17Z

@s77rt, can you do a code review for this one, please?
@eVoloshchak, I'm assigning @s77rt as the C+ as they have the context of this project.

s77rt · 2024-04-24T21:07:22Z

Yes sure, will review later today

s77rt · 2024-04-25T00:48:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Having build errors

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-04-25T00:50:14Z

 WorkspaceMoreFeaturesPage.displayName = 'WorkspaceMoreFeaturesPage';

-export default withPolicyAndFullscreenLoading(WorkspaceMoreFeaturesPage);
+export default withPolicyConnections(WorkspaceMoreFeaturesPage);


This is causing a bug.

Sign out

Sign in

Go offline

Go to the more features page

Page should be accessible offline

I just realised that all the components that use this HOC do not work offline (unless the connections are already present in Onyx)

@aldo-expensify, how should be handle this? We want to make sure that we don't allow the admin from disabling the accounting feature when the workspace is connected to the QBO. But to do that, we need the connections data. When the connections data hasn't been fetched and the device is offline, we cannot tell if there is an accounting connection or not.

@s77rt, am I right that all screens, including Categories and Tags screens, that were previously offline first that were later modified to use withPolicyConnections will not be offline first

Yes that's correct.

hayata-suenaga · 2024-04-26T02:28:18Z

We decided to use Pattern B here.

I'm working on the backend code right now to send the error to the front end.

I'll modify this PR to read the error and display the error received form the backend.

hayata-suenaga · 2024-04-30T01:38:37Z

Creating a custom hook here

…ng-feature-if-there-is-active-accounting-connection

hayata-suenaga · 2024-05-01T18:49:57Z

PR is ready for another review 🙇

s77rt · 2024-05-01T21:32:51Z

@hayata-suenaga Shouldn't we display the returned error from BE?

Screen.Recording.2024-05-01.at.10.30.40.PM.mov

hayata-suenaga · 2024-05-01T21:54:39Z

@s77rt that is handled in this PR

melvin-bot · 2024-05-01T22:02:58Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-05-01T22:03:01Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #41461.

…ng-feature-if-there-is-active-accounting-connection

aldo-expensify

@hayata-suenaga I left a comment here about the new hook: #41278 (comment)

In summary, I think we may need to rethink the approach because the usage of the hook is breaking 1:1:1 IMO

aldo-expensify · 2024-05-02T18:17:48Z

@hayata-suenaga we can close this one, right?

neil-marcellini · 2024-05-02T19:08:44Z

Oh wow good catch Aldo, it's easy to miss seeing that, but I agree it's not the right approach.

hayata-suenaga · 2024-05-02T20:22:36Z

this method is getting the entire policy object, including connections field so we don't have to call the custom hook to fetch connnections field separately.

also the custom hook was deleted recently 🙇

OSBotify · 2024-05-09T02:10:28Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Hayata Suenaga added 2 commits April 24, 2024 15:11

fix: prevent the user from disabling accounting feature when there is…

441415f

… an active accounting connection

fix: fetch the connections data and check if there is an active conne…

1c20746

…ction to any of the accounting software

hayata-suenaga self-assigned this Apr 24, 2024

hayata-suenaga requested a review from a team as a code owner April 24, 2024 20:28

melvin-bot Bot requested review from eVoloshchak and removed request for a team April 24, 2024 20:28

hayata-suenaga requested review from s77rt and removed request for eVoloshchak April 24, 2024 20:30

s77rt reviewed Apr 25, 2024

View reviewed changes

hayata-suenaga changed the title ~~Prevent users from disabling accounting feature if there is active accounting connection~~ [App PR #41278] Prevent users from disabling accounting feature if there is active accounting connection Apr 30, 2024

Hayata Suenaga added 3 commits May 1, 2024 11:43

fix: remove the usage of withPolicyConnections

6a7eef7

Merge branch 'main' into hayata-prevent-users-from-disabling-accounti…

7046011

…ng-feature-if-there-is-active-accounting-connection

feat: ensure fetching policy connections on the more features page

a650982

hayata-suenaga requested review from aldo-expensify and s77rt May 1, 2024 18:48

s77rt approved these changes May 1, 2024

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini May 1, 2024 22:02

melvin-bot Bot mentioned this pull request May 1, 2024

Payment issue for E/App PR#40940 #41461

Closed

Merge branch 'main' into hayata-prevent-users-from-disabling-accounti…

e396757

…ng-feature-if-there-is-active-accounting-connection

aldo-expensify requested changes May 2, 2024

View reviewed changes

chore: remove non-existing hook

ef2f428

aldo-expensify approved these changes May 2, 2024

View reviewed changes

aldo-expensify merged commit 39f3a85 into main May 2, 2024

aldo-expensify deleted the hayata-prevent-users-from-disabling-accounting-feature-if-there-is-active-accounting-connection branch May 2, 2024 22:36

github-actions Bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

Conversation

hayata-suenaga commented Apr 24, 2024

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

s77rt commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s77rt Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga commented Apr 26, 2024

Uh oh!

hayata-suenaga commented Apr 30, 2024

Uh oh!

hayata-suenaga commented May 1, 2024

Uh oh!

s77rt commented May 1, 2024

Uh oh!

hayata-suenaga commented May 1, 2024

Uh oh!

melvin-bot Bot commented May 1, 2024

Uh oh!

melvin-bot Bot commented May 1, 2024

Uh oh!

aldo-expensify left a comment

Choose a reason for hiding this comment

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

neil-marcellini commented May 2, 2024

Uh oh!

hayata-suenaga commented May 2, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

s77rt commented Apr 25, 2024 •

edited

Loading

hayata-suenaga Apr 25, 2024 •

edited

Loading