Fullstory integration Update.

[LCOleksii]

Details

• FS Pod dependency updated to 1.48
• React-Native FS lib updated to 1.4.2
• Video preview, Attachment Preview fs-exclude class added to exclude session recording.
• Cleanup redundant fsClass="fs-exclude" and props

Fixed Issues

$ #40910
$ #40784

Tests

1. Click on the attachment upload menu
2. Upload an Video via file manager selection
3. Verify a modal appears displaying a preview of the Video
4. Upload the Attachment file

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Login to the App
2. Open chat
3. Click on the attachment upload menu
4. Upload an Video via file manager selection
5. Verify a modal appears displaying a preview of the Video
6. Upload the Attachment file

• Verify that app does not crash
• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://drive.google.com/file/d/1EQRkfkWRo5Gm8uBQ_nSJg-h5XqDBJwqB/view?usp=drive_link

iOS: Native

https://drive.google.com/file/d/1R3ALatTtvHBW-E0x4PqhbcUrVv70s1UC/view?usp=drive_link

MacOS: Chrome / Safari

https://drive.google.com/file/d/1pK0UacdVlrCWuSCSLpsrGs7rHsjiGu-N/view?usp=drive_link

MacOS: Desktop

https://drive.google.com/file/d/1m2DdKWPDjrY7HAVVhHeRLZNhgmGlSVAq/view?usp=drive_link

[melvin-bot]

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[danieldoglas]

@alitoshmatov , removing you from this one since @ishpaul777 was already assigned to the original issue!

[danieldoglas]

@LCOleksii can you please apply this PR on top of yours? https://github.com/Expensify/App/pull/40807/files

We've implemented the user metadata keys, so now you can use those to map everything instead of the session key. That was reverted with the other changes.

[ishpaul777]

Hey @LCOleksii Can you please resolve lint issues

[danieldoglas]

Looks like we're still missing this:

can you please apply this PR on top of yours? https://github.com/Expensify/App/pull/40807/files

[ishpaul777]

This is on my list for testing today, will pick this last because it requires a full rebuild of both native apps 🙇‍♂️

[danieldoglas]

@ishpaul777 theres one more commit incoming, so please wait until that's done!

[ishpaul777]

hey @LCOleksii App seems to crash when opening a video (IOS)

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-05-21.at.00.34.26.mp4

Also, Can you please upload remaining test videos, preferably on github so its easy review them.

[LCOleksii]

Hi @ishpaul777
Cannot reproduce the issue, also prior last commit push i have checked locally.
Please Insure that you had:

• Clean the project ('npm run clean') + node_modules remove (to be sure no cache issues, we had similar issues that could be fixed only after proper clean, especially if you are switching between the branches)
• Reinstalled all the pods for IOs build
• Deleted previous build from the IOs simulator
• Build the new version from the branch

Please see the latest recording:

Simulator Screen Recording - iPhone 15 Plus - 2024-05-20 at 22.37.25

If after this the issue still persist, please could you provide full crash log for investigation.

[ishpaul777]

On dev build, its still crashing (followed all of the above steps)

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42046/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42046/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42046/NewExpensify.dmg	https://42046.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ishpaul777]

Okay it works well on Adhoc, let me ask someone else to build it on their DEV enviornment https://expensify.slack.com/archives/C02NK2DQWUX/p1716288064932099

Adhoc video

trim.E5267B68-7FC5-4F18-BA73-A50631F18DE4.MOV

[ishpaul777]

Approving since adhoc works fine 🤷

[kbecciv]

Attachment - Corrupted pdf can be uploaded without error

Version Number: v1.4.74-4
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4567937

Action Performed:

1. Launch New Expensify app.
2. Go to any chat.
3. Go to + > Add attachment > Choose document.
4. Select a corrupted pdf file (attached below).
5. Upload the corrupted file.

Expected Result:

In Step 4, the preview will show "Failed to load PDF file" (production behavior).
In Step 5, the corrupted file will not be uploaded and shows "Failed to load PDF file" (production behavior).

Actual Result:

In Step 4, the preview shows filename.pdf.
In Step 5, the corrupted file is uploaded successfully.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• iOS: Native

Screenshots/Videos

Add any screenshot/video evidence

IMG_7006.MP4

Bug6487529_1716302300396.Screen_Recording_20240521_223230_New_Expensify.mp4

[ishpaul777]

Above is not a bug but expected behaviour from #38010

[danieldoglas]

@ishpaul777 I've done a few other changes, can you please recheck/approve? this will only affect loading the fullstory lib in production, so you don't need to do all tests again

[ishpaul777]

[danieldoglas]

Nice, once merge freeze is lifted, we'll merge this!

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.76-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅